aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLendacky, Thomas <Thomas.Lendacky@amd.com>2014-06-24 17:19:35 -0400
committerDavid S. Miller <davem@davemloft.net>2014-06-26 20:14:04 -0400
commit66f95c35c413f674a835034dc667099b44225df2 (patch)
treed0c63d120b8f0a27afde54a8802eb2975e865b3f
parentb85e4d8960f10e4b28613a3e7b76f8889a2089e3 (diff)
amd-xgbe: Resolve checkpatch warning about sscanf usage
Checkpatch issued a warning preferring to use kstrto<type> when using a single variable sscanf. Change the sscanf invocation to a kstrtouint call. Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c
index 6bb76d5c817b..81198587a6c6 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c
@@ -151,7 +151,7 @@ static ssize_t xgbe_common_write(const char __user *buffer, size_t count,
151{ 151{
152 char workarea[32]; 152 char workarea[32];
153 ssize_t len; 153 ssize_t len;
154 unsigned int scan_value; 154 int ret;
155 155
156 if (*ppos != 0) 156 if (*ppos != 0)
157 return 0; 157 return 0;
@@ -165,10 +165,9 @@ static ssize_t xgbe_common_write(const char __user *buffer, size_t count,
165 return len; 165 return len;
166 166
167 workarea[len] = '\0'; 167 workarea[len] = '\0';
168 if (sscanf(workarea, "%x", &scan_value) == 1) 168 ret = kstrtouint(workarea, 0, value);
169 *value = scan_value; 169 if (ret)
170 else 170 return ret;
171 return -EIO;
172 171
173 return len; 172 return len;
174} 173}