diff options
author | Scott Wood <scottwood@freescale.com> | 2015-03-24 23:56:21 -0400 |
---|---|---|
committer | Dave Chinner <david@fromorbit.com> | 2015-03-24 23:56:21 -0400 |
commit | 65dd297ac25565701fead5e4ee69b9ca62729f0e (patch) | |
tree | 2d500028f2328edbe7d0da5aac48a70db48a9736 | |
parent | 29916df08db4726c92bdfe72ce524b4b6a9e3c54 (diff) |
xfs: %pF is only for function pointers
Use %pS for actual addresses, otherwise you'll get bad output
on arches like ppc64 where %pF expects a function descriptor.
Signed-off-by: Scott Wood <scottwood@freescale.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
-rw-r--r-- | fs/xfs/xfs_error.c | 2 | ||||
-rw-r--r-- | fs/xfs/xfs_trace.h | 20 |
2 files changed, 11 insertions, 11 deletions
diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c index 3ee186ac1093..338e50bbfd1e 100644 --- a/fs/xfs/xfs_error.c +++ b/fs/xfs/xfs_error.c | |||
@@ -131,7 +131,7 @@ xfs_error_report( | |||
131 | { | 131 | { |
132 | if (level <= xfs_error_level) { | 132 | if (level <= xfs_error_level) { |
133 | xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT, | 133 | xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT, |
134 | "Internal error %s at line %d of file %s. Caller %pF", | 134 | "Internal error %s at line %d of file %s. Caller %pS", |
135 | tag, linenum, filename, ra); | 135 | tag, linenum, filename, ra); |
136 | 136 | ||
137 | xfs_stack_trace(); | 137 | xfs_stack_trace(); |
diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 51372e34d988..b5ac81eeb061 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h | |||
@@ -115,7 +115,7 @@ DECLARE_EVENT_CLASS(xfs_perag_class, | |||
115 | __entry->refcount = refcount; | 115 | __entry->refcount = refcount; |
116 | __entry->caller_ip = caller_ip; | 116 | __entry->caller_ip = caller_ip; |
117 | ), | 117 | ), |
118 | TP_printk("dev %d:%d agno %u refcount %d caller %pf", | 118 | TP_printk("dev %d:%d agno %u refcount %d caller %ps", |
119 | MAJOR(__entry->dev), MINOR(__entry->dev), | 119 | MAJOR(__entry->dev), MINOR(__entry->dev), |
120 | __entry->agno, | 120 | __entry->agno, |
121 | __entry->refcount, | 121 | __entry->refcount, |
@@ -239,7 +239,7 @@ TRACE_EVENT(xfs_iext_insert, | |||
239 | __entry->caller_ip = caller_ip; | 239 | __entry->caller_ip = caller_ip; |
240 | ), | 240 | ), |
241 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " | 241 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " |
242 | "offset %lld block %lld count %lld flag %d caller %pf", | 242 | "offset %lld block %lld count %lld flag %d caller %ps", |
243 | MAJOR(__entry->dev), MINOR(__entry->dev), | 243 | MAJOR(__entry->dev), MINOR(__entry->dev), |
244 | __entry->ino, | 244 | __entry->ino, |
245 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), | 245 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), |
@@ -283,7 +283,7 @@ DECLARE_EVENT_CLASS(xfs_bmap_class, | |||
283 | __entry->caller_ip = caller_ip; | 283 | __entry->caller_ip = caller_ip; |
284 | ), | 284 | ), |
285 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " | 285 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " |
286 | "offset %lld block %lld count %lld flag %d caller %pf", | 286 | "offset %lld block %lld count %lld flag %d caller %ps", |
287 | MAJOR(__entry->dev), MINOR(__entry->dev), | 287 | MAJOR(__entry->dev), MINOR(__entry->dev), |
288 | __entry->ino, | 288 | __entry->ino, |
289 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), | 289 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), |
@@ -329,7 +329,7 @@ DECLARE_EVENT_CLASS(xfs_buf_class, | |||
329 | __entry->caller_ip = caller_ip; | 329 | __entry->caller_ip = caller_ip; |
330 | ), | 330 | ), |
331 | TP_printk("dev %d:%d bno 0x%llx nblks 0x%x hold %d pincount %d " | 331 | TP_printk("dev %d:%d bno 0x%llx nblks 0x%x hold %d pincount %d " |
332 | "lock %d flags %s caller %pf", | 332 | "lock %d flags %s caller %ps", |
333 | MAJOR(__entry->dev), MINOR(__entry->dev), | 333 | MAJOR(__entry->dev), MINOR(__entry->dev), |
334 | (unsigned long long)__entry->bno, | 334 | (unsigned long long)__entry->bno, |
335 | __entry->nblks, | 335 | __entry->nblks, |
@@ -402,7 +402,7 @@ DECLARE_EVENT_CLASS(xfs_buf_flags_class, | |||
402 | __entry->caller_ip = caller_ip; | 402 | __entry->caller_ip = caller_ip; |
403 | ), | 403 | ), |
404 | TP_printk("dev %d:%d bno 0x%llx len 0x%zx hold %d pincount %d " | 404 | TP_printk("dev %d:%d bno 0x%llx len 0x%zx hold %d pincount %d " |
405 | "lock %d flags %s caller %pf", | 405 | "lock %d flags %s caller %ps", |
406 | MAJOR(__entry->dev), MINOR(__entry->dev), | 406 | MAJOR(__entry->dev), MINOR(__entry->dev), |
407 | (unsigned long long)__entry->bno, | 407 | (unsigned long long)__entry->bno, |
408 | __entry->buffer_length, | 408 | __entry->buffer_length, |
@@ -447,7 +447,7 @@ TRACE_EVENT(xfs_buf_ioerror, | |||
447 | __entry->caller_ip = caller_ip; | 447 | __entry->caller_ip = caller_ip; |
448 | ), | 448 | ), |
449 | TP_printk("dev %d:%d bno 0x%llx len 0x%zx hold %d pincount %d " | 449 | TP_printk("dev %d:%d bno 0x%llx len 0x%zx hold %d pincount %d " |
450 | "lock %d error %d flags %s caller %pf", | 450 | "lock %d error %d flags %s caller %ps", |
451 | MAJOR(__entry->dev), MINOR(__entry->dev), | 451 | MAJOR(__entry->dev), MINOR(__entry->dev), |
452 | (unsigned long long)__entry->bno, | 452 | (unsigned long long)__entry->bno, |
453 | __entry->buffer_length, | 453 | __entry->buffer_length, |
@@ -613,7 +613,7 @@ DECLARE_EVENT_CLASS(xfs_lock_class, | |||
613 | __entry->lock_flags = lock_flags; | 613 | __entry->lock_flags = lock_flags; |
614 | __entry->caller_ip = caller_ip; | 614 | __entry->caller_ip = caller_ip; |
615 | ), | 615 | ), |
616 | TP_printk("dev %d:%d ino 0x%llx flags %s caller %pf", | 616 | TP_printk("dev %d:%d ino 0x%llx flags %s caller %ps", |
617 | MAJOR(__entry->dev), MINOR(__entry->dev), | 617 | MAJOR(__entry->dev), MINOR(__entry->dev), |
618 | __entry->ino, | 618 | __entry->ino, |
619 | __print_flags(__entry->lock_flags, "|", XFS_LOCK_FLAGS), | 619 | __print_flags(__entry->lock_flags, "|", XFS_LOCK_FLAGS), |
@@ -702,7 +702,7 @@ DECLARE_EVENT_CLASS(xfs_iref_class, | |||
702 | __entry->pincount = atomic_read(&ip->i_pincount); | 702 | __entry->pincount = atomic_read(&ip->i_pincount); |
703 | __entry->caller_ip = caller_ip; | 703 | __entry->caller_ip = caller_ip; |
704 | ), | 704 | ), |
705 | TP_printk("dev %d:%d ino 0x%llx count %d pincount %d caller %pf", | 705 | TP_printk("dev %d:%d ino 0x%llx count %d pincount %d caller %ps", |
706 | MAJOR(__entry->dev), MINOR(__entry->dev), | 706 | MAJOR(__entry->dev), MINOR(__entry->dev), |
707 | __entry->ino, | 707 | __entry->ino, |
708 | __entry->count, | 708 | __entry->count, |
@@ -1333,7 +1333,7 @@ TRACE_EVENT(xfs_bunmap, | |||
1333 | __entry->flags = flags; | 1333 | __entry->flags = flags; |
1334 | ), | 1334 | ), |
1335 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx bno 0x%llx len 0x%llx" | 1335 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx bno 0x%llx len 0x%llx" |
1336 | "flags %s caller %pf", | 1336 | "flags %s caller %ps", |
1337 | MAJOR(__entry->dev), MINOR(__entry->dev), | 1337 | MAJOR(__entry->dev), MINOR(__entry->dev), |
1338 | __entry->ino, | 1338 | __entry->ino, |
1339 | __entry->size, | 1339 | __entry->size, |
@@ -1466,7 +1466,7 @@ TRACE_EVENT(xfs_agf, | |||
1466 | ), | 1466 | ), |
1467 | TP_printk("dev %d:%d agno %u flags %s length %u roots b %u c %u " | 1467 | TP_printk("dev %d:%d agno %u flags %s length %u roots b %u c %u " |
1468 | "levels b %u c %u flfirst %u fllast %u flcount %u " | 1468 | "levels b %u c %u flfirst %u fllast %u flcount %u " |
1469 | "freeblks %u longest %u caller %pf", | 1469 | "freeblks %u longest %u caller %ps", |
1470 | MAJOR(__entry->dev), MINOR(__entry->dev), | 1470 | MAJOR(__entry->dev), MINOR(__entry->dev), |
1471 | __entry->agno, | 1471 | __entry->agno, |
1472 | __print_flags(__entry->flags, "|", XFS_AGF_FLAGS), | 1472 | __print_flags(__entry->flags, "|", XFS_AGF_FLAGS), |