diff options
author | David Rientjes <rientjes@google.com> | 2014-07-31 02:53:37 -0400 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2014-07-31 11:05:42 -0400 |
commit | 658ffd7e6f5ce62e15df99df5f9e181d76ffda8e (patch) | |
tree | 5b8b3cffcdbd653374923fd25d9911485894d6fd | |
parent | c460b5d34018d71fdeb8540620690883db3f959b (diff) |
x86, apic: Remove check_apicid_present callback
The check_apicid_present() apic callback is never called, so remove it
and functions that implement it.
Signed-off-by: David Rientjes <rientjes@google.com>
Link: http://lkml.kernel.org/r/alpine.DEB.2.02.1407302350160.17503@chino.kir.corp.google.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
-rw-r--r-- | arch/x86/include/asm/apic.h | 6 | ||||
-rw-r--r-- | arch/x86/kernel/apic/apic_flat_64.c | 2 | ||||
-rw-r--r-- | arch/x86/kernel/apic/apic_noop.c | 6 | ||||
-rw-r--r-- | arch/x86/kernel/apic/apic_numachip.c | 1 | ||||
-rw-r--r-- | arch/x86/kernel/apic/bigsmp_32.c | 6 | ||||
-rw-r--r-- | arch/x86/kernel/apic/probe_32.c | 1 | ||||
-rw-r--r-- | arch/x86/kernel/apic/x2apic_cluster.c | 1 | ||||
-rw-r--r-- | arch/x86/kernel/apic/x2apic_phys.c | 1 | ||||
-rw-r--r-- | arch/x86/kernel/apic/x2apic_uv_x.c | 1 |
9 files changed, 0 insertions, 25 deletions
diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h index 86d155026c3e..e1c0c2d4a961 100644 --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h | |||
@@ -292,7 +292,6 @@ struct apic { | |||
292 | 292 | ||
293 | int dest_logical; | 293 | int dest_logical; |
294 | unsigned long (*check_apicid_used)(physid_mask_t *map, int apicid); | 294 | unsigned long (*check_apicid_used)(physid_mask_t *map, int apicid); |
295 | unsigned long (*check_apicid_present)(int apicid); | ||
296 | 295 | ||
297 | void (*vector_allocation_domain)(int cpu, struct cpumask *retmask, | 296 | void (*vector_allocation_domain)(int cpu, struct cpumask *retmask, |
298 | const struct cpumask *mask); | 297 | const struct cpumask *mask); |
@@ -608,11 +607,6 @@ static inline unsigned long default_check_apicid_used(physid_mask_t *map, int ap | |||
608 | return physid_isset(apicid, *map); | 607 | return physid_isset(apicid, *map); |
609 | } | 608 | } |
610 | 609 | ||
611 | static inline unsigned long default_check_apicid_present(int bit) | ||
612 | { | ||
613 | return physid_isset(bit, phys_cpu_present_map); | ||
614 | } | ||
615 | |||
616 | static inline void default_ioapic_phys_id_map(physid_mask_t *phys_map, physid_mask_t *retmap) | 610 | static inline void default_ioapic_phys_id_map(physid_mask_t *phys_map, physid_mask_t *retmap) |
617 | { | 611 | { |
618 | *retmap = *phys_map; | 612 | *retmap = *phys_map; |
diff --git a/arch/x86/kernel/apic/apic_flat_64.c b/arch/x86/kernel/apic/apic_flat_64.c index 86c4203af12e..a8ed9ac1259b 100644 --- a/arch/x86/kernel/apic/apic_flat_64.c +++ b/arch/x86/kernel/apic/apic_flat_64.c | |||
@@ -168,7 +168,6 @@ static struct apic apic_flat = { | |||
168 | .disable_esr = 0, | 168 | .disable_esr = 0, |
169 | .dest_logical = APIC_DEST_LOGICAL, | 169 | .dest_logical = APIC_DEST_LOGICAL, |
170 | .check_apicid_used = NULL, | 170 | .check_apicid_used = NULL, |
171 | .check_apicid_present = NULL, | ||
172 | 171 | ||
173 | .vector_allocation_domain = flat_vector_allocation_domain, | 172 | .vector_allocation_domain = flat_vector_allocation_domain, |
174 | .init_apic_ldr = flat_init_apic_ldr, | 173 | .init_apic_ldr = flat_init_apic_ldr, |
@@ -279,7 +278,6 @@ static struct apic apic_physflat = { | |||
279 | .disable_esr = 0, | 278 | .disable_esr = 0, |
280 | .dest_logical = 0, | 279 | .dest_logical = 0, |
281 | .check_apicid_used = NULL, | 280 | .check_apicid_used = NULL, |
282 | .check_apicid_present = NULL, | ||
283 | 281 | ||
284 | .vector_allocation_domain = default_vector_allocation_domain, | 282 | .vector_allocation_domain = default_vector_allocation_domain, |
285 | /* not needed, but shouldn't hurt: */ | 283 | /* not needed, but shouldn't hurt: */ |
diff --git a/arch/x86/kernel/apic/apic_noop.c b/arch/x86/kernel/apic/apic_noop.c index 6b25735cc1cd..8c165d9c204c 100644 --- a/arch/x86/kernel/apic/apic_noop.c +++ b/arch/x86/kernel/apic/apic_noop.c | |||
@@ -94,11 +94,6 @@ static unsigned long noop_check_apicid_used(physid_mask_t *map, int apicid) | |||
94 | return physid_isset(apicid, *map); | 94 | return physid_isset(apicid, *map); |
95 | } | 95 | } |
96 | 96 | ||
97 | static unsigned long noop_check_apicid_present(int bit) | ||
98 | { | ||
99 | return physid_isset(bit, phys_cpu_present_map); | ||
100 | } | ||
101 | |||
102 | static void noop_vector_allocation_domain(int cpu, struct cpumask *retmask, | 97 | static void noop_vector_allocation_domain(int cpu, struct cpumask *retmask, |
103 | const struct cpumask *mask) | 98 | const struct cpumask *mask) |
104 | { | 99 | { |
@@ -134,7 +129,6 @@ struct apic apic_noop = { | |||
134 | .disable_esr = 0, | 129 | .disable_esr = 0, |
135 | .dest_logical = APIC_DEST_LOGICAL, | 130 | .dest_logical = APIC_DEST_LOGICAL, |
136 | .check_apicid_used = noop_check_apicid_used, | 131 | .check_apicid_used = noop_check_apicid_used, |
137 | .check_apicid_present = noop_check_apicid_present, | ||
138 | 132 | ||
139 | .vector_allocation_domain = noop_vector_allocation_domain, | 133 | .vector_allocation_domain = noop_vector_allocation_domain, |
140 | .init_apic_ldr = noop_init_apic_ldr, | 134 | .init_apic_ldr = noop_init_apic_ldr, |
diff --git a/arch/x86/kernel/apic/apic_numachip.c b/arch/x86/kernel/apic/apic_numachip.c index 5f835003634a..b49eb4047ef6 100644 --- a/arch/x86/kernel/apic/apic_numachip.c +++ b/arch/x86/kernel/apic/apic_numachip.c | |||
@@ -217,7 +217,6 @@ static const struct apic apic_numachip __refconst = { | |||
217 | .disable_esr = 0, | 217 | .disable_esr = 0, |
218 | .dest_logical = 0, | 218 | .dest_logical = 0, |
219 | .check_apicid_used = NULL, | 219 | .check_apicid_used = NULL, |
220 | .check_apicid_present = NULL, | ||
221 | 220 | ||
222 | .vector_allocation_domain = default_vector_allocation_domain, | 221 | .vector_allocation_domain = default_vector_allocation_domain, |
223 | .init_apic_ldr = flat_init_apic_ldr, | 222 | .init_apic_ldr = flat_init_apic_ldr, |
diff --git a/arch/x86/kernel/apic/bigsmp_32.c b/arch/x86/kernel/apic/bigsmp_32.c index 90f6427687ea..163ad45331d8 100644 --- a/arch/x86/kernel/apic/bigsmp_32.c +++ b/arch/x86/kernel/apic/bigsmp_32.c | |||
@@ -31,11 +31,6 @@ static unsigned long bigsmp_check_apicid_used(physid_mask_t *map, int apicid) | |||
31 | return 0; | 31 | return 0; |
32 | } | 32 | } |
33 | 33 | ||
34 | static unsigned long bigsmp_check_apicid_present(int bit) | ||
35 | { | ||
36 | return 1; | ||
37 | } | ||
38 | |||
39 | static int bigsmp_early_logical_apicid(int cpu) | 34 | static int bigsmp_early_logical_apicid(int cpu) |
40 | { | 35 | { |
41 | /* on bigsmp, logical apicid is the same as physical */ | 36 | /* on bigsmp, logical apicid is the same as physical */ |
@@ -168,7 +163,6 @@ static struct apic apic_bigsmp = { | |||
168 | .disable_esr = 1, | 163 | .disable_esr = 1, |
169 | .dest_logical = 0, | 164 | .dest_logical = 0, |
170 | .check_apicid_used = bigsmp_check_apicid_used, | 165 | .check_apicid_used = bigsmp_check_apicid_used, |
171 | .check_apicid_present = bigsmp_check_apicid_present, | ||
172 | 166 | ||
173 | .vector_allocation_domain = default_vector_allocation_domain, | 167 | .vector_allocation_domain = default_vector_allocation_domain, |
174 | .init_apic_ldr = bigsmp_init_apic_ldr, | 168 | .init_apic_ldr = bigsmp_init_apic_ldr, |
diff --git a/arch/x86/kernel/apic/probe_32.c b/arch/x86/kernel/apic/probe_32.c index b4211f69e6a2..4d92ef883499 100644 --- a/arch/x86/kernel/apic/probe_32.c +++ b/arch/x86/kernel/apic/probe_32.c | |||
@@ -88,7 +88,6 @@ static struct apic apic_default = { | |||
88 | .disable_esr = 0, | 88 | .disable_esr = 0, |
89 | .dest_logical = APIC_DEST_LOGICAL, | 89 | .dest_logical = APIC_DEST_LOGICAL, |
90 | .check_apicid_used = default_check_apicid_used, | 90 | .check_apicid_used = default_check_apicid_used, |
91 | .check_apicid_present = default_check_apicid_present, | ||
92 | 91 | ||
93 | .vector_allocation_domain = flat_vector_allocation_domain, | 92 | .vector_allocation_domain = flat_vector_allocation_domain, |
94 | .init_apic_ldr = default_init_apic_ldr, | 93 | .init_apic_ldr = default_init_apic_ldr, |
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c index 7e4ac5587af0..d7bbe89b18da 100644 --- a/arch/x86/kernel/apic/x2apic_cluster.c +++ b/arch/x86/kernel/apic/x2apic_cluster.c | |||
@@ -249,7 +249,6 @@ static struct apic apic_x2apic_cluster = { | |||
249 | .disable_esr = 0, | 249 | .disable_esr = 0, |
250 | .dest_logical = APIC_DEST_LOGICAL, | 250 | .dest_logical = APIC_DEST_LOGICAL, |
251 | .check_apicid_used = NULL, | 251 | .check_apicid_used = NULL, |
252 | .check_apicid_present = NULL, | ||
253 | 252 | ||
254 | .vector_allocation_domain = cluster_vector_allocation_domain, | 253 | .vector_allocation_domain = cluster_vector_allocation_domain, |
255 | .init_apic_ldr = init_x2apic_ldr, | 254 | .init_apic_ldr = init_x2apic_ldr, |
diff --git a/arch/x86/kernel/apic/x2apic_phys.c b/arch/x86/kernel/apic/x2apic_phys.c index 01136e64c380..e23bec9ecd71 100644 --- a/arch/x86/kernel/apic/x2apic_phys.c +++ b/arch/x86/kernel/apic/x2apic_phys.c | |||
@@ -103,7 +103,6 @@ static struct apic apic_x2apic_phys = { | |||
103 | .disable_esr = 0, | 103 | .disable_esr = 0, |
104 | .dest_logical = 0, | 104 | .dest_logical = 0, |
105 | .check_apicid_used = NULL, | 105 | .check_apicid_used = NULL, |
106 | .check_apicid_present = NULL, | ||
107 | 106 | ||
108 | .vector_allocation_domain = default_vector_allocation_domain, | 107 | .vector_allocation_domain = default_vector_allocation_domain, |
109 | .init_apic_ldr = init_x2apic_ldr, | 108 | .init_apic_ldr = init_x2apic_ldr, |
diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c index 119c55377640..633732f10d5a 100644 --- a/arch/x86/kernel/apic/x2apic_uv_x.c +++ b/arch/x86/kernel/apic/x2apic_uv_x.c | |||
@@ -365,7 +365,6 @@ static struct apic __refdata apic_x2apic_uv_x = { | |||
365 | .disable_esr = 0, | 365 | .disable_esr = 0, |
366 | .dest_logical = APIC_DEST_LOGICAL, | 366 | .dest_logical = APIC_DEST_LOGICAL, |
367 | .check_apicid_used = NULL, | 367 | .check_apicid_used = NULL, |
368 | .check_apicid_present = NULL, | ||
369 | 368 | ||
370 | .vector_allocation_domain = default_vector_allocation_domain, | 369 | .vector_allocation_domain = default_vector_allocation_domain, |
371 | .init_apic_ldr = uv_init_apic_ldr, | 370 | .init_apic_ldr = uv_init_apic_ldr, |