aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars-Peter Clausen <lars@metafoo.de>2013-06-14 07:16:54 -0400
committerMark Brown <broonie@linaro.org>2013-06-14 07:34:11 -0400
commit656ca9d327a3dbac6db28c5bf80f5bc86f7f8548 (patch)
treed17bea6ae6797b6f8dd48fca4ce7ea50ff6a0f3f
parent8872293fc38c4906c86e7d335b8f936abf9e4531 (diff)
ASoC: dapm: Remove unused long_name field from snd_soc_dapm_path struct
Since commit 85762e71 ("ASoC: dapm: Implement mixer control sharing") the long_name field of the snd_soc_dapm_path struct is unused. All of the name handling now happens entirely in dapm_create_or_share_mixmux_kcontrol(). So we can remove the long_name field from the snd_soc_dapm_path struct. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r--include/sound/soc-dapm.h1
-rw-r--r--sound/soc/soc-dapm.c5
2 files changed, 1 insertions, 5 deletions
diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h
index d4609029f014..360da978395d 100644
--- a/include/sound/soc-dapm.h
+++ b/include/sound/soc-dapm.h
@@ -478,7 +478,6 @@ struct snd_soc_dapm_route {
478/* dapm audio path between two widgets */ 478/* dapm audio path between two widgets */
479struct snd_soc_dapm_path { 479struct snd_soc_dapm_path {
480 const char *name; 480 const char *name;
481 const char *long_name;
482 481
483 /* source (input) and sink (output) widgets */ 482 /* source (input) and sink (output) widgets */
484 struct snd_soc_dapm_widget *source; 483 struct snd_soc_dapm_widget *source;
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 784534dcc82d..163f26d9571c 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -621,17 +621,15 @@ static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
621 kcontrol = snd_soc_cnew(&w->kcontrol_news[kci], wlist, name, 621 kcontrol = snd_soc_cnew(&w->kcontrol_news[kci], wlist, name,
622 prefix); 622 prefix);
623 kcontrol->private_free = dapm_kcontrol_free; 623 kcontrol->private_free = dapm_kcontrol_free;
624 kfree(long_name);
624 ret = snd_ctl_add(card, kcontrol); 625 ret = snd_ctl_add(card, kcontrol);
625 if (ret < 0) { 626 if (ret < 0) {
626 dev_err(dapm->dev, 627 dev_err(dapm->dev,
627 "ASoC: failed to add widget %s dapm kcontrol %s: %d\n", 628 "ASoC: failed to add widget %s dapm kcontrol %s: %d\n",
628 w->name, name, ret); 629 w->name, name, ret);
629 kfree(wlist); 630 kfree(wlist);
630 kfree(long_name);
631 return ret; 631 return ret;
632 } 632 }
633
634 path->long_name = long_name;
635 } 633 }
636 634
637 kcontrol->private_data = wlist; 635 kcontrol->private_data = wlist;
@@ -2110,7 +2108,6 @@ static void dapm_free_path(struct snd_soc_dapm_path *path)
2110 list_del(&path->list_sink); 2108 list_del(&path->list_sink);
2111 list_del(&path->list_source); 2109 list_del(&path->list_source);
2112 list_del(&path->list); 2110 list_del(&path->list);
2113 kfree(path->long_name);
2114 kfree(path); 2111 kfree(path);
2115} 2112}
2116 2113