diff options
author | Ian Campbell <ian.campbell@citrix.com> | 2011-03-10 11:08:04 -0500 |
---|---|---|
committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-03-10 14:48:33 -0500 |
commit | 653378acdd477a299f468e396c7719911ac57881 (patch) | |
tree | 1a0840e9fb0eaef25fd4b16fedef49445cf9186e | |
parent | be49472f0460455e8e0d9e6593837e09cbcc9ad7 (diff) |
xen: events: simplify comment
It is never valid assume any particular relationship between a Xen
PIRQ number and and Linux IRQ number so there is no need to hedge when
saying so.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
-rw-r--r-- | drivers/xen/events.c | 10 | ||||
-rw-r--r-- | include/xen/events.h | 4 |
2 files changed, 4 insertions, 10 deletions
diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 684b0950538a..0b27080b1918 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c | |||
@@ -583,13 +583,9 @@ int xen_allocate_pirq(unsigned gsi, int shareable, char *name) | |||
583 | return xen_map_pirq_gsi(gsi, gsi, shareable, name); | 583 | return xen_map_pirq_gsi(gsi, gsi, shareable, name); |
584 | } | 584 | } |
585 | 585 | ||
586 | /* xen_map_pirq_gsi might allocate irqs from the top down, as a | 586 | /* |
587 | * consequence don't assume that the irq number returned has a low value | 587 | * Do not make any assumptions regarding the relationship between the |
588 | * or can be used as a pirq number unless you know otherwise. | 588 | * IRQ number returned here and the Xen pirq argument. |
589 | * | ||
590 | * One notable exception is when xen_map_pirq_gsi is called passing an | ||
591 | * hardware gsi as argument, in that case the irq number returned | ||
592 | * matches the gsi number passed as second argument. | ||
593 | * | 589 | * |
594 | * Note: We don't assign an event channel until the irq actually started | 590 | * Note: We don't assign an event channel until the irq actually started |
595 | * up. Return an existing irq if we've already got one for the gsi. | 591 | * up. Return an existing irq if we've already got one for the gsi. |
diff --git a/include/xen/events.h b/include/xen/events.h index 962da2ced5b4..f6fed9498aa3 100644 --- a/include/xen/events.h +++ b/include/xen/events.h | |||
@@ -68,9 +68,7 @@ int xen_set_callback_via(uint64_t via); | |||
68 | void xen_evtchn_do_upcall(struct pt_regs *regs); | 68 | void xen_evtchn_do_upcall(struct pt_regs *regs); |
69 | void xen_hvm_evtchn_do_upcall(void); | 69 | void xen_hvm_evtchn_do_upcall(void); |
70 | 70 | ||
71 | /* Allocate an irq for a physical interrupt, given a gsi. "Legacy" | 71 | /* Allocate an irq for a physical interrupt, given a gsi. */ |
72 | * GSIs are identity mapped; others are dynamically allocated as | ||
73 | * usual. */ | ||
74 | int xen_allocate_pirq(unsigned gsi, int shareable, char *name); | 72 | int xen_allocate_pirq(unsigned gsi, int shareable, char *name); |
75 | int xen_map_pirq_gsi(unsigned pirq, unsigned gsi, int shareable, char *name); | 73 | int xen_map_pirq_gsi(unsigned pirq, unsigned gsi, int shareable, char *name); |
76 | 74 | ||