aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCyrill Gorcunov <gorcunov@gmail.com>2008-08-15 07:51:22 -0400
committerIngo Molnar <mingo@elte.hu>2008-08-15 07:51:22 -0400
commit64e474d168e3cf31e44890b4947644d361f84e43 (patch)
tree7f2ee45ce21851240015b28bf18bc7cfdbf56114
parent9ce122c6e55c44ae9a4c4c777579b87d83e7f898 (diff)
x86: apic - get rid of local_apic_timer_verify_ok
We are able to use clock_event_device as it's done in 64bit apic code so lets get rid of local_apic_timer_verify_ok variable. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--arch/x86/kernel/apic_32.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c
index a151d66f948c..7783c113be24 100644
--- a/arch/x86/kernel/apic_32.c
+++ b/arch/x86/kernel/apic_32.c
@@ -60,8 +60,6 @@ unsigned long mp_lapic_addr;
60static int force_enable_local_apic; 60static int force_enable_local_apic;
61int disable_apic; 61int disable_apic;
62 62
63/* Local APIC timer verification ok */
64static int local_apic_timer_verify_ok;
65/* Disable local APIC timer from the kernel commandline or via dmi quirk */ 63/* Disable local APIC timer from the kernel commandline or via dmi quirk */
66static int disable_apic_timer __cpuinitdata; 64static int disable_apic_timer __cpuinitdata;
67/* Local APIC timer works in C2 */ 65/* Local APIC timer works in C2 */
@@ -301,7 +299,7 @@ static void lapic_timer_setup(enum clock_event_mode mode,
301 unsigned int v; 299 unsigned int v;
302 300
303 /* Lapic used for broadcast ? */ 301 /* Lapic used for broadcast ? */
304 if (!local_apic_timer_verify_ok) 302 if (evt->features & CLOCK_EVT_FEAT_DUMMY)
305 return; 303 return;
306 304
307 local_irq_save(flags); 305 local_irq_save(flags);
@@ -514,7 +512,7 @@ static int __init calibrate_APIC_clock(void)
514 return -1; 512 return -1;
515 } 513 }
516 514
517 local_apic_timer_verify_ok = 1; 515 levt->features &= ~CLOCK_EVT_FEAT_DUMMY;
518 516
519 /* We trust the pm timer based calibration */ 517 /* We trust the pm timer based calibration */
520 if (!pm_referenced) { 518 if (!pm_referenced) {
@@ -548,11 +546,11 @@ static int __init calibrate_APIC_clock(void)
548 if (deltaj >= LAPIC_CAL_LOOPS-2 && deltaj <= LAPIC_CAL_LOOPS+2) 546 if (deltaj >= LAPIC_CAL_LOOPS-2 && deltaj <= LAPIC_CAL_LOOPS+2)
549 apic_printk(APIC_VERBOSE, "... jiffies result ok\n"); 547 apic_printk(APIC_VERBOSE, "... jiffies result ok\n");
550 else 548 else
551 local_apic_timer_verify_ok = 0; 549 levt->features |= CLOCK_EVT_FEAT_DUMMY;
552 } else 550 } else
553 local_irq_enable(); 551 local_irq_enable();
554 552
555 if (!local_apic_timer_verify_ok) { 553 if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
556 printk(KERN_WARNING 554 printk(KERN_WARNING
557 "APIC timer disabled due to verification failure.\n"); 555 "APIC timer disabled due to verification failure.\n");
558 return -1; 556 return -1;