diff options
author | Denis V. Lunev <den@openvz.org> | 2008-01-23 01:03:33 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:11:02 -0500 |
commit | 64c2d5382954ccf6054424653f4c7f4f04c1ff21 (patch) | |
tree | 8334b52941b63e53178b355a2177880f8ebc78d4 | |
parent | e30d3a0ccddbd458b3fb14c9b0229b01d97bad5b (diff) |
[IPV4]: Consolidate fib_select_default.
The difference in the implementation of the fib_select_default when
CONFIG_IP_MULTIPLE_TABLES is (not) defined looks
negligible. Consolidate it and place into fib_frontend.c.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | include/net/ip_fib.h | 10 | ||||
-rw-r--r-- | net/ipv4/fib_frontend.c | 14 | ||||
-rw-r--r-- | net/ipv4/fib_rules.c | 10 |
3 files changed, 15 insertions, 19 deletions
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h index be70b33b744c..39f944a096d9 100644 --- a/include/net/ip_fib.h +++ b/include/net/ip_fib.h | |||
@@ -193,14 +193,6 @@ static inline int fib_lookup(struct net *net, const struct flowi *flp, | |||
193 | return -ENETUNREACH; | 193 | return -ENETUNREACH; |
194 | } | 194 | } |
195 | 195 | ||
196 | static inline void fib_select_default(const struct flowi *flp, | ||
197 | struct fib_result *res) | ||
198 | { | ||
199 | struct fib_table *table = fib_get_table(&init_net, RT_TABLE_MAIN); | ||
200 | if (FIB_RES_GW(*res) && FIB_RES_NH(*res).nh_scope == RT_SCOPE_LINK) | ||
201 | table->tb_select_default(table, flp, res); | ||
202 | } | ||
203 | |||
204 | #else /* CONFIG_IP_MULTIPLE_TABLES */ | 196 | #else /* CONFIG_IP_MULTIPLE_TABLES */ |
205 | extern int __net_init fib4_rules_init(struct net *net); | 197 | extern int __net_init fib4_rules_init(struct net *net); |
206 | extern void __net_exit fib4_rules_exit(struct net *net); | 198 | extern void __net_exit fib4_rules_exit(struct net *net); |
@@ -213,7 +205,6 @@ extern int fib_lookup(struct net *n, struct flowi *flp, struct fib_result *res); | |||
213 | 205 | ||
214 | extern struct fib_table *fib_new_table(struct net *net, u32 id); | 206 | extern struct fib_table *fib_new_table(struct net *net, u32 id); |
215 | extern struct fib_table *fib_get_table(struct net *net, u32 id); | 207 | extern struct fib_table *fib_get_table(struct net *net, u32 id); |
216 | extern void fib_select_default(const struct flowi *flp, struct fib_result *res); | ||
217 | 208 | ||
218 | #endif /* CONFIG_IP_MULTIPLE_TABLES */ | 209 | #endif /* CONFIG_IP_MULTIPLE_TABLES */ |
219 | 210 | ||
@@ -222,6 +213,7 @@ extern const struct nla_policy rtm_ipv4_policy[]; | |||
222 | extern void ip_fib_init(void); | 213 | extern void ip_fib_init(void); |
223 | extern int fib_validate_source(__be32 src, __be32 dst, u8 tos, int oif, | 214 | extern int fib_validate_source(__be32 src, __be32 dst, u8 tos, int oif, |
224 | struct net_device *dev, __be32 *spec_dst, u32 *itag); | 215 | struct net_device *dev, __be32 *spec_dst, u32 *itag); |
216 | extern void fib_select_default(const struct flowi *flp, struct fib_result *res); | ||
225 | 217 | ||
226 | /* Exported by fib_semantics.c */ | 218 | /* Exported by fib_semantics.c */ |
227 | extern int ip_fib_check_default(__be32 gw, struct net_device *dev); | 219 | extern int ip_fib_check_default(__be32 gw, struct net_device *dev); |
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 6761639dd0e9..13bf01de0ed8 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c | |||
@@ -116,6 +116,20 @@ struct fib_table *fib_get_table(struct net *net, u32 id) | |||
116 | } | 116 | } |
117 | #endif /* CONFIG_IP_MULTIPLE_TABLES */ | 117 | #endif /* CONFIG_IP_MULTIPLE_TABLES */ |
118 | 118 | ||
119 | void fib_select_default(const struct flowi *flp, struct fib_result *res) | ||
120 | { | ||
121 | struct fib_table *tb; | ||
122 | int table = RT_TABLE_MAIN; | ||
123 | #ifdef CONFIG_IP_MULTIPLE_TABLES | ||
124 | if (res->r == NULL || res->r->action != FR_ACT_TO_TBL) | ||
125 | return; | ||
126 | table = res->r->table; | ||
127 | #endif | ||
128 | tb = fib_get_table(&init_net, table); | ||
129 | if (FIB_RES_GW(*res) && FIB_RES_NH(*res).nh_scope == RT_SCOPE_LINK) | ||
130 | tb->tb_select_default(tb, flp, res); | ||
131 | } | ||
132 | |||
119 | static void fib_flush(struct net *net) | 133 | static void fib_flush(struct net *net) |
120 | { | 134 | { |
121 | int flushed = 0; | 135 | int flushed = 0; |
diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c index 1effb4ab688c..19274d01afa4 100644 --- a/net/ipv4/fib_rules.c +++ b/net/ipv4/fib_rules.c | |||
@@ -102,16 +102,6 @@ errout: | |||
102 | } | 102 | } |
103 | 103 | ||
104 | 104 | ||
105 | void fib_select_default(const struct flowi *flp, struct fib_result *res) | ||
106 | { | ||
107 | if (res->r && res->r->action == FR_ACT_TO_TBL && | ||
108 | FIB_RES_GW(*res) && FIB_RES_NH(*res).nh_scope == RT_SCOPE_LINK) { | ||
109 | struct fib_table *tb; | ||
110 | if ((tb = fib_get_table(&init_net, res->r->table)) != NULL) | ||
111 | tb->tb_select_default(tb, flp, res); | ||
112 | } | ||
113 | } | ||
114 | |||
115 | static int fib4_rule_match(struct fib_rule *rule, struct flowi *fl, int flags) | 105 | static int fib4_rule_match(struct fib_rule *rule, struct flowi *fl, int flags) |
116 | { | 106 | { |
117 | struct fib4_rule *r = (struct fib4_rule *) rule; | 107 | struct fib4_rule *r = (struct fib4_rule *) rule; |