diff options
author | Sebastian Siewior <bigeasy@linutronix.de> | 2013-08-12 10:17:53 -0400 |
---|---|---|
committer | Anatolij Gustschin <agust@denx.de> | 2013-08-12 18:16:04 -0400 |
commit | 6391f697d4892a6f233501beea553e13f7745a23 (patch) | |
tree | f91f87ed2afe478fcb29e5bc29140e22458a779c | |
parent | d4e4ab86bcba5a72779c43dc1459f71fea3d89c8 (diff) |
powerpc: 52xx: provide a default in mpc52xx_irqhost_map()
My gcc-4.3.5 fails to compile due to:
|cc1: warnings being treated as errors
|arch/powerpc/platforms/52xx/mpc52xx_pic.c: In function ‘mpc52xx_irqhost_map’:
|arch/powerpc/platforms/52xx/mpc52xx_pic.c:343: error: ‘irqchip’ may be used uninitialized in this function
since commit e34298c ("powerpc: 52xx: nop out unsupported critical
IRQs"). This warning is complete crap since only values 0…3 are possible
which are checked but gcc fails to understand that. I wouldn't care much
but since this is compiled with -Werror I made this patch.
While add it, I replaced the warning from l2irq to l1irq since this is
the number that is evaluated.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Anatolij Gustschin <agust@denx.de>
-rw-r--r-- | arch/powerpc/platforms/52xx/mpc52xx_pic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pic.c b/arch/powerpc/platforms/52xx/mpc52xx_pic.c index b89ef65392dc..b69221ba07fd 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_pic.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_pic.c | |||
@@ -373,8 +373,9 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq, | |||
373 | case MPC52xx_IRQ_L1_PERP: irqchip = &mpc52xx_periph_irqchip; break; | 373 | case MPC52xx_IRQ_L1_PERP: irqchip = &mpc52xx_periph_irqchip; break; |
374 | case MPC52xx_IRQ_L1_SDMA: irqchip = &mpc52xx_sdma_irqchip; break; | 374 | case MPC52xx_IRQ_L1_SDMA: irqchip = &mpc52xx_sdma_irqchip; break; |
375 | case MPC52xx_IRQ_L1_CRIT: | 375 | case MPC52xx_IRQ_L1_CRIT: |
376 | default: | ||
376 | pr_warn("%s: Critical IRQ #%d is unsupported! Nopping it.\n", | 377 | pr_warn("%s: Critical IRQ #%d is unsupported! Nopping it.\n", |
377 | __func__, l2irq); | 378 | __func__, l1irq); |
378 | irq_set_chip(virq, &no_irq_chip); | 379 | irq_set_chip(virq, &no_irq_chip); |
379 | return 0; | 380 | return 0; |
380 | } | 381 | } |