diff options
| author | Andi Shyti <andi@etezian.org> | 2014-01-29 22:05:01 -0500 |
|---|---|---|
| committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-02-04 03:35:26 -0500 |
| commit | 62fd0d30e1fbd12d5a07ff722b2726bb8fa630c7 (patch) | |
| tree | 907d3962ed4cf3d0d0a9c5e1661a56ce6ee9a421 | |
| parent | 08e10972661db78d0e0a2d4a4c28fc3bf93617ba (diff) | |
[media] cx24117: remove dead code in always 'false' if statement
At this point of the execution in the function cx24117_attach()
demod cannot be '0'. In that case the function returns earlier
with an error value ('NULL'). Remove the if statement.
This error has been reported by scan.coverity.com
Signed-off-by: Andi Shyti <andi@etezian.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
| -rw-r--r-- | drivers/media/dvb-frontends/cx24117.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/media/dvb-frontends/cx24117.c b/drivers/media/dvb-frontends/cx24117.c index 68f768a5422d..782dcfe6ae69 100644 --- a/drivers/media/dvb-frontends/cx24117.c +++ b/drivers/media/dvb-frontends/cx24117.c | |||
| @@ -1200,12 +1200,6 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config, | |||
| 1200 | state->demod = demod - 1; | 1200 | state->demod = demod - 1; |
| 1201 | state->priv = priv; | 1201 | state->priv = priv; |
| 1202 | 1202 | ||
| 1203 | /* test i2c bus for ack */ | ||
| 1204 | if (demod == 0) { | ||
| 1205 | if (cx24117_readreg(state, 0x00) < 0) | ||
| 1206 | goto error3; | ||
| 1207 | } | ||
| 1208 | |||
| 1209 | dev_info(&state->priv->i2c->dev, | 1203 | dev_info(&state->priv->i2c->dev, |
| 1210 | "%s: Attaching frontend %d\n", | 1204 | "%s: Attaching frontend %d\n", |
| 1211 | KBUILD_MODNAME, state->demod); | 1205 | KBUILD_MODNAME, state->demod); |
| @@ -1216,8 +1210,6 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config, | |||
| 1216 | state->frontend.demodulator_priv = state; | 1210 | state->frontend.demodulator_priv = state; |
| 1217 | return &state->frontend; | 1211 | return &state->frontend; |
| 1218 | 1212 | ||
| 1219 | error3: | ||
| 1220 | kfree(state); | ||
| 1221 | error2: | 1213 | error2: |
| 1222 | cx24117_release_priv(priv); | 1214 | cx24117_release_priv(priv); |
| 1223 | error1: | 1215 | error1: |
