aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikunj A. Dadhania <nikunj@linux.vnet.ibm.com>2012-02-16 22:04:30 -0500
committerIngo Molnar <mingo@elte.hu>2012-02-22 06:28:28 -0500
commit62f6536a630affe3176deb48554d27ee58b65077 (patch)
treecf1365f5c0d0b9aebb5877afa8a7b5da4aa11917
parent9388dc3047a88bedfd867e9ba3e1980c815ac524 (diff)
sched: Remove rcu_read_lock/unlock() from select_idle_sibling()
select_idle_sibling() is called from select_task_rq_fair(), which already has the RCU read lock held. Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20120217030409.11748.12491.stgit@abhimanyu Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--kernel/sched/fair.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4ab60a24ea49..6ce9992926d0 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2670,8 +2670,6 @@ static int select_idle_sibling(struct task_struct *p, int target)
2670 /* 2670 /*
2671 * Otherwise, iterate the domains and find an elegible idle cpu. 2671 * Otherwise, iterate the domains and find an elegible idle cpu.
2672 */ 2672 */
2673 rcu_read_lock();
2674
2675 sd = rcu_dereference(per_cpu(sd_llc, target)); 2673 sd = rcu_dereference(per_cpu(sd_llc, target));
2676 for_each_lower_domain(sd) { 2674 for_each_lower_domain(sd) {
2677 sg = sd->groups; 2675 sg = sd->groups;
@@ -2693,8 +2691,6 @@ next:
2693 } while (sg != sd->groups); 2691 } while (sg != sd->groups);
2694 } 2692 }
2695done: 2693done:
2696 rcu_read_unlock();
2697
2698 return target; 2694 return target;
2699} 2695}
2700 2696