diff options
| author | Ying Xue <ying.xue@windriver.com> | 2012-08-16 08:09:12 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-08-20 05:26:31 -0400 |
| commit | 61cdd4d80b29cfdee45920238eea2d1fbb51f922 (patch) | |
| tree | 44df7d9694b581afae71955030ffbad25a4aee15 | |
| parent | f046e7d9be1cbb3335694c7f9a31d18e1f998ff5 (diff) | |
tipc: add __read_mostly annotations to several global variables
Added to the following:
- tipc_random
- tipc_own_addr
- tipc_max_ports
- tipc_net_id
- tipc_remote_management
- handler_enabled
The above global variables are read often, but written rarely. Use
__read_mostly to prevent them being on the same cacheline as another
variable which is written to often, which would cause cacheline
bouncing.
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/tipc/core.c | 10 | ||||
| -rw-r--r-- | net/tipc/core.h | 10 | ||||
| -rw-r--r-- | net/tipc/handler.c | 2 |
3 files changed, 11 insertions, 11 deletions
diff --git a/net/tipc/core.c b/net/tipc/core.c index daae7f74d418..b858f2003523 100644 --- a/net/tipc/core.c +++ b/net/tipc/core.c | |||
| @@ -48,15 +48,15 @@ | |||
| 48 | 48 | ||
| 49 | 49 | ||
| 50 | /* global variables used by multiple sub-systems within TIPC */ | 50 | /* global variables used by multiple sub-systems within TIPC */ |
| 51 | int tipc_random; | 51 | int tipc_random __read_mostly; |
| 52 | 52 | ||
| 53 | /* configurable TIPC parameters */ | 53 | /* configurable TIPC parameters */ |
| 54 | u32 tipc_own_addr; | 54 | u32 tipc_own_addr __read_mostly; |
| 55 | int tipc_max_ports; | 55 | int tipc_max_ports __read_mostly; |
| 56 | int tipc_max_subscriptions; | 56 | int tipc_max_subscriptions; |
| 57 | int tipc_max_publications; | 57 | int tipc_max_publications; |
| 58 | int tipc_net_id; | 58 | int tipc_net_id __read_mostly; |
| 59 | int tipc_remote_management; | 59 | int tipc_remote_management __read_mostly; |
| 60 | 60 | ||
| 61 | 61 | ||
| 62 | /** | 62 | /** |
diff --git a/net/tipc/core.h b/net/tipc/core.h index e4e46cd2d0e6..4c5705ac8a5a 100644 --- a/net/tipc/core.h +++ b/net/tipc/core.h | |||
| @@ -74,17 +74,17 @@ int tipc_snprintf(char *buf, int len, const char *fmt, ...); | |||
| 74 | /* | 74 | /* |
| 75 | * Global configuration variables | 75 | * Global configuration variables |
| 76 | */ | 76 | */ |
| 77 | extern u32 tipc_own_addr; | 77 | extern u32 tipc_own_addr __read_mostly; |
| 78 | extern int tipc_max_ports; | 78 | extern int tipc_max_ports __read_mostly; |
| 79 | extern int tipc_max_subscriptions; | 79 | extern int tipc_max_subscriptions; |
| 80 | extern int tipc_max_publications; | 80 | extern int tipc_max_publications; |
| 81 | extern int tipc_net_id; | 81 | extern int tipc_net_id __read_mostly; |
| 82 | extern int tipc_remote_management; | 82 | extern int tipc_remote_management __read_mostly; |
| 83 | 83 | ||
| 84 | /* | 84 | /* |
| 85 | * Other global variables | 85 | * Other global variables |
| 86 | */ | 86 | */ |
| 87 | extern int tipc_random; | 87 | extern int tipc_random __read_mostly; |
| 88 | 88 | ||
| 89 | /* | 89 | /* |
| 90 | * Routines available to privileged subsystems | 90 | * Routines available to privileged subsystems |
diff --git a/net/tipc/handler.c b/net/tipc/handler.c index 7a52d3922f3c..111ff8300ae5 100644 --- a/net/tipc/handler.c +++ b/net/tipc/handler.c | |||
| @@ -45,7 +45,7 @@ struct queue_item { | |||
| 45 | static struct kmem_cache *tipc_queue_item_cache; | 45 | static struct kmem_cache *tipc_queue_item_cache; |
| 46 | static struct list_head signal_queue_head; | 46 | static struct list_head signal_queue_head; |
| 47 | static DEFINE_SPINLOCK(qitem_lock); | 47 | static DEFINE_SPINLOCK(qitem_lock); |
| 48 | static int handler_enabled; | 48 | static int handler_enabled __read_mostly; |
| 49 | 49 | ||
| 50 | static void process_signal_queue(unsigned long dummy); | 50 | static void process_signal_queue(unsigned long dummy); |
| 51 | 51 | ||
