diff options
| author | Eric Dumazet <dada1@cosmosbay.com> | 2007-12-17 19:19:51 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-12-17 22:28:15 -0500 |
| commit | 60af880339aae440293a0c8e93178fdcb41f8a29 (patch) | |
| tree | 5f61602d96d3e9b1bcd1146a8192598b7824360a | |
| parent | 8d431dbef4e63d54f1965c3ed6ca5f91ee4512de (diff) | |
parport: "dev->timeslice" is an unsigned long, not an int
While auditing proc_doulongvec_ms_jiffies_minmax() usage in kernel, I found
a bug in drivers/parport/procfs.c, incorrectly using sizeof(int) instead of
sizeof(unsigned long)
Only 64bit arches are affected by this old bug.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/parport/procfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c index ed82e41210d1..d950fc34320a 100644 --- a/drivers/parport/procfs.c +++ b/drivers/parport/procfs.c | |||
| @@ -384,7 +384,7 @@ parport_device_sysctl_template = { | |||
| 384 | { | 384 | { |
| 385 | .procname = "timeslice", | 385 | .procname = "timeslice", |
| 386 | .data = NULL, | 386 | .data = NULL, |
| 387 | .maxlen = sizeof(int), | 387 | .maxlen = sizeof(unsigned long), |
| 388 | .mode = 0644, | 388 | .mode = 0644, |
| 389 | .proc_handler = &proc_doulongvec_ms_jiffies_minmax, | 389 | .proc_handler = &proc_doulongvec_ms_jiffies_minmax, |
| 390 | .extra1 = (void*) &parport_min_timeslice_value, | 390 | .extra1 = (void*) &parport_min_timeslice_value, |