aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Patterson <andrew.patterson@hp.com>2008-09-04 16:27:45 -0400
committerJens Axboe <jens.axboe@oracle.com>2008-10-09 02:56:13 -0400
commit608aeef17a91747d6303de4df5e2c2e6899a95e8 (patch)
treedeafb5e779f8ed43ecfd5396681cc9b18b3223c7
parent56ade44b46780fa291fa68b824f1dafdcb11b0ca (diff)
Call flush_disk() after detecting an online resize.
We call flush_disk() to make sure the buffer cache for the disk is flushed after a disk resize. There are two resize cases, growing and shrinking. Given that users can shrink/then grow a disk before revalidate_disk() is called, we treat the grow case identically to shrinking. We need to flush the buffer cache after an online shrink because, as James Bottomley puts it, The two use cases for shrinking I can see are 1. planned: the fs is already shrunk to within the new boundaries and all data is relocated, so invalidate is fine (any dirty buffers that might exist in the shrunk region are there only because they were relocated but not yet written to their original location). 2. unplanned: In this case, the fs is probably toast, so whether we invalidate or not isn't going to make a whole lot of difference; it's still going to try to read or write from sectors beyond the new size and get I/O errors. Immediately invalidating shrunk disks will cause errors for outstanding I/Os for reads/write beyond the new end of the disk to be generated earlier then if we waited for the normal buffer cache operation. It also removes a potential security hole where we might keep old data around from beyond the end of the shrunk disk if the disk was not invalidated. Signed-off-by: Andrew Patterson <andrew.patterson@hp.com> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
-rw-r--r--fs/block_dev.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 33650fc537c4..57e2786dd2a5 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -902,6 +902,7 @@ void check_disk_size_change(struct gendisk *disk, struct block_device *bdev)
902 "%s: detected capacity change from %lld to %lld\n", 902 "%s: detected capacity change from %lld to %lld\n",
903 name, bdev_size, disk_size); 903 name, bdev_size, disk_size);
904 i_size_write(bdev->bd_inode, disk_size); 904 i_size_write(bdev->bd_inode, disk_size);
905 flush_disk(bdev);
905 } 906 }
906} 907}
907EXPORT_SYMBOL(check_disk_size_change); 908EXPORT_SYMBOL(check_disk_size_change);