aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Hurley <peter@hurleysoftware.com>2015-03-09 16:27:19 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-26 12:25:27 -0400
commit60846880384f00713c7f54243f749c1923e6c0e3 (patch)
treeddc81cce43db0e3b4836d1b52d5d825d116a22aa
parent526ebc3f56491fe971cd2b51cfc859a879e11e93 (diff)
serial: earlycon: Skip parse_options() if empty string
Earlycon param strings of the form earlycon=<name> are rejected from parse_options() with an error (which, in turn, results in a NULL argument for the setup() method options parameter). Only pass non-empty string to parse_options(); this will enable handling actual parse errors differently than expected and allow formats. Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/serial/earlycon.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
index da5e8c8c4ad4..025ea0140896 100644
--- a/drivers/tty/serial/earlycon.c
+++ b/drivers/tty/serial/earlycon.c
@@ -109,13 +109,16 @@ int __init setup_earlycon(char *buf, const char *match,
109 len = strlen(match); 109 len = strlen(match);
110 if (strncmp(buf, match, len)) 110 if (strncmp(buf, match, len))
111 return 0; 111 return 0;
112 if (buf[len] && (buf[len] != ','))
113 return 0;
114 112
115 buf += len + 1; 113 if (buf[len]) {
114 if (buf[len] != ',')
115 return 0;
116 buf += len + 1;
117 } else
118 buf = NULL;
116 119
117 /* On parsing error, pass the options buf to the setup function */ 120 /* On parsing error, pass the options buf to the setup function */
118 if (!parse_options(&early_console_dev, buf)) 121 if (buf && !parse_options(&early_console_dev, buf))
119 buf = NULL; 122 buf = NULL;
120 123
121 port->uartclk = BASE_BAUD * 16; 124 port->uartclk = BASE_BAUD * 16;