aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorViresh Kumar <viresh.kumar@linaro.org>2013-09-16 09:26:38 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2013-09-30 14:18:44 -0400
commit5f3a2d39bb9dd4372c52fb2568c4520bcc91c8c4 (patch)
treeeb44330f30376f82ad30a7ccdd2b4db80d1865c5
parent4a1fe2bfc9e49c48a166d0229e09d3069893a8fa (diff)
cpufreq: speedstep: use cpufreq_table_validate_and_show()
Lets use cpufreq_table_validate_and_show() instead of calling cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr(). Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r--drivers/cpufreq/speedstep-centrino.c10
-rw-r--r--drivers/cpufreq/speedstep-ich.c9
-rw-r--r--drivers/cpufreq/speedstep-smi.c8
3 files changed, 3 insertions, 24 deletions
diff --git a/drivers/cpufreq/speedstep-centrino.c b/drivers/cpufreq/speedstep-centrino.c
index f897d5105842..f180561c3635 100644
--- a/drivers/cpufreq/speedstep-centrino.c
+++ b/drivers/cpufreq/speedstep-centrino.c
@@ -345,7 +345,6 @@ static int centrino_cpu_init(struct cpufreq_policy *policy)
345 struct cpuinfo_x86 *cpu = &cpu_data(policy->cpu); 345 struct cpuinfo_x86 *cpu = &cpu_data(policy->cpu);
346 unsigned freq; 346 unsigned freq;
347 unsigned l, h; 347 unsigned l, h;
348 int ret;
349 int i; 348 int i;
350 349
351 /* Only Intel makes Enhanced Speedstep-capable CPUs */ 350 /* Only Intel makes Enhanced Speedstep-capable CPUs */
@@ -402,15 +401,8 @@ static int centrino_cpu_init(struct cpufreq_policy *policy)
402 401
403 pr_debug("centrino_cpu_init: cur=%dkHz\n", policy->cur); 402 pr_debug("centrino_cpu_init: cur=%dkHz\n", policy->cur);
404 403
405 ret = cpufreq_frequency_table_cpuinfo(policy, 404 return cpufreq_table_validate_and_show(policy,
406 per_cpu(centrino_model, policy->cpu)->op_points); 405 per_cpu(centrino_model, policy->cpu)->op_points);
407 if (ret)
408 return (ret);
409
410 cpufreq_frequency_table_get_attr(
411 per_cpu(centrino_model, policy->cpu)->op_points, policy->cpu);
412
413 return 0;
414} 406}
415 407
416static int centrino_cpu_exit(struct cpufreq_policy *policy) 408static int centrino_cpu_exit(struct cpufreq_policy *policy)
diff --git a/drivers/cpufreq/speedstep-ich.c b/drivers/cpufreq/speedstep-ich.c
index 5355abb69afc..86a184eaa815 100644
--- a/drivers/cpufreq/speedstep-ich.c
+++ b/drivers/cpufreq/speedstep-ich.c
@@ -320,7 +320,6 @@ static void get_freqs_on_cpu(void *_get_freqs)
320 320
321static int speedstep_cpu_init(struct cpufreq_policy *policy) 321static int speedstep_cpu_init(struct cpufreq_policy *policy)
322{ 322{
323 int result;
324 unsigned int policy_cpu, speed; 323 unsigned int policy_cpu, speed;
325 struct get_freqs gf; 324 struct get_freqs gf;
326 325
@@ -349,13 +348,7 @@ static int speedstep_cpu_init(struct cpufreq_policy *policy)
349 /* cpuinfo and default policy values */ 348 /* cpuinfo and default policy values */
350 policy->cur = speed; 349 policy->cur = speed;
351 350
352 result = cpufreq_frequency_table_cpuinfo(policy, speedstep_freqs); 351 return cpufreq_table_validate_and_show(policy, speedstep_freqs);
353 if (result)
354 return result;
355
356 cpufreq_frequency_table_get_attr(speedstep_freqs, policy->cpu);
357
358 return 0;
359} 352}
360 353
361 354
diff --git a/drivers/cpufreq/speedstep-smi.c b/drivers/cpufreq/speedstep-smi.c
index abfba4f731eb..f4d03186e0c1 100644
--- a/drivers/cpufreq/speedstep-smi.c
+++ b/drivers/cpufreq/speedstep-smi.c
@@ -329,13 +329,7 @@ static int speedstep_cpu_init(struct cpufreq_policy *policy)
329 policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL; 329 policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL;
330 policy->cur = speed; 330 policy->cur = speed;
331 331
332 result = cpufreq_frequency_table_cpuinfo(policy, speedstep_freqs); 332 return cpufreq_table_validate_and_show(policy, speedstep_freqs);
333 if (result)
334 return result;
335
336 cpufreq_frequency_table_get_attr(speedstep_freqs, policy->cpu);
337
338 return 0;
339} 333}
340 334
341static int speedstep_cpu_exit(struct cpufreq_policy *policy) 335static int speedstep_cpu_exit(struct cpufreq_policy *policy)