aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Isely <isely@pobox.com>2012-02-20 00:03:39 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-05-07 15:48:19 -0400
commit5f1a12f5d03ecd920e09c08e1b9fc1312a1d6da4 (patch)
tree6e17e2963da3a7bb2641bc5167b320074d30cc1e
parentd1c07ef1135310940f4f49765f7e385aa847cff5 (diff)
[media] pvrusb2: Stop statically initializing reserved struct fields to zero
In any statically initialized data structure, the compiler is going to zero any part which is not already explicitly initialized. While we can take that knowledge overboard and simply avoid initializing anything that needs to be zero, it's at least a good idea not to bother zeroing parts that we don't otherwise care about - like "reserved" fields which may change in the future. Avoiding initialization of those fields now also avoids possible conflict down the road. Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/video/pvrusb2/pvrusb2-v4l2.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
index e1111d968a3d..5e462faa2726 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
@@ -107,7 +107,6 @@ static struct v4l2_fmtdesc pvr_fmtdesc [] = {
107 // This should really be V4L2_PIX_FMT_MPEG, but xawtv 107 // This should really be V4L2_PIX_FMT_MPEG, but xawtv
108 // breaks when I do that. 108 // breaks when I do that.
109 .pixelformat = 0, // V4L2_PIX_FMT_MPEG, 109 .pixelformat = 0, // V4L2_PIX_FMT_MPEG,
110 .reserved = { 0, 0, 0, 0 }
111 } 110 }
112}; 111};
113 112
@@ -145,7 +144,6 @@ static struct v4l2_format pvr_format [] = {
145 .start = { 0, 0 }, 144 .start = { 0, 0 },
146 .count = { 0, 0 }, 145 .count = { 0, 0 },
147 .flags = 0, 146 .flags = 0,
148 .reserved = { 0, 0 }
149 } 147 }
150 } 148 }
151 } 149 }