aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLad, Prabhakar <prabhakar.csengg@gmail.com>2013-07-20 01:21:05 -0400
committerMauro Carvalho Chehab <m.chehab@samsung.com>2013-07-26 12:20:36 -0400
commit5e95814ff3f2a6ea7d76e822bbc3b0c0b94495a4 (patch)
tree8d6d0b8555cd4ba0a669fac76745f3643517a6c3
parent6ef8335928400ab58d547a3a59974d12f1c55d94 (diff)
[media] media: i2c: adv7343: make the platform data members as array
This patch makes the platform data members as array wherever possible, so as this makes easier while collecting the data in DT case and read the entire array at once. This patch also makes appropriate changes to board-da850-evm.c Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Acked-by: Sekhar Nori <nsekhar@ti.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
-rw-r--r--arch/arm/mach-davinci/board-da850-evm.c6
-rw-r--r--drivers/media/i2c/adv7343.c28
-rw-r--r--include/media/adv7343.h20
3 files changed, 20 insertions, 34 deletions
diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
index bea6793a7ede..9f09f45835f8 100644
--- a/arch/arm/mach-davinci/board-da850-evm.c
+++ b/arch/arm/mach-davinci/board-da850-evm.c
@@ -1249,12 +1249,10 @@ static struct vpif_capture_config da850_vpif_capture_config = {
1249 1249
1250static struct adv7343_platform_data adv7343_pdata = { 1250static struct adv7343_platform_data adv7343_pdata = {
1251 .mode_config = { 1251 .mode_config = {
1252 .dac_3 = 1, 1252 .dac = { 1, 1, 1 },
1253 .dac_2 = 1,
1254 .dac_1 = 1,
1255 }, 1253 },
1256 .sd_config = { 1254 .sd_config = {
1257 .sd_dac_out1 = 1, 1255 .sd_dac_out = { 1 },
1258 }, 1256 },
1259}; 1257};
1260 1258
diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c
index 8080c2cf1029..f0238fb3e3e2 100644
--- a/drivers/media/i2c/adv7343.c
+++ b/drivers/media/i2c/adv7343.c
@@ -227,12 +227,12 @@ static int adv7343_setoutput(struct v4l2_subdev *sd, u32 output_type)
227 else 227 else
228 val = state->pdata->mode_config.sleep_mode << 0 | 228 val = state->pdata->mode_config.sleep_mode << 0 |
229 state->pdata->mode_config.pll_control << 1 | 229 state->pdata->mode_config.pll_control << 1 |
230 state->pdata->mode_config.dac_3 << 2 | 230 state->pdata->mode_config.dac[2] << 2 |
231 state->pdata->mode_config.dac_2 << 3 | 231 state->pdata->mode_config.dac[1] << 3 |
232 state->pdata->mode_config.dac_1 << 4 | 232 state->pdata->mode_config.dac[0] << 4 |
233 state->pdata->mode_config.dac_6 << 5 | 233 state->pdata->mode_config.dac[5] << 5 |
234 state->pdata->mode_config.dac_5 << 6 | 234 state->pdata->mode_config.dac[4] << 6 |
235 state->pdata->mode_config.dac_4 << 7; 235 state->pdata->mode_config.dac[3] << 7;
236 236
237 err = adv7343_write(sd, ADV7343_POWER_MODE_REG, val); 237 err = adv7343_write(sd, ADV7343_POWER_MODE_REG, val);
238 if (err < 0) 238 if (err < 0)
@@ -251,15 +251,15 @@ static int adv7343_setoutput(struct v4l2_subdev *sd, u32 output_type)
251 /* configure SD DAC Output 2 and SD DAC Output 1 bit to zero */ 251 /* configure SD DAC Output 2 and SD DAC Output 1 bit to zero */
252 val = state->reg82 & (SD_DAC_1_DI & SD_DAC_2_DI); 252 val = state->reg82 & (SD_DAC_1_DI & SD_DAC_2_DI);
253 253
254 if (state->pdata && state->pdata->sd_config.sd_dac_out1) 254 if (state->pdata && state->pdata->sd_config.sd_dac_out[0])
255 val = val | (state->pdata->sd_config.sd_dac_out1 << 1); 255 val = val | (state->pdata->sd_config.sd_dac_out[0] << 1);
256 else if (state->pdata && !state->pdata->sd_config.sd_dac_out1) 256 else if (state->pdata && !state->pdata->sd_config.sd_dac_out[0])
257 val = val & ~(state->pdata->sd_config.sd_dac_out1 << 1); 257 val = val & ~(state->pdata->sd_config.sd_dac_out[0] << 1);
258 258
259 if (state->pdata && state->pdata->sd_config.sd_dac_out2) 259 if (state->pdata && state->pdata->sd_config.sd_dac_out[1])
260 val = val | (state->pdata->sd_config.sd_dac_out2 << 2); 260 val = val | (state->pdata->sd_config.sd_dac_out[1] << 2);
261 else if (state->pdata && !state->pdata->sd_config.sd_dac_out2) 261 else if (state->pdata && !state->pdata->sd_config.sd_dac_out[1])
262 val = val & ~(state->pdata->sd_config.sd_dac_out2 << 2); 262 val = val & ~(state->pdata->sd_config.sd_dac_out[1] << 2);
263 263
264 err = adv7343_write(sd, ADV7343_SD_MODE_REG2, val); 264 err = adv7343_write(sd, ADV7343_SD_MODE_REG2, val);
265 if (err < 0) 265 if (err < 0)
diff --git a/include/media/adv7343.h b/include/media/adv7343.h
index 944757be49bb..e4142b1ef8cd 100644
--- a/include/media/adv7343.h
+++ b/include/media/adv7343.h
@@ -28,12 +28,7 @@
28 * @pll_control: PLL and oversampling control. This control allows internal 28 * @pll_control: PLL and oversampling control. This control allows internal
29 * PLL 1 circuit to be powered down and the oversampling to be 29 * PLL 1 circuit to be powered down and the oversampling to be
30 * switched off. 30 * switched off.
31 * @dac_1: power on/off DAC 1. 31 * @dac: array to configure power on/off DAC's 1..6
32 * @dac_2: power on/off DAC 2.
33 * @dac_3: power on/off DAC 3.
34 * @dac_4: power on/off DAC 4.
35 * @dac_5: power on/off DAC 5.
36 * @dac_6: power on/off DAC 6.
37 * 32 *
38 * Power mode register (Register 0x0), for more info refer REGISTER MAP ACCESS 33 * Power mode register (Register 0x0), for more info refer REGISTER MAP ACCESS
39 * section of datasheet[1], table 17 page no 30. 34 * section of datasheet[1], table 17 page no 30.
@@ -43,23 +38,16 @@
43struct adv7343_power_mode { 38struct adv7343_power_mode {
44 bool sleep_mode; 39 bool sleep_mode;
45 bool pll_control; 40 bool pll_control;
46 bool dac_1; 41 u32 dac[6];
47 bool dac_2;
48 bool dac_3;
49 bool dac_4;
50 bool dac_5;
51 bool dac_6;
52}; 42};
53 43
54/** 44/**
55 * struct adv7343_sd_config - SD Only Output Configuration. 45 * struct adv7343_sd_config - SD Only Output Configuration.
56 * @sd_dac_out1: Configure SD DAC Output 1. 46 * @sd_dac_out: array configuring SD DAC Outputs 1 and 2
57 * @sd_dac_out2: Configure SD DAC Output 2.
58 */ 47 */
59struct adv7343_sd_config { 48struct adv7343_sd_config {
60 /* SD only Output Configuration */ 49 /* SD only Output Configuration */
61 bool sd_dac_out1; 50 u32 sd_dac_out[2];
62 bool sd_dac_out2;
63}; 51};
64 52
65/** 53/**