diff options
author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2013-06-19 15:57:40 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-06-21 10:33:06 -0400 |
commit | 5e7db0389fd05ba8721df3978b76156917cb4256 (patch) | |
tree | 9b3f5858e47710e1dc445addd20e5b0da2c64008 | |
parent | f3d27f34fdd7701e499617d2c1d94480a98f6d07 (diff) |
[media] go7007: fix return 0 for unsupported devices in go7007_usb_probe()
probe() should not return 0 for unsupported devices, but go7007_usb_probe() does.
The patch fixes it to return -ENODEV.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/staging/media/go7007/go7007-usb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c index 50066e01a6ed..46ed83245035 100644 --- a/drivers/staging/media/go7007/go7007-usb.c +++ b/drivers/staging/media/go7007/go7007-usb.c | |||
@@ -1124,7 +1124,7 @@ static int go7007_usb_probe(struct usb_interface *intf, | |||
1124 | case GO7007_BOARDID_LIFEVIEW_LR192: | 1124 | case GO7007_BOARDID_LIFEVIEW_LR192: |
1125 | printk(KERN_ERR "go7007-usb: The Lifeview TV Walker Ultra " | 1125 | printk(KERN_ERR "go7007-usb: The Lifeview TV Walker Ultra " |
1126 | "is not supported. Sorry!\n"); | 1126 | "is not supported. Sorry!\n"); |
1127 | return 0; | 1127 | return -ENODEV; |
1128 | name = "Lifeview TV Walker Ultra"; | 1128 | name = "Lifeview TV Walker Ultra"; |
1129 | board = &board_lifeview_lr192; | 1129 | board = &board_lifeview_lr192; |
1130 | break; | 1130 | break; |
@@ -1140,7 +1140,7 @@ static int go7007_usb_probe(struct usb_interface *intf, | |||
1140 | default: | 1140 | default: |
1141 | printk(KERN_ERR "go7007-usb: unknown board ID %d!\n", | 1141 | printk(KERN_ERR "go7007-usb: unknown board ID %d!\n", |
1142 | (unsigned int)id->driver_info); | 1142 | (unsigned int)id->driver_info); |
1143 | return 0; | 1143 | return -ENODEV; |
1144 | } | 1144 | } |
1145 | 1145 | ||
1146 | go = go7007_alloc(&board->main_info, &intf->dev); | 1146 | go = go7007_alloc(&board->main_info, &intf->dev); |