aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAkinobu Mita <akinobu.mita@gmail.com>2006-12-22 04:10:28 -0500
committerLinus Torvalds <torvalds@woody.osdl.org>2006-12-22 11:55:50 -0500
commit5e40508e5fee2dac7b04d5bc5b5ef3b452f0a899 (patch)
tree4453c8f429faeec713e2d933aac3e65fd1c9a02a
parent449d4dd5add718578eb2e6671168de9f67dd239c (diff)
[PATCH] tlclk: delete unnecessary sysfs_remove_group
It is unnecessary and invalid to call sysfs_remove_group() after sysfs_create_group() failure. Cc: Sebastien Bouchard <sebastien.bouchard@ca.kontron.com> Cc: Mark Gross <mark.gross@intel.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Greg KH <greg@kroah.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/char/tlclk.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
index 244d30a03fef..448d5083c381 100644
--- a/drivers/char/tlclk.c
+++ b/drivers/char/tlclk.c
@@ -807,8 +807,6 @@ static int __init tlclk_init(void)
807 &tlclk_attribute_group); 807 &tlclk_attribute_group);
808 if (ret) { 808 if (ret) {
809 printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n"); 809 printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n");
810 sysfs_remove_group(&tlclk_device->dev.kobj,
811 &tlclk_attribute_group);
812 goto out5; 810 goto out5;
813 } 811 }
814 812