diff options
author | Pravin B Shelar <pshelar@nicira.com> | 2014-11-05 18:27:48 -0500 |
---|---|---|
committer | Pravin B Shelar <pshelar@nicira.com> | 2014-11-06 02:52:33 -0500 |
commit | 59b93b41e7fa71138734a911b11b044340dd16bd (patch) | |
tree | 7d5680f8c3eba5ce40a04b6115b41550c9d140f5 | |
parent | e1b2cb655060e081e73b384b1fc8b2e978f73467 (diff) |
net: Remove MPLS GSO feature.
Device can export MPLS GSO support in dev->mpls_features same way
it export vlan features in dev->vlan_features. So it is safe to
remove NETIF_F_GSO_MPLS redundant flag.
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
-rw-r--r-- | include/linux/netdev_features.h | 5 | ||||
-rw-r--r-- | include/linux/netdevice.h | 1 | ||||
-rw-r--r-- | include/linux/skbuff.h | 4 | ||||
-rw-r--r-- | net/core/ethtool.c | 1 | ||||
-rw-r--r-- | net/ipv4/af_inet.c | 1 | ||||
-rw-r--r-- | net/ipv4/tcp_offload.c | 1 | ||||
-rw-r--r-- | net/ipv4/udp_offload.c | 3 | ||||
-rw-r--r-- | net/ipv6/ip6_offload.c | 1 | ||||
-rw-r--r-- | net/ipv6/udp_offload.c | 3 | ||||
-rw-r--r-- | net/mpls/mpls_gso.c | 3 |
10 files changed, 5 insertions, 18 deletions
diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index 8c94b07e654a..8e30685affeb 100644 --- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h | |||
@@ -47,7 +47,6 @@ enum { | |||
47 | NETIF_F_GSO_SIT_BIT, /* ... SIT tunnel with TSO */ | 47 | NETIF_F_GSO_SIT_BIT, /* ... SIT tunnel with TSO */ |
48 | NETIF_F_GSO_UDP_TUNNEL_BIT, /* ... UDP TUNNEL with TSO */ | 48 | NETIF_F_GSO_UDP_TUNNEL_BIT, /* ... UDP TUNNEL with TSO */ |
49 | NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT,/* ... UDP TUNNEL with TSO & CSUM */ | 49 | NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT,/* ... UDP TUNNEL with TSO & CSUM */ |
50 | NETIF_F_GSO_MPLS_BIT, /* ... MPLS segmentation */ | ||
51 | NETIF_F_GSO_TUNNEL_REMCSUM_BIT, /* ... TUNNEL with TSO & REMCSUM */ | 50 | NETIF_F_GSO_TUNNEL_REMCSUM_BIT, /* ... TUNNEL with TSO & REMCSUM */ |
52 | /**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */ | 51 | /**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */ |
53 | NETIF_F_GSO_TUNNEL_REMCSUM_BIT, | 52 | NETIF_F_GSO_TUNNEL_REMCSUM_BIT, |
@@ -119,7 +118,6 @@ enum { | |||
119 | #define NETIF_F_GSO_SIT __NETIF_F(GSO_SIT) | 118 | #define NETIF_F_GSO_SIT __NETIF_F(GSO_SIT) |
120 | #define NETIF_F_GSO_UDP_TUNNEL __NETIF_F(GSO_UDP_TUNNEL) | 119 | #define NETIF_F_GSO_UDP_TUNNEL __NETIF_F(GSO_UDP_TUNNEL) |
121 | #define NETIF_F_GSO_UDP_TUNNEL_CSUM __NETIF_F(GSO_UDP_TUNNEL_CSUM) | 120 | #define NETIF_F_GSO_UDP_TUNNEL_CSUM __NETIF_F(GSO_UDP_TUNNEL_CSUM) |
122 | #define NETIF_F_GSO_MPLS __NETIF_F(GSO_MPLS) | ||
123 | #define NETIF_F_GSO_TUNNEL_REMCSUM __NETIF_F(GSO_TUNNEL_REMCSUM) | 121 | #define NETIF_F_GSO_TUNNEL_REMCSUM __NETIF_F(GSO_TUNNEL_REMCSUM) |
124 | #define NETIF_F_HW_VLAN_STAG_FILTER __NETIF_F(HW_VLAN_STAG_FILTER) | 122 | #define NETIF_F_HW_VLAN_STAG_FILTER __NETIF_F(HW_VLAN_STAG_FILTER) |
125 | #define NETIF_F_HW_VLAN_STAG_RX __NETIF_F(HW_VLAN_STAG_RX) | 123 | #define NETIF_F_HW_VLAN_STAG_RX __NETIF_F(HW_VLAN_STAG_RX) |
@@ -183,7 +181,6 @@ enum { | |||
183 | NETIF_F_GSO_IPIP | \ | 181 | NETIF_F_GSO_IPIP | \ |
184 | NETIF_F_GSO_SIT | \ | 182 | NETIF_F_GSO_SIT | \ |
185 | NETIF_F_GSO_UDP_TUNNEL | \ | 183 | NETIF_F_GSO_UDP_TUNNEL | \ |
186 | NETIF_F_GSO_UDP_TUNNEL_CSUM | \ | 184 | NETIF_F_GSO_UDP_TUNNEL_CSUM) |
187 | NETIF_F_GSO_MPLS) | ||
188 | 185 | ||
189 | #endif /* _LINUX_NETDEV_FEATURES_H */ | 186 | #endif /* _LINUX_NETDEV_FEATURES_H */ |
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 4767f546d7c0..90ac95900a11 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h | |||
@@ -3583,7 +3583,6 @@ static inline bool net_gso_ok(netdev_features_t features, int gso_type) | |||
3583 | BUILD_BUG_ON(SKB_GSO_SIT != (NETIF_F_GSO_SIT >> NETIF_F_GSO_SHIFT)); | 3583 | BUILD_BUG_ON(SKB_GSO_SIT != (NETIF_F_GSO_SIT >> NETIF_F_GSO_SHIFT)); |
3584 | BUILD_BUG_ON(SKB_GSO_UDP_TUNNEL != (NETIF_F_GSO_UDP_TUNNEL >> NETIF_F_GSO_SHIFT)); | 3584 | BUILD_BUG_ON(SKB_GSO_UDP_TUNNEL != (NETIF_F_GSO_UDP_TUNNEL >> NETIF_F_GSO_SHIFT)); |
3585 | BUILD_BUG_ON(SKB_GSO_UDP_TUNNEL_CSUM != (NETIF_F_GSO_UDP_TUNNEL_CSUM >> NETIF_F_GSO_SHIFT)); | 3585 | BUILD_BUG_ON(SKB_GSO_UDP_TUNNEL_CSUM != (NETIF_F_GSO_UDP_TUNNEL_CSUM >> NETIF_F_GSO_SHIFT)); |
3586 | BUILD_BUG_ON(SKB_GSO_MPLS != (NETIF_F_GSO_MPLS >> NETIF_F_GSO_SHIFT)); | ||
3587 | BUILD_BUG_ON(SKB_GSO_TUNNEL_REMCSUM != (NETIF_F_GSO_TUNNEL_REMCSUM >> NETIF_F_GSO_SHIFT)); | 3586 | BUILD_BUG_ON(SKB_GSO_TUNNEL_REMCSUM != (NETIF_F_GSO_TUNNEL_REMCSUM >> NETIF_F_GSO_SHIFT)); |
3588 | 3587 | ||
3589 | return (features & feature) == feature; | 3588 | return (features & feature) == feature; |
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 39ec7530ae27..53f4f6c93356 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h | |||
@@ -372,9 +372,7 @@ enum { | |||
372 | 372 | ||
373 | SKB_GSO_UDP_TUNNEL_CSUM = 1 << 11, | 373 | SKB_GSO_UDP_TUNNEL_CSUM = 1 << 11, |
374 | 374 | ||
375 | SKB_GSO_MPLS = 1 << 12, | 375 | SKB_GSO_TUNNEL_REMCSUM = 1 << 12, |
376 | |||
377 | SKB_GSO_TUNNEL_REMCSUM = 1 << 13, | ||
378 | }; | 376 | }; |
379 | 377 | ||
380 | #if BITS_PER_LONG > 32 | 378 | #if BITS_PER_LONG > 32 |
diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 06dfb293e5aa..b0f84f5ddda8 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c | |||
@@ -84,7 +84,6 @@ static const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN] | |||
84 | [NETIF_F_GSO_IPIP_BIT] = "tx-ipip-segmentation", | 84 | [NETIF_F_GSO_IPIP_BIT] = "tx-ipip-segmentation", |
85 | [NETIF_F_GSO_SIT_BIT] = "tx-sit-segmentation", | 85 | [NETIF_F_GSO_SIT_BIT] = "tx-sit-segmentation", |
86 | [NETIF_F_GSO_UDP_TUNNEL_BIT] = "tx-udp_tnl-segmentation", | 86 | [NETIF_F_GSO_UDP_TUNNEL_BIT] = "tx-udp_tnl-segmentation", |
87 | [NETIF_F_GSO_MPLS_BIT] = "tx-mpls-segmentation", | ||
88 | 87 | ||
89 | [NETIF_F_FCOE_CRC_BIT] = "tx-checksum-fcoe-crc", | 88 | [NETIF_F_FCOE_CRC_BIT] = "tx-checksum-fcoe-crc", |
90 | [NETIF_F_SCTP_CSUM_BIT] = "tx-checksum-sctp", | 89 | [NETIF_F_SCTP_CSUM_BIT] = "tx-checksum-sctp", |
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index ed2c672c5b01..3a096bb2d596 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c | |||
@@ -1223,7 +1223,6 @@ static struct sk_buff *inet_gso_segment(struct sk_buff *skb, | |||
1223 | SKB_GSO_UDP_TUNNEL | | 1223 | SKB_GSO_UDP_TUNNEL | |
1224 | SKB_GSO_UDP_TUNNEL_CSUM | | 1224 | SKB_GSO_UDP_TUNNEL_CSUM | |
1225 | SKB_GSO_TUNNEL_REMCSUM | | 1225 | SKB_GSO_TUNNEL_REMCSUM | |
1226 | SKB_GSO_MPLS | | ||
1227 | 0))) | 1226 | 0))) |
1228 | goto out; | 1227 | goto out; |
1229 | 1228 | ||
diff --git a/net/ipv4/tcp_offload.c b/net/ipv4/tcp_offload.c index a1b2a5624f91..9d7930ba8e0f 100644 --- a/net/ipv4/tcp_offload.c +++ b/net/ipv4/tcp_offload.c | |||
@@ -94,7 +94,6 @@ struct sk_buff *tcp_gso_segment(struct sk_buff *skb, | |||
94 | SKB_GSO_GRE_CSUM | | 94 | SKB_GSO_GRE_CSUM | |
95 | SKB_GSO_IPIP | | 95 | SKB_GSO_IPIP | |
96 | SKB_GSO_SIT | | 96 | SKB_GSO_SIT | |
97 | SKB_GSO_MPLS | | ||
98 | SKB_GSO_UDP_TUNNEL | | 97 | SKB_GSO_UDP_TUNNEL | |
99 | SKB_GSO_UDP_TUNNEL_CSUM | | 98 | SKB_GSO_UDP_TUNNEL_CSUM | |
100 | SKB_GSO_TUNNEL_REMCSUM | | 99 | SKB_GSO_TUNNEL_REMCSUM | |
diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c index 0a5a70d0e84c..d3e537ef6b7f 100644 --- a/net/ipv4/udp_offload.c +++ b/net/ipv4/udp_offload.c | |||
@@ -207,8 +207,7 @@ static struct sk_buff *udp4_ufo_fragment(struct sk_buff *skb, | |||
207 | SKB_GSO_UDP_TUNNEL_CSUM | | 207 | SKB_GSO_UDP_TUNNEL_CSUM | |
208 | SKB_GSO_TUNNEL_REMCSUM | | 208 | SKB_GSO_TUNNEL_REMCSUM | |
209 | SKB_GSO_IPIP | | 209 | SKB_GSO_IPIP | |
210 | SKB_GSO_GRE | SKB_GSO_GRE_CSUM | | 210 | SKB_GSO_GRE | SKB_GSO_GRE_CSUM) || |
211 | SKB_GSO_MPLS) || | ||
212 | !(type & (SKB_GSO_UDP)))) | 211 | !(type & (SKB_GSO_UDP)))) |
213 | goto out; | 212 | goto out; |
214 | 213 | ||
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index e9767079a360..fd76ce938c32 100644 --- a/net/ipv6/ip6_offload.c +++ b/net/ipv6/ip6_offload.c | |||
@@ -79,7 +79,6 @@ static struct sk_buff *ipv6_gso_segment(struct sk_buff *skb, | |||
79 | SKB_GSO_UDP_TUNNEL | | 79 | SKB_GSO_UDP_TUNNEL | |
80 | SKB_GSO_UDP_TUNNEL_CSUM | | 80 | SKB_GSO_UDP_TUNNEL_CSUM | |
81 | SKB_GSO_TUNNEL_REMCSUM | | 81 | SKB_GSO_TUNNEL_REMCSUM | |
82 | SKB_GSO_MPLS | | ||
83 | SKB_GSO_TCPV6 | | 82 | SKB_GSO_TCPV6 | |
84 | 0))) | 83 | 0))) |
85 | goto out; | 84 | goto out; |
diff --git a/net/ipv6/udp_offload.c b/net/ipv6/udp_offload.c index 637ba2e438b7..b6aa8ed18257 100644 --- a/net/ipv6/udp_offload.c +++ b/net/ipv6/udp_offload.c | |||
@@ -46,8 +46,7 @@ static struct sk_buff *udp6_ufo_fragment(struct sk_buff *skb, | |||
46 | SKB_GSO_GRE | | 46 | SKB_GSO_GRE | |
47 | SKB_GSO_GRE_CSUM | | 47 | SKB_GSO_GRE_CSUM | |
48 | SKB_GSO_IPIP | | 48 | SKB_GSO_IPIP | |
49 | SKB_GSO_SIT | | 49 | SKB_GSO_SIT) || |
50 | SKB_GSO_MPLS) || | ||
51 | !(type & (SKB_GSO_UDP)))) | 50 | !(type & (SKB_GSO_UDP)))) |
52 | goto out; | 51 | goto out; |
53 | 52 | ||
diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c index e3545f21a099..ca27837974fe 100644 --- a/net/mpls/mpls_gso.c +++ b/net/mpls/mpls_gso.c | |||
@@ -34,8 +34,7 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff *skb, | |||
34 | SKB_GSO_TCP_ECN | | 34 | SKB_GSO_TCP_ECN | |
35 | SKB_GSO_GRE | | 35 | SKB_GSO_GRE | |
36 | SKB_GSO_GRE_CSUM | | 36 | SKB_GSO_GRE_CSUM | |
37 | SKB_GSO_IPIP | | 37 | SKB_GSO_IPIP))) |
38 | SKB_GSO_MPLS))) | ||
39 | goto out; | 38 | goto out; |
40 | 39 | ||
41 | /* Setup inner SKB. */ | 40 | /* Setup inner SKB. */ |