diff options
author | Steffen Klassert <steffen.klassert@secunet.com> | 2014-03-14 02:28:07 -0400 |
---|---|---|
committer | Steffen Klassert <steffen.klassert@secunet.com> | 2014-03-14 02:28:07 -0400 |
commit | 59b84351c0ee97501782988af5ec9c004c4d30ac (patch) | |
tree | ca6f88b85cd0ac463ab87e8f87772865e55b3b5b | |
parent | e924d2d68738f3c63e460a829d4a0eb32e0638e3 (diff) |
ipcomp6: Use the IPsec protocol multiplexer API
Switch ipcomp6 to use the new IPsec protocol multiplexer.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
-rw-r--r-- | net/ipv6/ipcomp6.c | 22 |
1 files changed, 15 insertions, 7 deletions
diff --git a/net/ipv6/ipcomp6.c b/net/ipv6/ipcomp6.c index da9becb42e81..d1c793cffcb5 100644 --- a/net/ipv6/ipcomp6.c +++ b/net/ipv6/ipcomp6.c | |||
@@ -53,7 +53,7 @@ | |||
53 | #include <linux/icmpv6.h> | 53 | #include <linux/icmpv6.h> |
54 | #include <linux/mutex.h> | 54 | #include <linux/mutex.h> |
55 | 55 | ||
56 | static void ipcomp6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | 56 | static int ipcomp6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, |
57 | u8 type, u8 code, int offset, __be32 info) | 57 | u8 type, u8 code, int offset, __be32 info) |
58 | { | 58 | { |
59 | struct net *net = dev_net(skb->dev); | 59 | struct net *net = dev_net(skb->dev); |
@@ -65,19 +65,21 @@ static void ipcomp6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
65 | 65 | ||
66 | if (type != ICMPV6_PKT_TOOBIG && | 66 | if (type != ICMPV6_PKT_TOOBIG && |
67 | type != NDISC_REDIRECT) | 67 | type != NDISC_REDIRECT) |
68 | return; | 68 | return 0; |
69 | 69 | ||
70 | spi = htonl(ntohs(ipcomph->cpi)); | 70 | spi = htonl(ntohs(ipcomph->cpi)); |
71 | x = xfrm_state_lookup(net, skb->mark, (const xfrm_address_t *)&iph->daddr, | 71 | x = xfrm_state_lookup(net, skb->mark, (const xfrm_address_t *)&iph->daddr, |
72 | spi, IPPROTO_COMP, AF_INET6); | 72 | spi, IPPROTO_COMP, AF_INET6); |
73 | if (!x) | 73 | if (!x) |
74 | return; | 74 | return 0; |
75 | 75 | ||
76 | if (type == NDISC_REDIRECT) | 76 | if (type == NDISC_REDIRECT) |
77 | ip6_redirect(skb, net, skb->dev->ifindex, 0); | 77 | ip6_redirect(skb, net, skb->dev->ifindex, 0); |
78 | else | 78 | else |
79 | ip6_update_pmtu(skb, net, info, 0, 0); | 79 | ip6_update_pmtu(skb, net, info, 0, 0); |
80 | xfrm_state_put(x); | 80 | xfrm_state_put(x); |
81 | |||
82 | return 0; | ||
81 | } | 83 | } |
82 | 84 | ||
83 | static struct xfrm_state *ipcomp6_tunnel_create(struct xfrm_state *x) | 85 | static struct xfrm_state *ipcomp6_tunnel_create(struct xfrm_state *x) |
@@ -174,6 +176,11 @@ out: | |||
174 | return err; | 176 | return err; |
175 | } | 177 | } |
176 | 178 | ||
179 | static int ipcomp6_rcv_cb(struct sk_buff *skb, int err) | ||
180 | { | ||
181 | return 0; | ||
182 | } | ||
183 | |||
177 | static const struct xfrm_type ipcomp6_type = | 184 | static const struct xfrm_type ipcomp6_type = |
178 | { | 185 | { |
179 | .description = "IPCOMP6", | 186 | .description = "IPCOMP6", |
@@ -186,11 +193,12 @@ static const struct xfrm_type ipcomp6_type = | |||
186 | .hdr_offset = xfrm6_find_1stfragopt, | 193 | .hdr_offset = xfrm6_find_1stfragopt, |
187 | }; | 194 | }; |
188 | 195 | ||
189 | static const struct inet6_protocol ipcomp6_protocol = | 196 | static struct xfrm6_protocol ipcomp6_protocol = |
190 | { | 197 | { |
191 | .handler = xfrm6_rcv, | 198 | .handler = xfrm6_rcv, |
199 | .cb_handler = ipcomp6_rcv_cb, | ||
192 | .err_handler = ipcomp6_err, | 200 | .err_handler = ipcomp6_err, |
193 | .flags = INET6_PROTO_NOPOLICY, | 201 | .priority = 0, |
194 | }; | 202 | }; |
195 | 203 | ||
196 | static int __init ipcomp6_init(void) | 204 | static int __init ipcomp6_init(void) |
@@ -199,7 +207,7 @@ static int __init ipcomp6_init(void) | |||
199 | pr_info("%s: can't add xfrm type\n", __func__); | 207 | pr_info("%s: can't add xfrm type\n", __func__); |
200 | return -EAGAIN; | 208 | return -EAGAIN; |
201 | } | 209 | } |
202 | if (inet6_add_protocol(&ipcomp6_protocol, IPPROTO_COMP) < 0) { | 210 | if (xfrm6_protocol_register(&ipcomp6_protocol, IPPROTO_COMP) < 0) { |
203 | pr_info("%s: can't add protocol\n", __func__); | 211 | pr_info("%s: can't add protocol\n", __func__); |
204 | xfrm_unregister_type(&ipcomp6_type, AF_INET6); | 212 | xfrm_unregister_type(&ipcomp6_type, AF_INET6); |
205 | return -EAGAIN; | 213 | return -EAGAIN; |
@@ -209,7 +217,7 @@ static int __init ipcomp6_init(void) | |||
209 | 217 | ||
210 | static void __exit ipcomp6_fini(void) | 218 | static void __exit ipcomp6_fini(void) |
211 | { | 219 | { |
212 | if (inet6_del_protocol(&ipcomp6_protocol, IPPROTO_COMP) < 0) | 220 | if (xfrm6_protocol_deregister(&ipcomp6_protocol, IPPROTO_COMP) < 0) |
213 | pr_info("%s: can't remove protocol\n", __func__); | 221 | pr_info("%s: can't remove protocol\n", __func__); |
214 | if (xfrm_unregister_type(&ipcomp6_type, AF_INET6) < 0) | 222 | if (xfrm_unregister_type(&ipcomp6_type, AF_INET6) < 0) |
215 | pr_info("%s: can't remove xfrm type\n", __func__); | 223 | pr_info("%s: can't remove xfrm type\n", __func__); |