diff options
author | Or Gerlitz <ogerlitz@mellanox.com> | 2013-10-15 10:55:22 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-10-17 15:10:50 -0400 |
commit | 5930e8d0ab3689f1e239566443ca8f53e45e01cc (patch) | |
tree | e803509c76df87434c44e2eabc1f1092268e756a | |
parent | fe66bb2db51c9847c23682ef9c140bab6e14b0fa (diff) |
net/mlx4: Fix typo, move similar defs to same location
Small code cleanup:
1. change MLX4_DEV_CAP_FLAGS2_REASSIGN_MAC_EN to MLX4_DEV_CAP_FLAG2_REASSIGN_MAC_EN
2. put MLX4_SET_PORT_PRIO2TC and MLX4_SET_PORT_SCHEDULER in the same union with the
other MLX4_SET_PORT_yyy
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/fw.c | 2 | ||||
-rw-r--r-- | include/linux/mlx4/cmd.h | 6 | ||||
-rw-r--r-- | include/linux/mlx4/device.h | 2 |
4 files changed, 5 insertions, 7 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index fa37b7a61213..85d91665d400 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c | |||
@@ -1733,7 +1733,7 @@ void mlx4_en_stop_port(struct net_device *dev, int detach) | |||
1733 | 1733 | ||
1734 | /* Unregister Mac address for the port */ | 1734 | /* Unregister Mac address for the port */ |
1735 | mlx4_en_put_qp(priv); | 1735 | mlx4_en_put_qp(priv); |
1736 | if (!(mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAGS2_REASSIGN_MAC_EN)) | 1736 | if (!(mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_REASSIGN_MAC_EN)) |
1737 | mdev->mac_removed[priv->port] = 1; | 1737 | mdev->mac_removed[priv->port] = 1; |
1738 | 1738 | ||
1739 | /* Free RX Rings */ | 1739 | /* Free RX Rings */ |
diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index 0d63daa2f422..a377484cf544 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c | |||
@@ -652,7 +652,7 @@ int mlx4_QUERY_DEV_CAP(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap) | |||
652 | QUERY_DEV_CAP_RSVD_LKEY_OFFSET); | 652 | QUERY_DEV_CAP_RSVD_LKEY_OFFSET); |
653 | MLX4_GET(field, outbox, QUERY_DEV_CAP_FW_REASSIGN_MAC); | 653 | MLX4_GET(field, outbox, QUERY_DEV_CAP_FW_REASSIGN_MAC); |
654 | if (field & 1<<6) | 654 | if (field & 1<<6) |
655 | dev_cap->flags2 |= MLX4_DEV_CAP_FLAGS2_REASSIGN_MAC_EN; | 655 | dev_cap->flags2 |= MLX4_DEV_CAP_FLAG2_REASSIGN_MAC_EN; |
656 | MLX4_GET(dev_cap->max_icm_sz, outbox, | 656 | MLX4_GET(dev_cap->max_icm_sz, outbox, |
657 | QUERY_DEV_CAP_MAX_ICM_SZ_OFFSET); | 657 | QUERY_DEV_CAP_MAX_ICM_SZ_OFFSET); |
658 | if (dev_cap->flags & MLX4_DEV_CAP_FLAG_COUNTERS) | 658 | if (dev_cap->flags & MLX4_DEV_CAP_FLAG_COUNTERS) |
diff --git a/include/linux/mlx4/cmd.h b/include/linux/mlx4/cmd.h index cd1fdf75103b..8df61bc5da00 100644 --- a/include/linux/mlx4/cmd.h +++ b/include/linux/mlx4/cmd.h | |||
@@ -154,10 +154,6 @@ enum { | |||
154 | MLX4_CMD_QUERY_IF_STAT = 0X54, | 154 | MLX4_CMD_QUERY_IF_STAT = 0X54, |
155 | MLX4_CMD_SET_IF_STAT = 0X55, | 155 | MLX4_CMD_SET_IF_STAT = 0X55, |
156 | 156 | ||
157 | /* set port opcode modifiers */ | ||
158 | MLX4_SET_PORT_PRIO2TC = 0x8, | ||
159 | MLX4_SET_PORT_SCHEDULER = 0x9, | ||
160 | |||
161 | /* register/delete flow steering network rules */ | 157 | /* register/delete flow steering network rules */ |
162 | MLX4_QP_FLOW_STEERING_ATTACH = 0x65, | 158 | MLX4_QP_FLOW_STEERING_ATTACH = 0x65, |
163 | MLX4_QP_FLOW_STEERING_DETACH = 0x66, | 159 | MLX4_QP_FLOW_STEERING_DETACH = 0x66, |
@@ -182,6 +178,8 @@ enum { | |||
182 | MLX4_SET_PORT_VLAN_TABLE = 0x3, | 178 | MLX4_SET_PORT_VLAN_TABLE = 0x3, |
183 | MLX4_SET_PORT_PRIO_MAP = 0x4, | 179 | MLX4_SET_PORT_PRIO_MAP = 0x4, |
184 | MLX4_SET_PORT_GID_TABLE = 0x5, | 180 | MLX4_SET_PORT_GID_TABLE = 0x5, |
181 | MLX4_SET_PORT_PRIO2TC = 0x8, | ||
182 | MLX4_SET_PORT_SCHEDULER = 0x9, | ||
185 | }; | 183 | }; |
186 | 184 | ||
187 | enum { | 185 | enum { |
diff --git a/include/linux/mlx4/device.h b/include/linux/mlx4/device.h index 24ce6bdd540e..9ad0c18495ad 100644 --- a/include/linux/mlx4/device.h +++ b/include/linux/mlx4/device.h | |||
@@ -155,7 +155,7 @@ enum { | |||
155 | MLX4_DEV_CAP_FLAG2_RSS_TOP = 1LL << 1, | 155 | MLX4_DEV_CAP_FLAG2_RSS_TOP = 1LL << 1, |
156 | MLX4_DEV_CAP_FLAG2_RSS_XOR = 1LL << 2, | 156 | MLX4_DEV_CAP_FLAG2_RSS_XOR = 1LL << 2, |
157 | MLX4_DEV_CAP_FLAG2_FS_EN = 1LL << 3, | 157 | MLX4_DEV_CAP_FLAG2_FS_EN = 1LL << 3, |
158 | MLX4_DEV_CAP_FLAGS2_REASSIGN_MAC_EN = 1LL << 4, | 158 | MLX4_DEV_CAP_FLAG2_REASSIGN_MAC_EN = 1LL << 4, |
159 | MLX4_DEV_CAP_FLAG2_TS = 1LL << 5, | 159 | MLX4_DEV_CAP_FLAG2_TS = 1LL << 5, |
160 | MLX4_DEV_CAP_FLAG2_VLAN_CONTROL = 1LL << 6, | 160 | MLX4_DEV_CAP_FLAG2_VLAN_CONTROL = 1LL << 6, |
161 | MLX4_DEV_CAP_FLAG2_FSM = 1LL << 7, | 161 | MLX4_DEV_CAP_FLAG2_FSM = 1LL << 7, |