diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-09-24 18:27:45 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-24 20:00:26 -0400 |
| commit | 58f09e00ae095e46ef9edfcf3a5fd9ccdfad065e (patch) | |
| tree | b3420bf07c846d71a4d38802177d2d0b215b6f14 | |
| parent | 627aad1c01da6f881e7f98d71fd928ca0c316b1a (diff) | |
cciss: fix info leak in cciss_ioctl32_passthru()
The arg64 struct has a hole after ->buf_size which isn't cleared. Or if
any of the calls to copy_from_user() fail then that would cause an
information leak as well.
This was assigned CVE-2013-2147.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Mike Miller <mike.miller@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/block/cciss.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index d2d95ff5353b..edfa2515bc86 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c | |||
| @@ -1189,6 +1189,7 @@ static int cciss_ioctl32_passthru(struct block_device *bdev, fmode_t mode, | |||
| 1189 | int err; | 1189 | int err; |
| 1190 | u32 cp; | 1190 | u32 cp; |
| 1191 | 1191 | ||
| 1192 | memset(&arg64, 0, sizeof(arg64)); | ||
| 1192 | err = 0; | 1193 | err = 0; |
| 1193 | err |= | 1194 | err |= |
| 1194 | copy_from_user(&arg64.LUN_info, &arg32->LUN_info, | 1195 | copy_from_user(&arg64.LUN_info, &arg32->LUN_info, |