diff options
author | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-18 21:38:25 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-18 21:38:25 -0400 |
commit | 589f1e81bde732dd0b1bc5d01b6bddd4bcb4527b (patch) | |
tree | b7dee3b229edc4a5110be4c6b02f6c7bc6d5a165 | |
parent | ce524c8360d60cc6d3f77986bd58c4448d2b1e3a (diff) | |
parent | 9ee0be05dc69b61e5a869bffebd638b31898dae2 (diff) |
Merge branch 'isdn-fix' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6
* 'isdn-fix' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6:
ISDN HiSax: uninitialized return in hisax_cs_setup
-rw-r--r-- | drivers/isdn/hisax/config.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c index 5f7907e57090..97097ef3491e 100644 --- a/drivers/isdn/hisax/config.c +++ b/drivers/isdn/hisax/config.c | |||
@@ -1146,14 +1146,12 @@ static int hisax_cs_setup(int cardnr, struct IsdnCard *card, | |||
1146 | } | 1146 | } |
1147 | if (ret) { | 1147 | if (ret) { |
1148 | closecard(cardnr); | 1148 | closecard(cardnr); |
1149 | ret = 0; | ||
1150 | goto outf_cs; | 1149 | goto outf_cs; |
1151 | } | 1150 | } |
1152 | init_tei(cs, cs->protocol); | 1151 | init_tei(cs, cs->protocol); |
1153 | ret = CallcNewChan(cs); | 1152 | ret = CallcNewChan(cs); |
1154 | if (ret) { | 1153 | if (ret) { |
1155 | closecard(cardnr); | 1154 | closecard(cardnr); |
1156 | ret = 0; | ||
1157 | goto outf_cs; | 1155 | goto outf_cs; |
1158 | } | 1156 | } |
1159 | /* ISAR needs firmware download first */ | 1157 | /* ISAR needs firmware download first */ |
@@ -1165,7 +1163,7 @@ static int hisax_cs_setup(int cardnr, struct IsdnCard *card, | |||
1165 | outf_cs: | 1163 | outf_cs: |
1166 | kfree(cs); | 1164 | kfree(cs); |
1167 | card->cs = NULL; | 1165 | card->cs = NULL; |
1168 | return ret; | 1166 | return 0; |
1169 | } | 1167 | } |
1170 | 1168 | ||
1171 | static int checkcard(int cardnr, char *id, int *busy_flag, struct module *lockowner) | 1169 | static int checkcard(int cardnr, char *id, int *busy_flag, struct module *lockowner) |