aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHans Verkuil <hans.verkuil@cisco.com>2014-11-24 04:37:22 -0500
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2014-12-02 08:30:04 -0500
commit57e774cc916efa293471bf12d1177574e121378e (patch)
treee4affaa0c38cfadb195ae64ff81cb9f33542f930
parentdfdf780b4651cf4932b96d3fe296230afacc360a (diff)
[media] staging/media: fix querycap
Querycap shouldn't set the version field (the core does that for you), but it should set the device_caps field. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-rw-r--r--drivers/staging/media/bcm2048/radio-bcm2048.c5
-rw-r--r--drivers/staging/media/davinci_vpfe/vpfe_video.c8
-rw-r--r--drivers/staging/media/dt3155v4l/dt3155v4l.c5
3 files changed, 9 insertions, 9 deletions
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index bdc6854d8b53..60a57b2a8fb2 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2327,9 +2327,10 @@ static int bcm2048_vidioc_querycap(struct file *file, void *priv,
2327 strlcpy(capability->card, BCM2048_DRIVER_CARD, 2327 strlcpy(capability->card, BCM2048_DRIVER_CARD,
2328 sizeof(capability->card)); 2328 sizeof(capability->card));
2329 snprintf(capability->bus_info, 32, "I2C: 0x%X", bdev->client->addr); 2329 snprintf(capability->bus_info, 32, "I2C: 0x%X", bdev->client->addr);
2330 capability->version = BCM2048_DRIVER_VERSION; 2330 capability->device_caps = V4L2_CAP_TUNER | V4L2_CAP_RADIO |
2331 capability->capabilities = V4L2_CAP_TUNER | V4L2_CAP_RADIO |
2332 V4L2_CAP_HW_FREQ_SEEK; 2331 V4L2_CAP_HW_FREQ_SEEK;
2332 capability->capabilities = capability->device_caps |
2333 V4L2_CAP_DEVICE_CAPS;
2333 2334
2334 return 0; 2335 return 0;
2335} 2336}
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
index 6f9171c39bdc..06d48d5eb0a0 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
@@ -600,11 +600,11 @@ static int vpfe_querycap(struct file *file, void *priv,
600 v4l2_dbg(1, debug, &vpfe_dev->v4l2_dev, "vpfe_querycap\n"); 600 v4l2_dbg(1, debug, &vpfe_dev->v4l2_dev, "vpfe_querycap\n");
601 601
602 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) 602 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
603 cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING; 603 cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
604 else 604 else
605 cap->capabilities = V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING; 605 cap->device_caps = V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING;
606 cap->device_caps = cap->capabilities; 606 cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_VIDEO_OUTPUT |
607 cap->version = VPFE_CAPTURE_VERSION_CODE; 607 V4L2_CAP_STREAMING | V4L2_CAP_DEVICE_CAPS;
608 strlcpy(cap->driver, CAPTURE_DRV_NAME, sizeof(cap->driver)); 608 strlcpy(cap->driver, CAPTURE_DRV_NAME, sizeof(cap->driver));
609 strlcpy(cap->bus_info, "VPFE", sizeof(cap->bus_info)); 609 strlcpy(cap->bus_info, "VPFE", sizeof(cap->bus_info));
610 strlcpy(cap->card, vpfe_dev->cfg->card_name, sizeof(cap->card)); 610 strlcpy(cap->card, vpfe_dev->cfg->card_name, sizeof(cap->card));
diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drivers/staging/media/dt3155v4l/dt3155v4l.c
index 40580228a6c7..293ffda503e0 100644
--- a/drivers/staging/media/dt3155v4l/dt3155v4l.c
+++ b/drivers/staging/media/dt3155v4l/dt3155v4l.c
@@ -512,10 +512,9 @@ dt3155_ioc_querycap(struct file *filp, void *p, struct v4l2_capability *cap)
512 strcpy(cap->driver, DT3155_NAME); 512 strcpy(cap->driver, DT3155_NAME);
513 strcpy(cap->card, DT3155_NAME " frame grabber"); 513 strcpy(cap->card, DT3155_NAME " frame grabber");
514 sprintf(cap->bus_info, "PCI:%s", pci_name(pd->pdev)); 514 sprintf(cap->bus_info, "PCI:%s", pci_name(pd->pdev));
515 cap->version = 515 cap->device_caps = V4L2_CAP_VIDEO_CAPTURE |
516 KERNEL_VERSION(DT3155_VER_MAJ, DT3155_VER_MIN, DT3155_VER_EXT);
517 cap->capabilities = V4L2_CAP_VIDEO_CAPTURE |
518 DT3155_CAPTURE_METHOD; 516 DT3155_CAPTURE_METHOD;
517 cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
519 return 0; 518 return 0;
520} 519}
521 520