aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYuval Mintz <Yuval.Mintz@qlogic.com>2014-08-28 01:07:32 -0400
committerDavid S. Miller <davem@davemloft.net>2014-08-29 23:34:59 -0400
commit56daf66d3ca9558a71683779eec4f03c878f4de2 (patch)
tree0ddae7a8e3af6af237e29a1aa4a76b050eb8e75c
parent918bbc4ffdb84e9d2696315e427a6c43de65bc01 (diff)
bnx2x: Fix sparse warnings
This fixes a sprase warning introduced recently by commit eeed018cbfa30 ("bnx2x: Add timestamping and PTP hardware clock support"), as well as another unrelated sparse endian issue. Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com> Signed-off-by: Ariel Elior <Ariel.Elior@qlogic.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c2
-rw-r--r--drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c14
2 files changed, 8 insertions, 8 deletions
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index a54ac4560900..06d6d3c9316b 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
@@ -1065,7 +1065,7 @@ reuse_rx:
1065 skb_record_rx_queue(skb, fp->rx_queue); 1065 skb_record_rx_queue(skb, fp->rx_queue);
1066 1066
1067 /* Check if this packet was timestamped */ 1067 /* Check if this packet was timestamped */
1068 if (unlikely(le16_to_cpu(cqe->fast_path_cqe.type_error_flags) & 1068 if (unlikely(cqe->fast_path_cqe.type_error_flags &
1069 (1 << ETH_FAST_PATH_RX_CQE_PTP_PKT_SHIFT))) 1069 (1 << ETH_FAST_PATH_RX_CQE_PTP_PKT_SHIFT)))
1070 bnx2x_set_rx_ts(bp, skb); 1070 bnx2x_set_rx_ts(bp, skb);
1071 1071
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 38acecdd8e9b..19d0c1152434 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -4063,6 +4063,13 @@ static int bnx2x_setup_rss(struct bnx2x *bp,
4063 if (test_bit(BNX2X_RSS_GRE_INNER_HDRS, &p->rss_flags)) 4063 if (test_bit(BNX2X_RSS_GRE_INNER_HDRS, &p->rss_flags))
4064 caps |= ETH_RSS_UPDATE_RAMROD_DATA_GRE_INNER_HDRS_CAPABILITY; 4064 caps |= ETH_RSS_UPDATE_RAMROD_DATA_GRE_INNER_HDRS_CAPABILITY;
4065 4065
4066 /* RSS keys */
4067 if (test_bit(BNX2X_RSS_SET_SRCH, &p->rss_flags)) {
4068 memcpy(&data->rss_key[0], &p->rss_key[0],
4069 sizeof(data->rss_key));
4070 caps |= ETH_RSS_UPDATE_RAMROD_DATA_UPDATE_RSS_KEY;
4071 }
4072
4066 data->capabilities = cpu_to_le16(caps); 4073 data->capabilities = cpu_to_le16(caps);
4067 4074
4068 /* Hashing mask */ 4075 /* Hashing mask */
@@ -4084,13 +4091,6 @@ static int bnx2x_setup_rss(struct bnx2x *bp,
4084 if (netif_msg_ifup(bp)) 4091 if (netif_msg_ifup(bp))
4085 bnx2x_debug_print_ind_table(bp, p); 4092 bnx2x_debug_print_ind_table(bp, p);
4086 4093
4087 /* RSS keys */
4088 if (test_bit(BNX2X_RSS_SET_SRCH, &p->rss_flags)) {
4089 memcpy(&data->rss_key[0], &p->rss_key[0],
4090 sizeof(data->rss_key));
4091 data->capabilities |= ETH_RSS_UPDATE_RAMROD_DATA_UPDATE_RSS_KEY;
4092 }
4093
4094 /* No need for an explicit memory barrier here as long as we 4094 /* No need for an explicit memory barrier here as long as we
4095 * ensure the ordering of writing to the SPQ element 4095 * ensure the ordering of writing to the SPQ element
4096 * and updating of the SPQ producer which involves a memory 4096 * and updating of the SPQ producer which involves a memory