diff options
author | Borislav Petkov <borislav.petkov@amd.com> | 2012-09-04 18:50:26 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rjw@sisk.pl> | 2012-09-04 18:50:26 -0400 |
commit | 56835e6cc053c29bf1a15a07dbeb78f219a15214 (patch) | |
tree | abaf8e7c6154ecb232fee97ab4f5a635210133a1 | |
parent | 2d175069f2b5477692d4bd7586bc530ffe8107bb (diff) |
cpufreq / powernow-k8: Fixup missing _PSS objects message
_PSS objects can also be missing if Cool'N'Quiet is disabled in the
BIOS. Add that to the FW_BUG message for the user to try before updating
her BIOS. Fix formatting while at it.
Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
-rw-r--r-- | drivers/cpufreq/powernow-k8.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index c0e816468e30..33f17c4a1342 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c | |||
@@ -1265,12 +1265,15 @@ static void __cpuinit powernowk8_cpu_init_on_cpu(void *_init_on_cpu) | |||
1265 | init_on_cpu->rc = 0; | 1265 | init_on_cpu->rc = 0; |
1266 | } | 1266 | } |
1267 | 1267 | ||
1268 | static const char missing_pss_msg[] = | ||
1269 | KERN_ERR | ||
1270 | FW_BUG PFX "No compatible ACPI _PSS objects found.\n" | ||
1271 | FW_BUG PFX "First, make sure Cool'N'Quiet is enabled in the BIOS.\n" | ||
1272 | FW_BUG PFX "If that doesn't help, try upgrading your BIOS.\n"; | ||
1273 | |||
1268 | /* per CPU init entry point to the driver */ | 1274 | /* per CPU init entry point to the driver */ |
1269 | static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) | 1275 | static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) |
1270 | { | 1276 | { |
1271 | static const char ACPI_PSS_BIOS_BUG_MSG[] = | ||
1272 | KERN_ERR FW_BUG PFX "No compatible ACPI _PSS objects found.\n" | ||
1273 | FW_BUG PFX "Try again with latest BIOS.\n"; | ||
1274 | struct powernow_k8_data *data; | 1277 | struct powernow_k8_data *data; |
1275 | struct init_on_cpu init_on_cpu; | 1278 | struct init_on_cpu init_on_cpu; |
1276 | int rc; | 1279 | int rc; |
@@ -1298,7 +1301,7 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) | |||
1298 | * an UP version, and is deprecated by AMD. | 1301 | * an UP version, and is deprecated by AMD. |
1299 | */ | 1302 | */ |
1300 | if (num_online_cpus() != 1) { | 1303 | if (num_online_cpus() != 1) { |
1301 | printk_once(ACPI_PSS_BIOS_BUG_MSG); | 1304 | printk_once(missing_pss_msg); |
1302 | goto err_out; | 1305 | goto err_out; |
1303 | } | 1306 | } |
1304 | if (pol->cpu != 0) { | 1307 | if (pol->cpu != 0) { |