diff options
author | Colin Cross <ccross@android.com> | 2013-05-06 19:50:18 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-05-12 08:16:22 -0400 |
commit | 56467c7697f5aef6974501fbe2c3e63674583549 (patch) | |
tree | 28f4d239cfa4f3821009b5edb0023266cc5b2563 | |
parent | 9745cdb36da83aeec198650b410ca06304cf7928 (diff) |
futex: use freezable blocking call
Avoid waking up every thread sleeping in a futex_wait call during
suspend and resume by calling a freezable blocking call. Previous
patches modified the freezer to avoid sending wakeups to threads
that are blocked in freezable blocking calls.
This call was selected to be converted to a freezable call because
it doesn't hold any locks or release any resources when interrupted
that might be needed by another freezing task or a kernel driver
during suspend, and is a common site where idle userspace tasks are
blocked.
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Colin Cross <ccross@android.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r-- | kernel/futex.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/futex.c b/kernel/futex.c index b26dcfc02c94..d710fae8abbe 100644 --- a/kernel/futex.c +++ b/kernel/futex.c | |||
@@ -61,6 +61,7 @@ | |||
61 | #include <linux/nsproxy.h> | 61 | #include <linux/nsproxy.h> |
62 | #include <linux/ptrace.h> | 62 | #include <linux/ptrace.h> |
63 | #include <linux/sched/rt.h> | 63 | #include <linux/sched/rt.h> |
64 | #include <linux/freezer.h> | ||
64 | 65 | ||
65 | #include <asm/futex.h> | 66 | #include <asm/futex.h> |
66 | 67 | ||
@@ -1807,7 +1808,7 @@ static void futex_wait_queue_me(struct futex_hash_bucket *hb, struct futex_q *q, | |||
1807 | * is no timeout, or if it has yet to expire. | 1808 | * is no timeout, or if it has yet to expire. |
1808 | */ | 1809 | */ |
1809 | if (!timeout || timeout->task) | 1810 | if (!timeout || timeout->task) |
1810 | schedule(); | 1811 | freezable_schedule(); |
1811 | } | 1812 | } |
1812 | __set_current_state(TASK_RUNNING); | 1813 | __set_current_state(TASK_RUNNING); |
1813 | } | 1814 | } |