diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-07-23 09:44:21 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-07-24 23:43:19 -0400 |
commit | 55bad82385f036a844429ff8989732f0ea3bfff9 (patch) | |
tree | 29d3a16f12e526d7aa6482acaa4c5a0178408369 | |
parent | 9963a8bde60f3c139b7683e2ec7e0bf83c0d7581 (diff) |
ixgbe: fix ethtool stats
In latest changes about 64bit stats on 32bit arches,
[commit 28172739f0a276eb8 (net: fix 64 bit counters on 32 bit arches)],
I missed ixgbe uses a bit of magic in its ixgbe_gstrings_stats
definition.
IXGBE_NETDEV_STAT() must now assume offsets relative to
rtnl_link_stats64, not relative do dev->stats.
As a bonus, we also get 64bit stats on ethtool -S
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ixgbe/ixgbe_ethtool.c | 42 |
1 files changed, 21 insertions, 21 deletions
diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c index da54b38bb480..dcebc82c6f4d 100644 --- a/drivers/net/ixgbe/ixgbe_ethtool.c +++ b/drivers/net/ixgbe/ixgbe_ethtool.c | |||
@@ -54,14 +54,14 @@ struct ixgbe_stats { | |||
54 | sizeof(((struct ixgbe_adapter *)0)->m), \ | 54 | sizeof(((struct ixgbe_adapter *)0)->m), \ |
55 | offsetof(struct ixgbe_adapter, m) | 55 | offsetof(struct ixgbe_adapter, m) |
56 | #define IXGBE_NETDEV_STAT(m) NETDEV_STATS, \ | 56 | #define IXGBE_NETDEV_STAT(m) NETDEV_STATS, \ |
57 | sizeof(((struct net_device *)0)->m), \ | 57 | sizeof(((struct rtnl_link_stats64 *)0)->m), \ |
58 | offsetof(struct net_device, m) - offsetof(struct net_device, stats) | 58 | offsetof(struct rtnl_link_stats64, m) |
59 | 59 | ||
60 | static struct ixgbe_stats ixgbe_gstrings_stats[] = { | 60 | static struct ixgbe_stats ixgbe_gstrings_stats[] = { |
61 | {"rx_packets", IXGBE_NETDEV_STAT(stats.rx_packets)}, | 61 | {"rx_packets", IXGBE_NETDEV_STAT(rx_packets)}, |
62 | {"tx_packets", IXGBE_NETDEV_STAT(stats.tx_packets)}, | 62 | {"tx_packets", IXGBE_NETDEV_STAT(tx_packets)}, |
63 | {"rx_bytes", IXGBE_NETDEV_STAT(stats.rx_bytes)}, | 63 | {"rx_bytes", IXGBE_NETDEV_STAT(rx_bytes)}, |
64 | {"tx_bytes", IXGBE_NETDEV_STAT(stats.tx_bytes)}, | 64 | {"tx_bytes", IXGBE_NETDEV_STAT(tx_bytes)}, |
65 | {"rx_pkts_nic", IXGBE_STAT(stats.gprc)}, | 65 | {"rx_pkts_nic", IXGBE_STAT(stats.gprc)}, |
66 | {"tx_pkts_nic", IXGBE_STAT(stats.gptc)}, | 66 | {"tx_pkts_nic", IXGBE_STAT(stats.gptc)}, |
67 | {"rx_bytes_nic", IXGBE_STAT(stats.gorc)}, | 67 | {"rx_bytes_nic", IXGBE_STAT(stats.gorc)}, |
@@ -69,27 +69,27 @@ static struct ixgbe_stats ixgbe_gstrings_stats[] = { | |||
69 | {"lsc_int", IXGBE_STAT(lsc_int)}, | 69 | {"lsc_int", IXGBE_STAT(lsc_int)}, |
70 | {"tx_busy", IXGBE_STAT(tx_busy)}, | 70 | {"tx_busy", IXGBE_STAT(tx_busy)}, |
71 | {"non_eop_descs", IXGBE_STAT(non_eop_descs)}, | 71 | {"non_eop_descs", IXGBE_STAT(non_eop_descs)}, |
72 | {"rx_errors", IXGBE_NETDEV_STAT(stats.rx_errors)}, | 72 | {"rx_errors", IXGBE_NETDEV_STAT(rx_errors)}, |
73 | {"tx_errors", IXGBE_NETDEV_STAT(stats.tx_errors)}, | 73 | {"tx_errors", IXGBE_NETDEV_STAT(tx_errors)}, |
74 | {"rx_dropped", IXGBE_NETDEV_STAT(stats.rx_dropped)}, | 74 | {"rx_dropped", IXGBE_NETDEV_STAT(rx_dropped)}, |
75 | {"tx_dropped", IXGBE_NETDEV_STAT(stats.tx_dropped)}, | 75 | {"tx_dropped", IXGBE_NETDEV_STAT(tx_dropped)}, |
76 | {"multicast", IXGBE_NETDEV_STAT(stats.multicast)}, | 76 | {"multicast", IXGBE_NETDEV_STAT(multicast)}, |
77 | {"broadcast", IXGBE_STAT(stats.bprc)}, | 77 | {"broadcast", IXGBE_STAT(stats.bprc)}, |
78 | {"rx_no_buffer_count", IXGBE_STAT(stats.rnbc[0]) }, | 78 | {"rx_no_buffer_count", IXGBE_STAT(stats.rnbc[0]) }, |
79 | {"collisions", IXGBE_NETDEV_STAT(stats.collisions)}, | 79 | {"collisions", IXGBE_NETDEV_STAT(collisions)}, |
80 | {"rx_over_errors", IXGBE_NETDEV_STAT(stats.rx_over_errors)}, | 80 | {"rx_over_errors", IXGBE_NETDEV_STAT(rx_over_errors)}, |
81 | {"rx_crc_errors", IXGBE_NETDEV_STAT(stats.rx_crc_errors)}, | 81 | {"rx_crc_errors", IXGBE_NETDEV_STAT(rx_crc_errors)}, |
82 | {"rx_frame_errors", IXGBE_NETDEV_STAT(stats.rx_frame_errors)}, | 82 | {"rx_frame_errors", IXGBE_NETDEV_STAT(rx_frame_errors)}, |
83 | {"hw_rsc_aggregated", IXGBE_STAT(rsc_total_count)}, | 83 | {"hw_rsc_aggregated", IXGBE_STAT(rsc_total_count)}, |
84 | {"hw_rsc_flushed", IXGBE_STAT(rsc_total_flush)}, | 84 | {"hw_rsc_flushed", IXGBE_STAT(rsc_total_flush)}, |
85 | {"fdir_match", IXGBE_STAT(stats.fdirmatch)}, | 85 | {"fdir_match", IXGBE_STAT(stats.fdirmatch)}, |
86 | {"fdir_miss", IXGBE_STAT(stats.fdirmiss)}, | 86 | {"fdir_miss", IXGBE_STAT(stats.fdirmiss)}, |
87 | {"rx_fifo_errors", IXGBE_NETDEV_STAT(stats.rx_fifo_errors)}, | 87 | {"rx_fifo_errors", IXGBE_NETDEV_STAT(rx_fifo_errors)}, |
88 | {"rx_missed_errors", IXGBE_NETDEV_STAT(stats.rx_missed_errors)}, | 88 | {"rx_missed_errors", IXGBE_NETDEV_STAT(rx_missed_errors)}, |
89 | {"tx_aborted_errors", IXGBE_NETDEV_STAT(stats.tx_aborted_errors)}, | 89 | {"tx_aborted_errors", IXGBE_NETDEV_STAT(tx_aborted_errors)}, |
90 | {"tx_carrier_errors", IXGBE_NETDEV_STAT(stats.tx_carrier_errors)}, | 90 | {"tx_carrier_errors", IXGBE_NETDEV_STAT(tx_carrier_errors)}, |
91 | {"tx_fifo_errors", IXGBE_NETDEV_STAT(stats.tx_fifo_errors)}, | 91 | {"tx_fifo_errors", IXGBE_NETDEV_STAT(tx_fifo_errors)}, |
92 | {"tx_heartbeat_errors", IXGBE_NETDEV_STAT(stats.tx_heartbeat_errors)}, | 92 | {"tx_heartbeat_errors", IXGBE_NETDEV_STAT(tx_heartbeat_errors)}, |
93 | {"tx_timeout_count", IXGBE_STAT(tx_timeout_count)}, | 93 | {"tx_timeout_count", IXGBE_STAT(tx_timeout_count)}, |
94 | {"tx_restart_queue", IXGBE_STAT(restart_queue)}, | 94 | {"tx_restart_queue", IXGBE_STAT(restart_queue)}, |
95 | {"rx_long_length_errors", IXGBE_STAT(stats.roc)}, | 95 | {"rx_long_length_errors", IXGBE_STAT(stats.roc)}, |