diff options
author | Don Fry <donald.h.fry@intel.com> | 2011-10-14 15:54:44 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-11-08 15:53:54 -0500 |
commit | 5510697515fad6fe53d1f845ce21a13900339d82 (patch) | |
tree | 1b6e51068366dea593499241bf1524d46d3be728 | |
parent | 560124095f467c9920c25fa215ab1397dc37d0d6 (diff) |
iwlagn: remove unnecessary type for tracing operations
The device tracing routines only use the priv pointer as an opaque
value. Change from a typed iwl_priv pointer to a null pointer and
eliminate the need to include iwl_priv.h. CMD_ASYNC is defined in
iwl_shared.h which is the only reason it is included.
Signed-off-by: Don Fry <donald.h.fry@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-devtrace.c | 2 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-devtrace.h | 23 |
2 files changed, 12 insertions, 13 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-devtrace.c b/drivers/net/wireless/iwlwifi/iwl-devtrace.c index a635a7e75447..2a2c8de64a04 100644 --- a/drivers/net/wireless/iwlwifi/iwl-devtrace.c +++ b/drivers/net/wireless/iwlwifi/iwl-devtrace.c | |||
@@ -28,7 +28,7 @@ | |||
28 | 28 | ||
29 | /* sparse doesn't like tracepoint macros */ | 29 | /* sparse doesn't like tracepoint macros */ |
30 | #ifndef __CHECKER__ | 30 | #ifndef __CHECKER__ |
31 | #include "iwl-dev.h" | 31 | #include "iwl-trans.h" |
32 | 32 | ||
33 | #define CREATE_TRACE_POINTS | 33 | #define CREATE_TRACE_POINTS |
34 | #include "iwl-devtrace.h" | 34 | #include "iwl-devtrace.h" |
diff --git a/drivers/net/wireless/iwlwifi/iwl-devtrace.h b/drivers/net/wireless/iwlwifi/iwl-devtrace.h index 8a51c5ccda1e..f9d3319ecad5 100644 --- a/drivers/net/wireless/iwlwifi/iwl-devtrace.h +++ b/drivers/net/wireless/iwlwifi/iwl-devtrace.h | |||
@@ -29,7 +29,6 @@ | |||
29 | 29 | ||
30 | #include <linux/tracepoint.h> | 30 | #include <linux/tracepoint.h> |
31 | 31 | ||
32 | struct iwl_priv; | ||
33 | 32 | ||
34 | #if !defined(CONFIG_IWLWIFI_DEVICE_TRACING) || defined(__CHECKER__) | 33 | #if !defined(CONFIG_IWLWIFI_DEVICE_TRACING) || defined(__CHECKER__) |
35 | #undef TRACE_EVENT | 34 | #undef TRACE_EVENT |
@@ -37,14 +36,14 @@ struct iwl_priv; | |||
37 | static inline void trace_ ## name(proto) {} | 36 | static inline void trace_ ## name(proto) {} |
38 | #endif | 37 | #endif |
39 | 38 | ||
40 | #define PRIV_ENTRY __field(struct iwl_priv *, priv) | 39 | #define PRIV_ENTRY __field(void *, priv) |
41 | #define PRIV_ASSIGN __entry->priv = priv | 40 | #define PRIV_ASSIGN __entry->priv = priv |
42 | 41 | ||
43 | #undef TRACE_SYSTEM | 42 | #undef TRACE_SYSTEM |
44 | #define TRACE_SYSTEM iwlwifi_io | 43 | #define TRACE_SYSTEM iwlwifi_io |
45 | 44 | ||
46 | TRACE_EVENT(iwlwifi_dev_ioread32, | 45 | TRACE_EVENT(iwlwifi_dev_ioread32, |
47 | TP_PROTO(struct iwl_priv *priv, u32 offs, u32 val), | 46 | TP_PROTO(void *priv, u32 offs, u32 val), |
48 | TP_ARGS(priv, offs, val), | 47 | TP_ARGS(priv, offs, val), |
49 | TP_STRUCT__entry( | 48 | TP_STRUCT__entry( |
50 | PRIV_ENTRY | 49 | PRIV_ENTRY |
@@ -60,7 +59,7 @@ TRACE_EVENT(iwlwifi_dev_ioread32, | |||
60 | ); | 59 | ); |
61 | 60 | ||
62 | TRACE_EVENT(iwlwifi_dev_iowrite8, | 61 | TRACE_EVENT(iwlwifi_dev_iowrite8, |
63 | TP_PROTO(struct iwl_priv *priv, u32 offs, u8 val), | 62 | TP_PROTO(void *priv, u32 offs, u8 val), |
64 | TP_ARGS(priv, offs, val), | 63 | TP_ARGS(priv, offs, val), |
65 | TP_STRUCT__entry( | 64 | TP_STRUCT__entry( |
66 | PRIV_ENTRY | 65 | PRIV_ENTRY |
@@ -76,7 +75,7 @@ TRACE_EVENT(iwlwifi_dev_iowrite8, | |||
76 | ); | 75 | ); |
77 | 76 | ||
78 | TRACE_EVENT(iwlwifi_dev_iowrite32, | 77 | TRACE_EVENT(iwlwifi_dev_iowrite32, |
79 | TP_PROTO(struct iwl_priv *priv, u32 offs, u32 val), | 78 | TP_PROTO(void *priv, u32 offs, u32 val), |
80 | TP_ARGS(priv, offs, val), | 79 | TP_ARGS(priv, offs, val), |
81 | TP_STRUCT__entry( | 80 | TP_STRUCT__entry( |
82 | PRIV_ENTRY | 81 | PRIV_ENTRY |
@@ -95,7 +94,7 @@ TRACE_EVENT(iwlwifi_dev_iowrite32, | |||
95 | #define TRACE_SYSTEM iwlwifi_ucode | 94 | #define TRACE_SYSTEM iwlwifi_ucode |
96 | 95 | ||
97 | TRACE_EVENT(iwlwifi_dev_ucode_cont_event, | 96 | TRACE_EVENT(iwlwifi_dev_ucode_cont_event, |
98 | TP_PROTO(struct iwl_priv *priv, u32 time, u32 data, u32 ev), | 97 | TP_PROTO(void *priv, u32 time, u32 data, u32 ev), |
99 | TP_ARGS(priv, time, data, ev), | 98 | TP_ARGS(priv, time, data, ev), |
100 | TP_STRUCT__entry( | 99 | TP_STRUCT__entry( |
101 | PRIV_ENTRY | 100 | PRIV_ENTRY |
@@ -115,7 +114,7 @@ TRACE_EVENT(iwlwifi_dev_ucode_cont_event, | |||
115 | ); | 114 | ); |
116 | 115 | ||
117 | TRACE_EVENT(iwlwifi_dev_ucode_wrap_event, | 116 | TRACE_EVENT(iwlwifi_dev_ucode_wrap_event, |
118 | TP_PROTO(struct iwl_priv *priv, u32 wraps, u32 n_entry, u32 p_entry), | 117 | TP_PROTO(void *priv, u32 wraps, u32 n_entry, u32 p_entry), |
119 | TP_ARGS(priv, wraps, n_entry, p_entry), | 118 | TP_ARGS(priv, wraps, n_entry, p_entry), |
120 | TP_STRUCT__entry( | 119 | TP_STRUCT__entry( |
121 | PRIV_ENTRY | 120 | PRIV_ENTRY |
@@ -139,7 +138,7 @@ TRACE_EVENT(iwlwifi_dev_ucode_wrap_event, | |||
139 | #define TRACE_SYSTEM iwlwifi | 138 | #define TRACE_SYSTEM iwlwifi |
140 | 139 | ||
141 | TRACE_EVENT(iwlwifi_dev_hcmd, | 140 | TRACE_EVENT(iwlwifi_dev_hcmd, |
142 | TP_PROTO(struct iwl_priv *priv, u32 flags, | 141 | TP_PROTO(void *priv, u32 flags, |
143 | const void *hcmd0, size_t len0, | 142 | const void *hcmd0, size_t len0, |
144 | const void *hcmd1, size_t len1, | 143 | const void *hcmd1, size_t len1, |
145 | const void *hcmd2, size_t len2), | 144 | const void *hcmd2, size_t len2), |
@@ -164,7 +163,7 @@ TRACE_EVENT(iwlwifi_dev_hcmd, | |||
164 | ); | 163 | ); |
165 | 164 | ||
166 | TRACE_EVENT(iwlwifi_dev_rx, | 165 | TRACE_EVENT(iwlwifi_dev_rx, |
167 | TP_PROTO(struct iwl_priv *priv, void *rxbuf, size_t len), | 166 | TP_PROTO(void *priv, void *rxbuf, size_t len), |
168 | TP_ARGS(priv, rxbuf, len), | 167 | TP_ARGS(priv, rxbuf, len), |
169 | TP_STRUCT__entry( | 168 | TP_STRUCT__entry( |
170 | PRIV_ENTRY | 169 | PRIV_ENTRY |
@@ -179,7 +178,7 @@ TRACE_EVENT(iwlwifi_dev_rx, | |||
179 | ); | 178 | ); |
180 | 179 | ||
181 | TRACE_EVENT(iwlwifi_dev_tx, | 180 | TRACE_EVENT(iwlwifi_dev_tx, |
182 | TP_PROTO(struct iwl_priv *priv, void *tfd, size_t tfdlen, | 181 | TP_PROTO(void *priv, void *tfd, size_t tfdlen, |
183 | void *buf0, size_t buf0_len, | 182 | void *buf0, size_t buf0_len, |
184 | void *buf1, size_t buf1_len), | 183 | void *buf1, size_t buf1_len), |
185 | TP_ARGS(priv, tfd, tfdlen, buf0, buf0_len, buf1, buf1_len), | 184 | TP_ARGS(priv, tfd, tfdlen, buf0, buf0_len, buf1, buf1_len), |
@@ -211,7 +210,7 @@ TRACE_EVENT(iwlwifi_dev_tx, | |||
211 | ); | 210 | ); |
212 | 211 | ||
213 | TRACE_EVENT(iwlwifi_dev_ucode_error, | 212 | TRACE_EVENT(iwlwifi_dev_ucode_error, |
214 | TP_PROTO(struct iwl_priv *priv, u32 desc, u32 tsf_low, | 213 | TP_PROTO(void *priv, u32 desc, u32 tsf_low, |
215 | u32 data1, u32 data2, u32 line, u32 blink1, | 214 | u32 data1, u32 data2, u32 line, u32 blink1, |
216 | u32 blink2, u32 ilink1, u32 ilink2, u32 bcon_time, | 215 | u32 blink2, u32 ilink1, u32 ilink2, u32 bcon_time, |
217 | u32 gp1, u32 gp2, u32 gp3, u32 ucode_ver, u32 hw_ver, | 216 | u32 gp1, u32 gp2, u32 gp3, u32 ucode_ver, u32 hw_ver, |
@@ -271,7 +270,7 @@ TRACE_EVENT(iwlwifi_dev_ucode_error, | |||
271 | ); | 270 | ); |
272 | 271 | ||
273 | TRACE_EVENT(iwlwifi_dev_ucode_event, | 272 | TRACE_EVENT(iwlwifi_dev_ucode_event, |
274 | TP_PROTO(struct iwl_priv *priv, u32 time, u32 data, u32 ev), | 273 | TP_PROTO(void *priv, u32 time, u32 data, u32 ev), |
275 | TP_ARGS(priv, time, data, ev), | 274 | TP_ARGS(priv, time, data, ev), |
276 | TP_STRUCT__entry( | 275 | TP_STRUCT__entry( |
277 | PRIV_ENTRY | 276 | PRIV_ENTRY |