diff options
author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2014-06-19 08:31:52 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-07-22 00:37:05 -0400 |
commit | 54dcf0ceb8a21a898cd436617483e5646f2edcc6 (patch) | |
tree | bf1bfe0d48cb9858987ee54f36270ae23a9bba40 | |
parent | 57a4a3d7f7568c487d5db3e26540bff958000255 (diff) |
drivers/sbus/char: Micro-optimization in display7seg.c
Flipping a bit doesn't need four lines of code; and gcc seems to
actually generate two branches.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/sbus/char/display7seg.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c index b48899ce8506..2b0ce7c350ee 100644 --- a/drivers/sbus/char/display7seg.c +++ b/drivers/sbus/char/display7seg.c | |||
@@ -144,10 +144,7 @@ static long d7s_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
144 | 144 | ||
145 | case D7SIOCTM: | 145 | case D7SIOCTM: |
146 | /* toggle device mode-- flip display orientation */ | 146 | /* toggle device mode-- flip display orientation */ |
147 | if (regs & D7S_FLIP) | 147 | regs ^= D7S_FLIP; |
148 | regs &= ~D7S_FLIP; | ||
149 | else | ||
150 | regs |= D7S_FLIP; | ||
151 | writeb(regs, p->regs); | 148 | writeb(regs, p->regs); |
152 | break; | 149 | break; |
153 | } | 150 | } |