diff options
author | Sage Weil <sage@inktank.com> | 2012-07-30 19:21:40 -0400 |
---|---|---|
committer | Sage Weil <sage@inktank.com> | 2012-07-30 21:15:33 -0400 |
commit | 5469155f2bc83bb2c88b0a0370c3d54d87eed06e (patch) | |
tree | 2124283bd87d274ed0008f0a22711ff4f1b4982d | |
parent | a53aab645c82f0146e35684b34692c69b5118121 (diff) |
libceph: protect ceph_con_open() with mutex
Take the con mutex while we are initiating a ceph open. This is necessary
because the may have previously been in use and then closed, which could
result in a racing workqueue running con_work().
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
Reviewed-by: Alex Elder <elder@inktank.com>
-rw-r--r-- | net/ceph/messenger.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index f1bd3bbb0c46..a4779988c847 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c | |||
@@ -537,6 +537,7 @@ void ceph_con_open(struct ceph_connection *con, | |||
537 | __u8 entity_type, __u64 entity_num, | 537 | __u8 entity_type, __u64 entity_num, |
538 | struct ceph_entity_addr *addr) | 538 | struct ceph_entity_addr *addr) |
539 | { | 539 | { |
540 | mutex_lock(&con->mutex); | ||
540 | dout("con_open %p %s\n", con, ceph_pr_addr(&addr->in_addr)); | 541 | dout("con_open %p %s\n", con, ceph_pr_addr(&addr->in_addr)); |
541 | set_bit(OPENING, &con->state); | 542 | set_bit(OPENING, &con->state); |
542 | WARN_ON(!test_and_clear_bit(CLOSED, &con->state)); | 543 | WARN_ON(!test_and_clear_bit(CLOSED, &con->state)); |
@@ -546,6 +547,7 @@ void ceph_con_open(struct ceph_connection *con, | |||
546 | 547 | ||
547 | memcpy(&con->peer_addr, addr, sizeof(*addr)); | 548 | memcpy(&con->peer_addr, addr, sizeof(*addr)); |
548 | con->delay = 0; /* reset backoff memory */ | 549 | con->delay = 0; /* reset backoff memory */ |
550 | mutex_unlock(&con->mutex); | ||
549 | queue_con(con); | 551 | queue_con(con); |
550 | } | 552 | } |
551 | EXPORT_SYMBOL(ceph_con_open); | 553 | EXPORT_SYMBOL(ceph_con_open); |