diff options
author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2013-12-20 14:17:32 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-02-04 03:28:00 -0500 |
commit | 50c88544d225baadd6de1c4365d4ed16cc942a37 (patch) | |
tree | cb3b749bb728488e50add71004bce48bc8b71df8 | |
parent | 38121b6ef314e556d3b59acc0c41a4d6f7e597fa (diff) |
[media] go7007-loader: fix usb_dev leak
There is usb_get_dev() in go7007_loader_probe(),
but there is no usb_put_dev() anywhere.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
-rw-r--r-- | drivers/staging/media/go7007/go7007-loader.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/staging/media/go7007/go7007-loader.c b/drivers/staging/media/go7007/go7007-loader.c index 10bb41c2fb6d..eecb1f2a5574 100644 --- a/drivers/staging/media/go7007/go7007-loader.c +++ b/drivers/staging/media/go7007/go7007-loader.c | |||
@@ -59,7 +59,7 @@ static int go7007_loader_probe(struct usb_interface *interface, | |||
59 | 59 | ||
60 | if (usbdev->descriptor.bNumConfigurations != 1) { | 60 | if (usbdev->descriptor.bNumConfigurations != 1) { |
61 | dev_err(&interface->dev, "can't handle multiple config\n"); | 61 | dev_err(&interface->dev, "can't handle multiple config\n"); |
62 | return -ENODEV; | 62 | goto failed2; |
63 | } | 63 | } |
64 | 64 | ||
65 | vendor = le16_to_cpu(usbdev->descriptor.idVendor); | 65 | vendor = le16_to_cpu(usbdev->descriptor.idVendor); |
@@ -108,6 +108,7 @@ static int go7007_loader_probe(struct usb_interface *interface, | |||
108 | return 0; | 108 | return 0; |
109 | 109 | ||
110 | failed2: | 110 | failed2: |
111 | usb_put_dev(usbdev); | ||
111 | dev_err(&interface->dev, "probe failed\n"); | 112 | dev_err(&interface->dev, "probe failed\n"); |
112 | return -ENODEV; | 113 | return -ENODEV; |
113 | } | 114 | } |
@@ -115,6 +116,7 @@ failed2: | |||
115 | static void go7007_loader_disconnect(struct usb_interface *interface) | 116 | static void go7007_loader_disconnect(struct usb_interface *interface) |
116 | { | 117 | { |
117 | dev_info(&interface->dev, "disconnect\n"); | 118 | dev_info(&interface->dev, "disconnect\n"); |
119 | usb_put_dev(interface_to_usbdev(interface)); | ||
118 | usb_set_intfdata(interface, NULL); | 120 | usb_set_intfdata(interface, NULL); |
119 | } | 121 | } |
120 | 122 | ||