diff options
| author | Jamie Iles <jamie@jamieiles.com> | 2011-01-11 07:43:52 -0500 |
|---|---|---|
| committer | Grant Likely <grant.likely@secretlab.ca> | 2011-01-11 10:20:07 -0500 |
| commit | 50c01fc355c6a97c511d58411f9bc0e4b8fc4659 (patch) | |
| tree | 95012cb772c16754d9a9db01c428618d2696055e | |
| parent | 76d9cc454a8d0bb7484616a4b8136280068c8a8b (diff) | |
spi/dw_spi: don't treat NULL clk as an error
clk_get() returns a struct clk cookie to the driver and some platforms
may return NULL if they only support a single clock. clk_get() has only
failed if it returns a ERR_PTR() encoded pointer.
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
| -rw-r--r-- | drivers/spi/dw_spi_mmio.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/spi/dw_spi_mmio.c b/drivers/spi/dw_spi_mmio.c index db35bd9c1b24..2fa012c109bc 100644 --- a/drivers/spi/dw_spi_mmio.c +++ b/drivers/spi/dw_spi_mmio.c | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | */ | 9 | */ |
| 10 | 10 | ||
| 11 | #include <linux/clk.h> | 11 | #include <linux/clk.h> |
| 12 | #include <linux/err.h> | ||
| 12 | #include <linux/interrupt.h> | 13 | #include <linux/interrupt.h> |
| 13 | #include <linux/platform_device.h> | 14 | #include <linux/platform_device.h> |
| 14 | #include <linux/slab.h> | 15 | #include <linux/slab.h> |
| @@ -68,8 +69,8 @@ static int __devinit dw_spi_mmio_probe(struct platform_device *pdev) | |||
| 68 | } | 69 | } |
| 69 | 70 | ||
| 70 | dwsmmio->clk = clk_get(&pdev->dev, NULL); | 71 | dwsmmio->clk = clk_get(&pdev->dev, NULL); |
| 71 | if (!dwsmmio->clk) { | 72 | if (IS_ERR(dwsmmio->clk)) { |
| 72 | ret = -ENODEV; | 73 | ret = PTR_ERR(dwsmmio->clk); |
| 73 | goto err_irq; | 74 | goto err_irq; |
| 74 | } | 75 | } |
| 75 | clk_enable(dwsmmio->clk); | 76 | clk_enable(dwsmmio->clk); |
