aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorErik Hugne <erik.hugne@ericsson.com>2015-03-09 05:19:31 -0400
committerDavid S. Miller <davem@davemloft.net>2015-03-09 15:37:04 -0400
commit4fee6be8134a69545caf88d8b439936a326d6d77 (patch)
tree17c60838236bf25aa44f89ba298831cab20ab8e3
parent1e052be69d045c8d0f82ff1116fd3e5a79661745 (diff)
tipc: sparse: fix htons conversion warnings
Commit d0f91938bede ("tipc: add ip/udp media type") introduced some new sparse warnings. Clean them up. Signed-off-by: Erik Hugne <erik.hugne@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/tipc/udp_media.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 0d10001db40d..fc2fb11a354d 100644
--- a/net/tipc/udp_media.c
+++ b/net/tipc/udp_media.c
@@ -162,7 +162,7 @@ static int tipc_udp_send_msg(struct net *net, struct sk_buff *skb,
162 err = -ENODEV; 162 err = -ENODEV;
163 goto tx_error; 163 goto tx_error;
164 } 164 }
165 if (htons(dst->proto) == ETH_P_IP) { 165 if (dst->proto == htons(ETH_P_IP)) {
166 struct flowi4 fl = { 166 struct flowi4 fl = {
167 .daddr = dst->ipv4.s_addr, 167 .daddr = dst->ipv4.s_addr,
168 .saddr = src->ipv4.s_addr, 168 .saddr = src->ipv4.s_addr,
@@ -334,7 +334,7 @@ static int tipc_udp_enable(struct net *net, struct tipc_bearer *b,
334 struct udp_media_addr *remote; 334 struct udp_media_addr *remote;
335 struct udp_media_addr local = {0}; 335 struct udp_media_addr local = {0};
336 struct udp_port_cfg udp_conf = {0}; 336 struct udp_port_cfg udp_conf = {0};
337 struct udp_tunnel_sock_cfg tuncfg = {0}; 337 struct udp_tunnel_sock_cfg tuncfg = {NULL};
338 338
339 ub = kzalloc(sizeof(*ub), GFP_ATOMIC); 339 ub = kzalloc(sizeof(*ub), GFP_ATOMIC);
340 if (!ub) 340 if (!ub)
@@ -351,7 +351,7 @@ static int tipc_udp_enable(struct net *net, struct tipc_bearer *b,
351 rcu_assign_pointer(b->media_ptr, ub); 351 rcu_assign_pointer(b->media_ptr, ub);
352 rcu_assign_pointer(ub->bearer, b); 352 rcu_assign_pointer(ub->bearer, b);
353 tipc_udp_media_addr_set(&b->addr, &local); 353 tipc_udp_media_addr_set(&b->addr, &local);
354 if (htons(local.proto) == ETH_P_IP) { 354 if (local.proto == htons(ETH_P_IP)) {
355 struct net_device *dev; 355 struct net_device *dev;
356 356
357 dev = __ip_dev_find(net, local.ipv4.s_addr, false); 357 dev = __ip_dev_find(net, local.ipv4.s_addr, false);
@@ -366,7 +366,7 @@ static int tipc_udp_enable(struct net *net, struct tipc_bearer *b,
366 b->mtu = dev->mtu - sizeof(struct iphdr) 366 b->mtu = dev->mtu - sizeof(struct iphdr)
367 - sizeof(struct udphdr); 367 - sizeof(struct udphdr);
368#if IS_ENABLED(CONFIG_IPV6) 368#if IS_ENABLED(CONFIG_IPV6)
369 } else if (htons(local.proto) == ETH_P_IPV6) { 369 } else if (local.proto == htons(ETH_P_IPV6)) {
370 udp_conf.family = AF_INET6; 370 udp_conf.family = AF_INET6;
371 udp_conf.use_udp6_tx_checksums = true; 371 udp_conf.use_udp6_tx_checksums = true;
372 udp_conf.use_udp6_rx_checksums = true; 372 udp_conf.use_udp6_rx_checksums = true;