aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2014-11-24 09:36:21 -0500
committerChristoph Hellwig <hch@lst.de>2014-12-04 03:57:13 -0500
commit4e484896ac8b1877097770bc630802d5535e8d46 (patch)
tree1282770ecc90f8a820dd658f67ab507ee2634a99
parent17ea01267c75c5a2e00f3603037715d0d2ce4a58 (diff)
scsi: remove scsi_set_tag_type
There is no benefit over just setting sdev->simple_tags directly. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com Reviewed-by: Hannes Reinecke <hare@suse.de>
-rw-r--r--drivers/scsi/53c700.c2
-rw-r--r--include/scsi/scsi_tcq.h15
2 files changed, 1 insertions, 16 deletions
diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index 2c87a7ac1d86..82abfce1cb42 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -902,8 +902,8 @@ process_message(struct Scsi_Host *host, struct NCR_700_Host_Parameters *hostdata
902 hostdata->tag_negotiated &= ~(1<<scmd_id(SCp)); 902 hostdata->tag_negotiated &= ~(1<<scmd_id(SCp));
903 903
904 SCp->device->tagged_supported = 0; 904 SCp->device->tagged_supported = 0;
905 SCp->device->simple_tags = 0;
905 scsi_change_queue_depth(SCp->device, host->cmd_per_lun); 906 scsi_change_queue_depth(SCp->device, host->cmd_per_lun);
906 scsi_set_tag_type(SCp->device, 0);
907 } else { 907 } else {
908 shost_printk(KERN_WARNING, host, 908 shost_printk(KERN_WARNING, host,
909 "(%d:%d) Unexpected REJECT Message %s\n", 909 "(%d:%d) Unexpected REJECT Message %s\n",
diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
index 681e010c2c48..e624acabd7a0 100644
--- a/include/scsi/scsi_tcq.h
+++ b/include/scsi/scsi_tcq.h
@@ -15,21 +15,6 @@
15 15
16 16
17#ifdef CONFIG_BLOCK 17#ifdef CONFIG_BLOCK
18static inline void scsi_set_tag_type(struct scsi_device *sdev, int tag)
19{
20 switch (tag) {
21 case MSG_ORDERED_TAG:
22 case MSG_SIMPLE_TAG:
23 sdev->simple_tags = 1;
24 break;
25 case 0:
26 /* fall through */
27 default:
28 sdev->simple_tags = 0;
29 break;
30 }
31}
32
33static inline struct scsi_cmnd *scsi_mq_find_tag(struct Scsi_Host *shost, 18static inline struct scsi_cmnd *scsi_mq_find_tag(struct Scsi_Host *shost,
34 int unique_tag) 19 int unique_tag)
35{ 20{