aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHannes Eder <hannes@hanneseder.net>2008-11-23 14:49:52 -0500
committerIngo Molnar <mingo@elte.hu>2008-11-26 02:49:19 -0500
commit4db646b1af8fdcf01d690d29eeae44cd937edb0d (patch)
treec58bc915b2faebad95f0e1cfdc735387e1498ce2
parente951e4af2e399c46891004d4931333d2d8d520ab (diff)
x86: microcode: fix sparse warnings
Impact: make global variables and a function static Fix following sparse warnings: arch/x86/kernel/microcode_core.c:102:22: warning: symbol 'microcode_ops' was not declared. Should it be static? arch/x86/kernel/microcode_core.c:206:24: warning: symbol 'microcode_pdev' was not declared. Should it be static? arch/x86/kernel/microcode_core.c:322:6: warning: symbol 'microcode_update_cpu' was not declared. Should it be static? arch/x86/kernel/microcode_intel.c:468:22: warning: symbol 'microcode_intel_ops' was not declared. Should it be static? Signed-off-by: Hannes Eder <hannes@hanneseder.net> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--arch/x86/kernel/microcode_core.c6
-rw-r--r--arch/x86/kernel/microcode_intel.c2
2 files changed, 4 insertions, 4 deletions
diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c
index 82fb2809ce32..5b711a534495 100644
--- a/arch/x86/kernel/microcode_core.c
+++ b/arch/x86/kernel/microcode_core.c
@@ -99,7 +99,7 @@ MODULE_LICENSE("GPL");
99 99
100#define MICROCODE_VERSION "2.00" 100#define MICROCODE_VERSION "2.00"
101 101
102struct microcode_ops *microcode_ops; 102static struct microcode_ops *microcode_ops;
103 103
104/* no concurrent ->write()s are allowed on /dev/cpu/microcode */ 104/* no concurrent ->write()s are allowed on /dev/cpu/microcode */
105static DEFINE_MUTEX(microcode_mutex); 105static DEFINE_MUTEX(microcode_mutex);
@@ -203,7 +203,7 @@ MODULE_ALIAS_MISCDEV(MICROCODE_MINOR);
203#endif 203#endif
204 204
205/* fake device for request_firmware */ 205/* fake device for request_firmware */
206struct platform_device *microcode_pdev; 206static struct platform_device *microcode_pdev;
207 207
208static ssize_t reload_store(struct sys_device *dev, 208static ssize_t reload_store(struct sys_device *dev,
209 struct sysdev_attribute *attr, 209 struct sysdev_attribute *attr,
@@ -319,7 +319,7 @@ static int microcode_resume_cpu(int cpu)
319 return 0; 319 return 0;
320} 320}
321 321
322void microcode_update_cpu(int cpu) 322static void microcode_update_cpu(int cpu)
323{ 323{
324 struct ucode_cpu_info *uci = ucode_cpu_info + cpu; 324 struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
325 int err = 0; 325 int err = 0;
diff --git a/arch/x86/kernel/microcode_intel.c b/arch/x86/kernel/microcode_intel.c
index 622dc4a21784..c34c820ee486 100644
--- a/arch/x86/kernel/microcode_intel.c
+++ b/arch/x86/kernel/microcode_intel.c
@@ -465,7 +465,7 @@ static void microcode_fini_cpu(int cpu)
465 uci->mc = NULL; 465 uci->mc = NULL;
466} 466}
467 467
468struct microcode_ops microcode_intel_ops = { 468static struct microcode_ops microcode_intel_ops = {
469 .request_microcode_user = request_microcode_user, 469 .request_microcode_user = request_microcode_user,
470 .request_microcode_fw = request_microcode_fw, 470 .request_microcode_fw = request_microcode_fw,
471 .collect_cpu_info = collect_cpu_info, 471 .collect_cpu_info = collect_cpu_info,