diff options
author | Kalesh AP <kalesh.purayil@emulex.com> | 2014-05-09 03:59:17 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-05-09 13:13:39 -0400 |
commit | 4d567d9734ea83ec3dabeb29321584da5f6f0b6c (patch) | |
tree | f05c678e43b887827a8c997ec529e25bc1a71629 | |
parent | f6cbd3644ac3188b422ce83f5a95a65e4450b7c6 (diff) |
be2net: remove unused code in be_cmd_vlan_config()
For putting interface into vlan promiscuous mode, we use be_cmd_rx_filter()
and not be_cmd_vlan_config(). So remove the "promiscuous" argument from
be_cmd_vlan_config().
Signed-off-by: Kalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/emulex/benet/be_cmds.c | 10 | ||||
-rw-r--r-- | drivers/net/ethernet/emulex/benet/be_cmds.h | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/emulex/benet/be_main.c | 3 |
3 files changed, 5 insertions, 10 deletions
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c index 411ff9b97e7c..5b236640ccea 100644 --- a/drivers/net/ethernet/emulex/benet/be_cmds.c +++ b/drivers/net/ethernet/emulex/benet/be_cmds.c | |||
@@ -1788,7 +1788,7 @@ err: | |||
1788 | 1788 | ||
1789 | /* Uses sycnhronous mcc */ | 1789 | /* Uses sycnhronous mcc */ |
1790 | int be_cmd_vlan_config(struct be_adapter *adapter, u32 if_id, u16 *vtag_array, | 1790 | int be_cmd_vlan_config(struct be_adapter *adapter, u32 if_id, u16 *vtag_array, |
1791 | u32 num, bool promiscuous) | 1791 | u32 num) |
1792 | { | 1792 | { |
1793 | struct be_mcc_wrb *wrb; | 1793 | struct be_mcc_wrb *wrb; |
1794 | struct be_cmd_req_vlan_config *req; | 1794 | struct be_cmd_req_vlan_config *req; |
@@ -1808,16 +1808,12 @@ int be_cmd_vlan_config(struct be_adapter *adapter, u32 if_id, u16 *vtag_array, | |||
1808 | wrb, NULL); | 1808 | wrb, NULL); |
1809 | 1809 | ||
1810 | req->interface_id = if_id; | 1810 | req->interface_id = if_id; |
1811 | req->promiscuous = promiscuous; | ||
1812 | req->untagged = BE_IF_FLAGS_UNTAGGED & be_if_cap_flags(adapter) ? 1 : 0; | 1811 | req->untagged = BE_IF_FLAGS_UNTAGGED & be_if_cap_flags(adapter) ? 1 : 0; |
1813 | req->num_vlan = num; | 1812 | req->num_vlan = num; |
1814 | if (!promiscuous) { | 1813 | memcpy(req->normal_vlan, vtag_array, |
1815 | memcpy(req->normal_vlan, vtag_array, | 1814 | req->num_vlan * sizeof(vtag_array[0])); |
1816 | req->num_vlan * sizeof(vtag_array[0])); | ||
1817 | } | ||
1818 | 1815 | ||
1819 | status = be_mcc_notify_wait(adapter); | 1816 | status = be_mcc_notify_wait(adapter); |
1820 | |||
1821 | err: | 1817 | err: |
1822 | spin_unlock_bh(&adapter->mcc_lock); | 1818 | spin_unlock_bh(&adapter->mcc_lock); |
1823 | return status; | 1819 | return status; |
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.h b/drivers/net/ethernet/emulex/benet/be_cmds.h index 4ea79b9c67e9..228d4b611084 100644 --- a/drivers/net/ethernet/emulex/benet/be_cmds.h +++ b/drivers/net/ethernet/emulex/benet/be_cmds.h | |||
@@ -2060,7 +2060,7 @@ int be_cmd_get_fw_ver(struct be_adapter *adapter, char *fw_ver, | |||
2060 | char *fw_on_flash); | 2060 | char *fw_on_flash); |
2061 | int be_cmd_modify_eqd(struct be_adapter *adapter, struct be_set_eqd *, int num); | 2061 | int be_cmd_modify_eqd(struct be_adapter *adapter, struct be_set_eqd *, int num); |
2062 | int be_cmd_vlan_config(struct be_adapter *adapter, u32 if_id, u16 *vtag_array, | 2062 | int be_cmd_vlan_config(struct be_adapter *adapter, u32 if_id, u16 *vtag_array, |
2063 | u32 num, bool promiscuous); | 2063 | u32 num); |
2064 | int be_cmd_rx_filter(struct be_adapter *adapter, u32 flags, u32 status); | 2064 | int be_cmd_rx_filter(struct be_adapter *adapter, u32 flags, u32 status); |
2065 | int be_cmd_set_flow_control(struct be_adapter *adapter, u32 tx_fc, u32 rx_fc); | 2065 | int be_cmd_set_flow_control(struct be_adapter *adapter, u32 tx_fc, u32 rx_fc); |
2066 | int be_cmd_get_flow_control(struct be_adapter *adapter, u32 *tx_fc, u32 *rx_fc); | 2066 | int be_cmd_get_flow_control(struct be_adapter *adapter, u32 *tx_fc, u32 *rx_fc); |
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 2cd733b5de73..3f04356afa82 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c | |||
@@ -1108,8 +1108,7 @@ static int be_vid_config(struct be_adapter *adapter) | |||
1108 | for_each_set_bit(i, adapter->vids, VLAN_N_VID) | 1108 | for_each_set_bit(i, adapter->vids, VLAN_N_VID) |
1109 | vids[num++] = cpu_to_le16(i); | 1109 | vids[num++] = cpu_to_le16(i); |
1110 | 1110 | ||
1111 | status = be_cmd_vlan_config(adapter, adapter->if_handle, vids, num, 0); | 1111 | status = be_cmd_vlan_config(adapter, adapter->if_handle, vids, num); |
1112 | |||
1113 | if (status) { | 1112 | if (status) { |
1114 | /* Set to VLAN promisc mode as setting VLAN filter failed */ | 1113 | /* Set to VLAN promisc mode as setting VLAN filter failed */ |
1115 | if (status == MCC_ADDL_STS_INSUFFICIENT_RESOURCES) | 1114 | if (status == MCC_ADDL_STS_INSUFFICIENT_RESOURCES) |