diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-08-08 06:07:45 -0400 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2014-11-09 17:59:34 -0500 |
commit | 4cdd641dddd0ecd93f7b84fc3622df83937f6094 (patch) | |
tree | ec26e7e419c3de44cdab435fc2fc2872adf96388 | |
parent | 0f9da5cb746581ae2de120c78a8afe29fb594fe4 (diff) |
powerpc/fsl: fsl_soc: delete unneeded test before of_node_put
Of_node_put supports NULL as its argument, so the initial test is not
necessary.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
-rw-r--r-- | arch/powerpc/sysdev/fsl_soc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c index 1e04568da3b9..99269c041615 100644 --- a/arch/powerpc/sysdev/fsl_soc.c +++ b/arch/powerpc/sysdev/fsl_soc.c | |||
@@ -197,8 +197,7 @@ static int __init setup_rstcr(void) | |||
197 | if (!rstcr && ppc_md.restart == fsl_rstcr_restart) | 197 | if (!rstcr && ppc_md.restart == fsl_rstcr_restart) |
198 | printk(KERN_ERR "No RSTCR register, warm reboot won't work\n"); | 198 | printk(KERN_ERR "No RSTCR register, warm reboot won't work\n"); |
199 | 199 | ||
200 | if (np) | 200 | of_node_put(np); |
201 | of_node_put(np); | ||
202 | 201 | ||
203 | return 0; | 202 | return 0; |
204 | } | 203 | } |