diff options
author | Axel Lin <axel.lin@ingics.com> | 2013-04-07 23:43:02 -0400 |
---|---|---|
committer | Mike Turquette <mturquette@linaro.org> | 2013-04-09 01:26:36 -0400 |
commit | 4cb24e68a5af427651b3529cd3fe382fb9ba1544 (patch) | |
tree | 6d2961ffbf377e4544ecb22a53c4db827b4c5d2b | |
parent | a68de8e4ab2756d8e125cf327f044c895b6a6b3d (diff) |
clk: mvebu: Fix valid value range checking for cpu_freq_select
cpu_freq_select is used as array subscript, thus the valid value range
is 0 ... ARRAY_SIZE() - 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
[mturquette@linaro.org: fixed up trivial merge issues]
-rw-r--r-- | drivers/clk/mvebu/clk-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/clk/mvebu/clk-core.c b/drivers/clk/mvebu/clk-core.c index 69056a7479e8..2628610c1929 100644 --- a/drivers/clk/mvebu/clk-core.c +++ b/drivers/clk/mvebu/clk-core.c | |||
@@ -156,7 +156,7 @@ static u32 __init armada_370_get_cpu_freq(void __iomem *sar) | |||
156 | 156 | ||
157 | cpu_freq_select = ((readl(sar) >> SARL_A370_PCLK_FREQ_OPT) & | 157 | cpu_freq_select = ((readl(sar) >> SARL_A370_PCLK_FREQ_OPT) & |
158 | SARL_A370_PCLK_FREQ_OPT_MASK); | 158 | SARL_A370_PCLK_FREQ_OPT_MASK); |
159 | if (cpu_freq_select > ARRAY_SIZE(armada_370_cpu_frequencies)) { | 159 | if (cpu_freq_select >= ARRAY_SIZE(armada_370_cpu_frequencies)) { |
160 | pr_err("CPU freq select unsuported %d\n", cpu_freq_select); | 160 | pr_err("CPU freq select unsuported %d\n", cpu_freq_select); |
161 | cpu_freq = 0; | 161 | cpu_freq = 0; |
162 | } else | 162 | } else |
@@ -278,7 +278,7 @@ static u32 __init armada_xp_get_cpu_freq(void __iomem *sar) | |||
278 | cpu_freq_select |= (((readl(sar+4) >> SARH_AXP_PCLK_FREQ_OPT) & | 278 | cpu_freq_select |= (((readl(sar+4) >> SARH_AXP_PCLK_FREQ_OPT) & |
279 | SARH_AXP_PCLK_FREQ_OPT_MASK) | 279 | SARH_AXP_PCLK_FREQ_OPT_MASK) |
280 | << SARH_AXP_PCLK_FREQ_OPT_SHIFT); | 280 | << SARH_AXP_PCLK_FREQ_OPT_SHIFT); |
281 | if (cpu_freq_select > ARRAY_SIZE(armada_xp_cpu_frequencies)) { | 281 | if (cpu_freq_select >= ARRAY_SIZE(armada_xp_cpu_frequencies)) { |
282 | pr_err("CPU freq select unsuported: %d\n", cpu_freq_select); | 282 | pr_err("CPU freq select unsuported: %d\n", cpu_freq_select); |
283 | cpu_freq = 0; | 283 | cpu_freq = 0; |
284 | } else | 284 | } else |