diff options
author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2013-02-05 19:30:01 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-02-05 21:07:13 -0500 |
commit | 4c56a2b63979ec1992fddc087c4660fde7d8e6c0 (patch) | |
tree | edc0a91bff0a5b0eda19e2f9dbc37baa814b2f1a | |
parent | 6f25a527eac10d9ba277a2de7a2a9d3e92c08a52 (diff) |
staging: comedi: vmk80xx: remove CONFIG_COMEDI_DEBUG code
If CONFIG_COMEDI_DEBUG is defined a macro is enabled to output some
printk(KERN_REBUG ...) messages. These are just added noise. Remove
it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/comedi/drivers/vmk80xx.c | 46 |
1 files changed, 8 insertions, 38 deletions
diff --git a/drivers/staging/comedi/drivers/vmk80xx.c b/drivers/staging/comedi/drivers/vmk80xx.c index 5ba963281cfe..8ec5985121ee 100644 --- a/drivers/staging/comedi/drivers/vmk80xx.c +++ b/drivers/staging/comedi/drivers/vmk80xx.c | |||
@@ -123,18 +123,6 @@ enum { | |||
123 | #define URB_RCV_FLAG (1 << 0) | 123 | #define URB_RCV_FLAG (1 << 0) |
124 | #define URB_SND_FLAG (1 << 1) | 124 | #define URB_SND_FLAG (1 << 1) |
125 | 125 | ||
126 | #ifdef CONFIG_COMEDI_DEBUG | ||
127 | static int dbgcm = 1; | ||
128 | #else | ||
129 | static int dbgcm; | ||
130 | #endif | ||
131 | |||
132 | #define dbgcm(fmt, arg...) \ | ||
133 | do { \ | ||
134 | if (dbgcm) \ | ||
135 | printk(KERN_DEBUG fmt, ##arg); \ | ||
136 | } while (0) | ||
137 | |||
138 | enum vmk80xx_model { | 126 | enum vmk80xx_model { |
139 | VMK8055_MODEL, | 127 | VMK8055_MODEL, |
140 | VMK8061_MODEL | 128 | VMK8061_MODEL |
@@ -212,12 +200,6 @@ static void vmk80xx_tx_callback(struct urb *urb) | |||
212 | { | 200 | { |
213 | struct vmk80xx_private *devpriv = urb->context; | 201 | struct vmk80xx_private *devpriv = urb->context; |
214 | unsigned long *flags = &devpriv->flags; | 202 | unsigned long *flags = &devpriv->flags; |
215 | int stat = urb->status; | ||
216 | |||
217 | if (stat && !(stat == -ENOENT | ||
218 | || stat == -ECONNRESET || stat == -ESHUTDOWN)) | ||
219 | dbgcm("comedi#: vmk80xx: %s - nonzero urb status (%d)\n", | ||
220 | __func__, stat); | ||
221 | 203 | ||
222 | if (!test_bit(TRANS_OUT_BUSY, flags)) | 204 | if (!test_bit(TRANS_OUT_BUSY, flags)) |
223 | return; | 205 | return; |
@@ -241,26 +223,16 @@ static void vmk80xx_rx_callback(struct urb *urb) | |||
241 | case -ESHUTDOWN: | 223 | case -ESHUTDOWN: |
242 | break; | 224 | break; |
243 | default: | 225 | default: |
244 | dbgcm("comedi#: vmk80xx: %s - nonzero urb status (%d)\n", | 226 | /* Try to resubmit the urb */ |
245 | __func__, stat); | 227 | if (test_bit(TRANS_IN_RUNNING, flags) && devpriv->intf) { |
246 | goto resubmit; | 228 | usb_anchor_urb(urb, &devpriv->rx_anchor); |
247 | } | ||
248 | |||
249 | goto exit; | ||
250 | resubmit: | ||
251 | if (test_bit(TRANS_IN_RUNNING, flags) && devpriv->intf) { | ||
252 | usb_anchor_urb(urb, &devpriv->rx_anchor); | ||
253 | |||
254 | if (!usb_submit_urb(urb, GFP_KERNEL)) | ||
255 | goto exit; | ||
256 | 229 | ||
257 | dev_err(&urb->dev->dev, | 230 | if (usb_submit_urb(urb, GFP_KERNEL)) |
258 | "comedi#: vmk80xx: %s - submit urb failed\n", | 231 | usb_unanchor_urb(urb); |
259 | __func__); | 232 | } |
260 | 233 | break; | |
261 | usb_unanchor_urb(urb); | ||
262 | } | 234 | } |
263 | exit: | 235 | |
264 | clear_bit(TRANS_IN_BUSY, flags); | 236 | clear_bit(TRANS_IN_BUSY, flags); |
265 | 237 | ||
266 | wake_up_interruptible(&devpriv->read_wait); | 238 | wake_up_interruptible(&devpriv->read_wait); |
@@ -1187,8 +1159,6 @@ static int vmk80xx_auto_attach(struct comedi_device *dev, | |||
1187 | if (vmk80xx_check_data_link(devpriv)) { | 1159 | if (vmk80xx_check_data_link(devpriv)) { |
1188 | vmk80xx_read_eeprom(devpriv, IC6_VERSION); | 1160 | vmk80xx_read_eeprom(devpriv, IC6_VERSION); |
1189 | dev_info(&intf->dev, "%s\n", devpriv->fw.ic6_vers); | 1161 | dev_info(&intf->dev, "%s\n", devpriv->fw.ic6_vers); |
1190 | } else { | ||
1191 | dbgcm("comedi#: vmk80xx: no conn. to CPU\n"); | ||
1192 | } | 1162 | } |
1193 | } | 1163 | } |
1194 | 1164 | ||