diff options
author | Tushar Behera <tushar.behera@linaro.org> | 2012-11-18 19:45:19 -0500 |
---|---|---|
committer | Kukjin Kim <kgene.kim@samsung.com> | 2012-11-18 20:03:35 -0500 |
commit | 4a991b410cd7940c48f261e854e8698923e23fd2 (patch) | |
tree | 0c88407553fd49054c1701fe9a156e573dd3bb0e | |
parent | 6edc794a5ff245faf60488d32e9fdbeb0aad2223 (diff) |
pinctrl: samsung: Update error check for unsigned variables
Checking '< 0' for unsigned variables always returns false. For error
codes, use IS_ERR_VALUE() instead.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
-rw-r--r-- | drivers/pinctrl/pinctrl-samsung.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c index 81c9896d4f64..3b52c17c4fd2 100644 --- a/drivers/pinctrl/pinctrl-samsung.c +++ b/drivers/pinctrl/pinctrl-samsung.c | |||
@@ -560,7 +560,7 @@ static int __devinit samsung_pinctrl_parse_dt_pins(struct platform_device *pdev, | |||
560 | const char *pin_name; | 560 | const char *pin_name; |
561 | 561 | ||
562 | *npins = of_property_count_strings(cfg_np, "samsung,pins"); | 562 | *npins = of_property_count_strings(cfg_np, "samsung,pins"); |
563 | if (*npins < 0) { | 563 | if (IS_ERR_VALUE(*npins)) { |
564 | dev_err(dev, "invalid pin list in %s node", cfg_np->name); | 564 | dev_err(dev, "invalid pin list in %s node", cfg_np->name); |
565 | return -EINVAL; | 565 | return -EINVAL; |
566 | } | 566 | } |