diff options
author | Silviu-Mihai Popescu <silviupopescu1990@gmail.com> | 2013-03-22 09:10:42 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-03-31 19:10:27 -0400 |
commit | 488540bf41ce8ccfe8b54c646c3ea67a7196edcd (patch) | |
tree | bb4b7957bc6901bd0c34bcb7c4acd0b29d7d352f | |
parent | 9a23fe65cf36efc6cb40e96405a3f142c7732805 (diff) |
cpuidle: kirkwood: fix coccicheck warnings
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r-- | drivers/cpuidle/cpuidle-kirkwood.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c index 670aa1e55cd6..53aad7324965 100644 --- a/drivers/cpuidle/cpuidle-kirkwood.c +++ b/drivers/cpuidle/cpuidle-kirkwood.c | |||
@@ -66,9 +66,9 @@ static int kirkwood_cpuidle_probe(struct platform_device *pdev) | |||
66 | if (res == NULL) | 66 | if (res == NULL) |
67 | return -EINVAL; | 67 | return -EINVAL; |
68 | 68 | ||
69 | ddr_operation_base = devm_request_and_ioremap(&pdev->dev, res); | 69 | ddr_operation_base = devm_ioremap_resource(&pdev->dev, res); |
70 | if (!ddr_operation_base) | 70 | if (IS_ERR(ddr_operation_base)) |
71 | return -EADDRNOTAVAIL; | 71 | return PTR_ERR(ddr_operation_base); |
72 | 72 | ||
73 | device = &per_cpu(kirkwood_cpuidle_device, smp_processor_id()); | 73 | device = &per_cpu(kirkwood_cpuidle_device, smp_processor_id()); |
74 | device->state_count = KIRKWOOD_MAX_STATES; | 74 | device->state_count = KIRKWOOD_MAX_STATES; |