diff options
author | Jeff Liu <jeff.liu@oracle.com> | 2013-01-28 08:27:04 -0500 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-02-01 15:43:51 -0500 |
commit | 4800104438a4467ffa5ae1e51d5a59c0f64e5f9a (patch) | |
tree | 39472a1139ea146b45b537b924e166fc7dc9a00d | |
parent | f0f2df94faca43fd26f85af7e83df240777c8c37 (diff) |
xfs: calculate XFS_TRANS_QM_DQALLOC space log reservation at mount time
The disk quota allocation log space reservation is calcuated at runtime,
this patch does it at mount time.
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
CC: Dave Chinner <david@fromorbit.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
-rw-r--r-- | fs/xfs/xfs_dquot.c | 12 | ||||
-rw-r--r-- | fs/xfs/xfs_mount.h | 1 | ||||
-rw-r--r-- | fs/xfs/xfs_trans.c | 15 | ||||
-rw-r--r-- | fs/xfs/xfs_trans.h | 1 |
4 files changed, 20 insertions, 9 deletions
diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c index 9e1bf5294c91..8025eb23ad72 100644 --- a/fs/xfs/xfs_dquot.c +++ b/fs/xfs/xfs_dquot.c | |||
@@ -612,15 +612,9 @@ xfs_qm_dqread( | |||
612 | if (flags & XFS_QMOPT_DQALLOC) { | 612 | if (flags & XFS_QMOPT_DQALLOC) { |
613 | tp = xfs_trans_alloc(mp, XFS_TRANS_QM_DQALLOC); | 613 | tp = xfs_trans_alloc(mp, XFS_TRANS_QM_DQALLOC); |
614 | error = xfs_trans_reserve(tp, XFS_QM_DQALLOC_SPACE_RES(mp), | 614 | error = xfs_trans_reserve(tp, XFS_QM_DQALLOC_SPACE_RES(mp), |
615 | XFS_WRITE_LOG_RES(mp) + | 615 | XFS_QM_DQALLOC_LOG_RES(mp), 0, |
616 | /* | 616 | XFS_TRANS_PERM_LOG_RES, |
617 | * Round the chunklen up to the next multiple | 617 | XFS_WRITE_LOG_COUNT); |
618 | * of 128 (buf log item chunk size)). | ||
619 | */ | ||
620 | BBTOB(mp->m_quotainfo->qi_dqchunklen) - 1 + 128, | ||
621 | 0, | ||
622 | XFS_TRANS_PERM_LOG_RES, | ||
623 | XFS_WRITE_LOG_COUNT); | ||
624 | if (error) | 618 | if (error) |
625 | goto error1; | 619 | goto error1; |
626 | cancelflags = XFS_TRANS_RELEASE_LOG_RES; | 620 | cancelflags = XFS_TRANS_RELEASE_LOG_RES; |
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index 9baa7e0fbd45..fc500c6c8800 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h | |||
@@ -42,6 +42,7 @@ typedef struct xfs_trans_reservations { | |||
42 | uint tr_growrtfree; /* grow realtime freeing */ | 42 | uint tr_growrtfree; /* grow realtime freeing */ |
43 | uint tr_qm_sbchange; /* change quota flags */ | 43 | uint tr_qm_sbchange; /* change quota flags */ |
44 | uint tr_qm_setqlim; /* adjust quota limits */ | 44 | uint tr_qm_setqlim; /* adjust quota limits */ |
45 | uint tr_qm_dqalloc; /* allocate quota on disk */ | ||
45 | } xfs_trans_reservations_t; | 46 | } xfs_trans_reservations_t; |
46 | 47 | ||
47 | #ifndef __KERNEL__ | 48 | #ifndef __KERNEL__ |
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c index 1838850de145..6dd2c043efcd 100644 --- a/fs/xfs/xfs_trans.c +++ b/fs/xfs/xfs_trans.c | |||
@@ -568,6 +568,20 @@ xfs_calc_qm_setqlim_reservation( | |||
568 | } | 568 | } |
569 | 569 | ||
570 | /* | 570 | /* |
571 | * Allocating quota on disk if needed. | ||
572 | * the write transaction log space: XFS_WRITE_LOG_RES(mp) | ||
573 | * the unit of quota allocation: one system block size | ||
574 | */ | ||
575 | STATIC uint | ||
576 | xfs_calc_qm_dqalloc_reservation( | ||
577 | struct xfs_mount *mp) | ||
578 | { | ||
579 | return XFS_WRITE_LOG_RES(mp) + | ||
580 | xfs_calc_buf_res(1, | ||
581 | XFS_FSB_TO_B(mp, XFS_DQUOT_CLUSTER_SIZE_FSB) - 1); | ||
582 | } | ||
583 | |||
584 | /* | ||
571 | * Initialize the precomputed transaction reservation values | 585 | * Initialize the precomputed transaction reservation values |
572 | * in the mount structure. | 586 | * in the mount structure. |
573 | */ | 587 | */ |
@@ -600,6 +614,7 @@ xfs_trans_init( | |||
600 | resp->tr_growrtfree = xfs_calc_growrtfree_reservation(mp); | 614 | resp->tr_growrtfree = xfs_calc_growrtfree_reservation(mp); |
601 | resp->tr_qm_sbchange = xfs_calc_qm_sbchange_reservation(mp); | 615 | resp->tr_qm_sbchange = xfs_calc_qm_sbchange_reservation(mp); |
602 | resp->tr_qm_setqlim = xfs_calc_qm_setqlim_reservation(mp); | 616 | resp->tr_qm_setqlim = xfs_calc_qm_setqlim_reservation(mp); |
617 | resp->tr_qm_dqalloc = xfs_calc_qm_dqalloc_reservation(mp); | ||
603 | } | 618 | } |
604 | 619 | ||
605 | /* | 620 | /* |
diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h index 93a0ec73c6fe..04575db806d4 100644 --- a/fs/xfs/xfs_trans.h +++ b/fs/xfs/xfs_trans.h | |||
@@ -264,6 +264,7 @@ struct xfs_log_item_desc { | |||
264 | #define XFS_CLEAR_AGI_BUCKET_LOG_RES(mp) ((mp)->m_reservations.tr_clearagi) | 264 | #define XFS_CLEAR_AGI_BUCKET_LOG_RES(mp) ((mp)->m_reservations.tr_clearagi) |
265 | #define XFS_QM_SBCHANGE_LOG_RES(mp) ((mp)->m_reservations.tr_qm_sbchange) | 265 | #define XFS_QM_SBCHANGE_LOG_RES(mp) ((mp)->m_reservations.tr_qm_sbchange) |
266 | #define XFS_QM_SETQLIM_LOG_RES(mp) ((mp)->m_reservations.tr_qm_setqlim) | 266 | #define XFS_QM_SETQLIM_LOG_RES(mp) ((mp)->m_reservations.tr_qm_setqlim) |
267 | #define XFS_QM_DQALLOC_LOG_RES(mp) ((mp)->m_reservations.tr_qm_dqalloc) | ||
267 | 268 | ||
268 | /* | 269 | /* |
269 | * Various log count values. | 270 | * Various log count values. |