diff options
author | Daniel Silverstone <dsilvers@simtec.co.uk> | 2009-03-20 06:11:43 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2009-03-21 07:22:33 -0400 |
commit | 4731f8b66dd34ebf0e67ca6ba9162b0e509bec06 (patch) | |
tree | ed90edbd01863440d57eec206ced1b4cfadcbc40 | |
parent | 65c24491b4fef017c64e39ec64384fde5e05e0a0 (diff) |
[ARM] 5428/1: Module relocation update for R_ARM_V4BX
It would seem when building kernel modules with modern binutils
(required by modern GCC) for ARM v4T targets (specifically observed
with the Samsung 24xx SoC which is an 920T) R_ARM_V4BX relocations
are emitted for function epilogues.
This manifests at module load time with an "unknown relocation: 40"
error message.
The following patch adds the R_ARM_V4BX relocation to the ARM kernel
module loader. The relocation operation is taken from that within the
binutils bfd library.
Signed-off-by: Simtec Linux Team <linux@simtec.co.uk>
Signed-off-by: Vincent Sanders <vince@simtec.co.uk>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r-- | arch/arm/include/asm/elf.h | 1 | ||||
-rw-r--r-- | arch/arm/kernel/module.c | 9 |
2 files changed, 10 insertions, 0 deletions
diff --git a/arch/arm/include/asm/elf.h b/arch/arm/include/asm/elf.h index a58378c343b9..ce3b36e9df81 100644 --- a/arch/arm/include/asm/elf.h +++ b/arch/arm/include/asm/elf.h | |||
@@ -50,6 +50,7 @@ typedef struct user_fp elf_fpregset_t; | |||
50 | #define R_ARM_ABS32 2 | 50 | #define R_ARM_ABS32 2 |
51 | #define R_ARM_CALL 28 | 51 | #define R_ARM_CALL 28 |
52 | #define R_ARM_JUMP24 29 | 52 | #define R_ARM_JUMP24 29 |
53 | #define R_ARM_V4BX 40 | ||
53 | 54 | ||
54 | /* | 55 | /* |
55 | * These are used to set parameters in the core dumps. | 56 | * These are used to set parameters in the core dumps. |
diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c index dab48f27263f..9f509fd00fda 100644 --- a/arch/arm/kernel/module.c +++ b/arch/arm/kernel/module.c | |||
@@ -132,6 +132,15 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex, | |||
132 | *(u32 *)loc |= offset & 0x00ffffff; | 132 | *(u32 *)loc |= offset & 0x00ffffff; |
133 | break; | 133 | break; |
134 | 134 | ||
135 | case R_ARM_V4BX: | ||
136 | /* Preserve Rm and the condition code. Alter | ||
137 | * other bits to re-code instruction as | ||
138 | * MOV PC,Rm. | ||
139 | */ | ||
140 | *(u32 *)loc &= 0xf000000f; | ||
141 | *(u32 *)loc |= 0x01a0f000; | ||
142 | break; | ||
143 | |||
135 | default: | 144 | default: |
136 | printk(KERN_ERR "%s: unknown relocation: %u\n", | 145 | printk(KERN_ERR "%s: unknown relocation: %u\n", |
137 | module->name, ELF32_R_TYPE(rel->r_info)); | 146 | module->name, ELF32_R_TYPE(rel->r_info)); |