diff options
author | Sucheta Chakraborty <sucheta.chakraborty@qlogic.com> | 2014-04-14 10:02:18 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-04-14 13:43:52 -0400 |
commit | 463518a0cbd396aac83ee3d196897d585e173796 (patch) | |
tree | 37cce97e79777e853380d6244e7fe9b2fdd22c9b | |
parent | 677df2f4aefaf9a87f6a37cc38453515547f4bda (diff) |
qlcnic: Fix panic due to uninitialzed delayed_work struct in use.
o AEN event was being received before initializing delayed_work struct
and handlers for it. This was resulting in crash. This patch fixes it.
Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c index b48737dcd3c5..d211af70c7ec 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | |||
@@ -2348,14 +2348,13 @@ int qlcnic_83xx_init(struct qlcnic_adapter *adapter, int pci_using_dac) | |||
2348 | goto disable_intr; | 2348 | goto disable_intr; |
2349 | } | 2349 | } |
2350 | 2350 | ||
2351 | INIT_DELAYED_WORK(&adapter->idc_aen_work, qlcnic_83xx_idc_aen_work); | ||
2352 | |||
2351 | err = qlcnic_83xx_setup_mbx_intr(adapter); | 2353 | err = qlcnic_83xx_setup_mbx_intr(adapter); |
2352 | if (err) | 2354 | if (err) |
2353 | goto disable_mbx_intr; | 2355 | goto disable_mbx_intr; |
2354 | 2356 | ||
2355 | qlcnic_83xx_clear_function_resources(adapter); | 2357 | qlcnic_83xx_clear_function_resources(adapter); |
2356 | |||
2357 | INIT_DELAYED_WORK(&adapter->idc_aen_work, qlcnic_83xx_idc_aen_work); | ||
2358 | |||
2359 | qlcnic_83xx_initialize_nic(adapter, 1); | 2358 | qlcnic_83xx_initialize_nic(adapter, 1); |
2360 | 2359 | ||
2361 | /* Configure default, SR-IOV or Virtual NIC mode of operation */ | 2360 | /* Configure default, SR-IOV or Virtual NIC mode of operation */ |