diff options
author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2013-06-28 07:02:53 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-06-29 00:37:48 -0400 |
commit | 453ca931f515161902dbb325d7f39a992c3059ce (patch) | |
tree | a6f6caf817359113d381fcd8ddc4166ddefea22d | |
parent | bd79680956573dd70bfa207af6b143aa94980b96 (diff) |
pch_gbe: convert pr_* to netdev_*
We may use nice macros to prefix our messages with proper device name.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
6 files changed, 250 insertions, 164 deletions
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h index 7fb7e178c74e..7779036690cc 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | |||
@@ -633,6 +633,8 @@ struct pch_gbe_adapter { | |||
633 | struct pci_dev *ptp_pdev; | 633 | struct pci_dev *ptp_pdev; |
634 | }; | 634 | }; |
635 | 635 | ||
636 | #define pch_gbe_hw_to_adapter(hw) container_of(hw, struct pch_gbe_adapter, hw) | ||
637 | |||
636 | extern const char pch_driver_version[]; | 638 | extern const char pch_driver_version[]; |
637 | 639 | ||
638 | /* pch_gbe_main.c */ | 640 | /* pch_gbe_main.c */ |
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_api.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_api.c index 82e72b21a8fb..ff3ad70935a6 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_api.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_api.c | |||
@@ -71,7 +71,9 @@ static s32 pch_gbe_plat_init_hw(struct pch_gbe_hw *hw) | |||
71 | 71 | ||
72 | ret_val = pch_gbe_phy_get_id(hw); | 72 | ret_val = pch_gbe_phy_get_id(hw); |
73 | if (ret_val) { | 73 | if (ret_val) { |
74 | pr_err("pch_gbe_phy_get_id error\n"); | 74 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
75 | |||
76 | netdev_err(adapter->netdev, "pch_gbe_phy_get_id error\n"); | ||
75 | return ret_val; | 77 | return ret_val; |
76 | } | 78 | } |
77 | pch_gbe_phy_init_setting(hw); | 79 | pch_gbe_phy_init_setting(hw); |
@@ -116,7 +118,9 @@ static void pch_gbe_plat_init_function_pointers(struct pch_gbe_hw *hw) | |||
116 | s32 pch_gbe_hal_setup_init_funcs(struct pch_gbe_hw *hw) | 118 | s32 pch_gbe_hal_setup_init_funcs(struct pch_gbe_hw *hw) |
117 | { | 119 | { |
118 | if (!hw->reg) { | 120 | if (!hw->reg) { |
119 | pr_err("ERROR: Registers not mapped\n"); | 121 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
122 | |||
123 | netdev_err(adapter->netdev, "ERROR: Registers not mapped\n"); | ||
120 | return -ENOSYS; | 124 | return -ENOSYS; |
121 | } | 125 | } |
122 | pch_gbe_plat_init_function_pointers(hw); | 126 | pch_gbe_plat_init_function_pointers(hw); |
@@ -129,10 +133,13 @@ s32 pch_gbe_hal_setup_init_funcs(struct pch_gbe_hw *hw) | |||
129 | */ | 133 | */ |
130 | void pch_gbe_hal_get_bus_info(struct pch_gbe_hw *hw) | 134 | void pch_gbe_hal_get_bus_info(struct pch_gbe_hw *hw) |
131 | { | 135 | { |
132 | if (!hw->func->get_bus_info) | 136 | if (!hw->func->get_bus_info) { |
133 | pr_err("ERROR: configuration\n"); | 137 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
134 | else | 138 | |
135 | hw->func->get_bus_info(hw); | 139 | netdev_err(adapter->netdev, "ERROR: configuration\n"); |
140 | return; | ||
141 | } | ||
142 | hw->func->get_bus_info(hw); | ||
136 | } | 143 | } |
137 | 144 | ||
138 | /** | 145 | /** |
@@ -145,7 +152,9 @@ void pch_gbe_hal_get_bus_info(struct pch_gbe_hw *hw) | |||
145 | s32 pch_gbe_hal_init_hw(struct pch_gbe_hw *hw) | 152 | s32 pch_gbe_hal_init_hw(struct pch_gbe_hw *hw) |
146 | { | 153 | { |
147 | if (!hw->func->init_hw) { | 154 | if (!hw->func->init_hw) { |
148 | pr_err("ERROR: configuration\n"); | 155 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
156 | |||
157 | netdev_err(adapter->netdev, "ERROR: configuration\n"); | ||
149 | return -ENOSYS; | 158 | return -ENOSYS; |
150 | } | 159 | } |
151 | return hw->func->init_hw(hw); | 160 | return hw->func->init_hw(hw); |
@@ -191,10 +200,13 @@ s32 pch_gbe_hal_write_phy_reg(struct pch_gbe_hw *hw, u32 offset, | |||
191 | */ | 200 | */ |
192 | void pch_gbe_hal_phy_hw_reset(struct pch_gbe_hw *hw) | 201 | void pch_gbe_hal_phy_hw_reset(struct pch_gbe_hw *hw) |
193 | { | 202 | { |
194 | if (!hw->func->reset_phy) | 203 | if (!hw->func->reset_phy) { |
195 | pr_err("ERROR: configuration\n"); | 204 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
196 | else | 205 | |
197 | hw->func->reset_phy(hw); | 206 | netdev_err(adapter->netdev, "ERROR: configuration\n"); |
207 | return; | ||
208 | } | ||
209 | hw->func->reset_phy(hw); | ||
198 | } | 210 | } |
199 | 211 | ||
200 | /** | 212 | /** |
@@ -203,10 +215,13 @@ void pch_gbe_hal_phy_hw_reset(struct pch_gbe_hw *hw) | |||
203 | */ | 215 | */ |
204 | void pch_gbe_hal_phy_sw_reset(struct pch_gbe_hw *hw) | 216 | void pch_gbe_hal_phy_sw_reset(struct pch_gbe_hw *hw) |
205 | { | 217 | { |
206 | if (!hw->func->sw_reset_phy) | 218 | if (!hw->func->sw_reset_phy) { |
207 | pr_err("ERROR: configuration\n"); | 219 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
208 | else | 220 | |
209 | hw->func->sw_reset_phy(hw); | 221 | netdev_err(adapter->netdev, "ERROR: configuration\n"); |
222 | return; | ||
223 | } | ||
224 | hw->func->sw_reset_phy(hw); | ||
210 | } | 225 | } |
211 | 226 | ||
212 | /** | 227 | /** |
@@ -219,7 +234,9 @@ void pch_gbe_hal_phy_sw_reset(struct pch_gbe_hw *hw) | |||
219 | s32 pch_gbe_hal_read_mac_addr(struct pch_gbe_hw *hw) | 234 | s32 pch_gbe_hal_read_mac_addr(struct pch_gbe_hw *hw) |
220 | { | 235 | { |
221 | if (!hw->func->read_mac_addr) { | 236 | if (!hw->func->read_mac_addr) { |
222 | pr_err("ERROR: configuration\n"); | 237 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
238 | |||
239 | netdev_err(adapter->netdev, "ERROR: configuration\n"); | ||
223 | return -ENOSYS; | 240 | return -ENOSYS; |
224 | } | 241 | } |
225 | return hw->func->read_mac_addr(hw); | 242 | return hw->func->read_mac_addr(hw); |
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c index 24b787be6062..1129db0cdf82 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | |||
@@ -122,7 +122,7 @@ static int pch_gbe_set_settings(struct net_device *netdev, | |||
122 | } | 122 | } |
123 | ret = mii_ethtool_sset(&adapter->mii, ecmd); | 123 | ret = mii_ethtool_sset(&adapter->mii, ecmd); |
124 | if (ret) { | 124 | if (ret) { |
125 | pr_err("Error: mii_ethtool_sset\n"); | 125 | netdev_err(netdev, "Error: mii_ethtool_sset\n"); |
126 | return ret; | 126 | return ret; |
127 | } | 127 | } |
128 | hw->mac.link_speed = speed; | 128 | hw->mac.link_speed = speed; |
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index 16d5ffac1981..97db56393197 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | |||
@@ -300,6 +300,7 @@ static inline void pch_gbe_mac_load_mac_addr(struct pch_gbe_hw *hw) | |||
300 | */ | 300 | */ |
301 | s32 pch_gbe_mac_read_mac_addr(struct pch_gbe_hw *hw) | 301 | s32 pch_gbe_mac_read_mac_addr(struct pch_gbe_hw *hw) |
302 | { | 302 | { |
303 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); | ||
303 | u32 adr1a, adr1b; | 304 | u32 adr1a, adr1b; |
304 | 305 | ||
305 | adr1a = ioread32(&hw->reg->mac_adr[0].high); | 306 | adr1a = ioread32(&hw->reg->mac_adr[0].high); |
@@ -312,7 +313,7 @@ s32 pch_gbe_mac_read_mac_addr(struct pch_gbe_hw *hw) | |||
312 | hw->mac.addr[4] = (u8)(adr1b & 0xFF); | 313 | hw->mac.addr[4] = (u8)(adr1b & 0xFF); |
313 | hw->mac.addr[5] = (u8)((adr1b >> 8) & 0xFF); | 314 | hw->mac.addr[5] = (u8)((adr1b >> 8) & 0xFF); |
314 | 315 | ||
315 | pr_debug("hw->mac.addr : %pM\n", hw->mac.addr); | 316 | netdev_dbg(adapter->netdev, "hw->mac.addr : %pM\n", hw->mac.addr); |
316 | return 0; | 317 | return 0; |
317 | } | 318 | } |
318 | 319 | ||
@@ -324,6 +325,7 @@ s32 pch_gbe_mac_read_mac_addr(struct pch_gbe_hw *hw) | |||
324 | static void pch_gbe_wait_clr_bit(void *reg, u32 bit) | 325 | static void pch_gbe_wait_clr_bit(void *reg, u32 bit) |
325 | { | 326 | { |
326 | u32 tmp; | 327 | u32 tmp; |
328 | |||
327 | /* wait busy */ | 329 | /* wait busy */ |
328 | tmp = 1000; | 330 | tmp = 1000; |
329 | while ((ioread32(reg) & bit) && --tmp) | 331 | while ((ioread32(reg) & bit) && --tmp) |
@@ -340,9 +342,10 @@ static void pch_gbe_wait_clr_bit(void *reg, u32 bit) | |||
340 | */ | 342 | */ |
341 | static void pch_gbe_mac_mar_set(struct pch_gbe_hw *hw, u8 * addr, u32 index) | 343 | static void pch_gbe_mac_mar_set(struct pch_gbe_hw *hw, u8 * addr, u32 index) |
342 | { | 344 | { |
345 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); | ||
343 | u32 mar_low, mar_high, adrmask; | 346 | u32 mar_low, mar_high, adrmask; |
344 | 347 | ||
345 | pr_debug("index : 0x%x\n", index); | 348 | netdev_dbg(adapter->netdev, "index : 0x%x\n", index); |
346 | 349 | ||
347 | /* | 350 | /* |
348 | * HW expects these in little endian so we reverse the byte order | 351 | * HW expects these in little endian so we reverse the byte order |
@@ -468,10 +471,11 @@ static void pch_gbe_mac_mc_addr_list_update(struct pch_gbe_hw *hw, | |||
468 | */ | 471 | */ |
469 | s32 pch_gbe_mac_force_mac_fc(struct pch_gbe_hw *hw) | 472 | s32 pch_gbe_mac_force_mac_fc(struct pch_gbe_hw *hw) |
470 | { | 473 | { |
474 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); | ||
471 | struct pch_gbe_mac_info *mac = &hw->mac; | 475 | struct pch_gbe_mac_info *mac = &hw->mac; |
472 | u32 rx_fctrl; | 476 | u32 rx_fctrl; |
473 | 477 | ||
474 | pr_debug("mac->fc = %u\n", mac->fc); | 478 | netdev_dbg(adapter->netdev, "mac->fc = %u\n", mac->fc); |
475 | 479 | ||
476 | rx_fctrl = ioread32(&hw->reg->RX_FCTRL); | 480 | rx_fctrl = ioread32(&hw->reg->RX_FCTRL); |
477 | 481 | ||
@@ -493,14 +497,16 @@ s32 pch_gbe_mac_force_mac_fc(struct pch_gbe_hw *hw) | |||
493 | mac->tx_fc_enable = true; | 497 | mac->tx_fc_enable = true; |
494 | break; | 498 | break; |
495 | default: | 499 | default: |
496 | pr_err("Flow control param set incorrectly\n"); | 500 | netdev_err(adapter->netdev, |
501 | "Flow control param set incorrectly\n"); | ||
497 | return -EINVAL; | 502 | return -EINVAL; |
498 | } | 503 | } |
499 | if (mac->link_duplex == DUPLEX_HALF) | 504 | if (mac->link_duplex == DUPLEX_HALF) |
500 | rx_fctrl &= ~PCH_GBE_FL_CTRL_EN; | 505 | rx_fctrl &= ~PCH_GBE_FL_CTRL_EN; |
501 | iowrite32(rx_fctrl, &hw->reg->RX_FCTRL); | 506 | iowrite32(rx_fctrl, &hw->reg->RX_FCTRL); |
502 | pr_debug("RX_FCTRL reg : 0x%08x mac->tx_fc_enable : %d\n", | 507 | netdev_dbg(adapter->netdev, |
503 | ioread32(&hw->reg->RX_FCTRL), mac->tx_fc_enable); | 508 | "RX_FCTRL reg : 0x%08x mac->tx_fc_enable : %d\n", |
509 | ioread32(&hw->reg->RX_FCTRL), mac->tx_fc_enable); | ||
504 | return 0; | 510 | return 0; |
505 | } | 511 | } |
506 | 512 | ||
@@ -511,10 +517,11 @@ s32 pch_gbe_mac_force_mac_fc(struct pch_gbe_hw *hw) | |||
511 | */ | 517 | */ |
512 | static void pch_gbe_mac_set_wol_event(struct pch_gbe_hw *hw, u32 wu_evt) | 518 | static void pch_gbe_mac_set_wol_event(struct pch_gbe_hw *hw, u32 wu_evt) |
513 | { | 519 | { |
520 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); | ||
514 | u32 addr_mask; | 521 | u32 addr_mask; |
515 | 522 | ||
516 | pr_debug("wu_evt : 0x%08x ADDR_MASK reg : 0x%08x\n", | 523 | netdev_dbg(adapter->netdev, "wu_evt : 0x%08x ADDR_MASK reg : 0x%08x\n", |
517 | wu_evt, ioread32(&hw->reg->ADDR_MASK)); | 524 | wu_evt, ioread32(&hw->reg->ADDR_MASK)); |
518 | 525 | ||
519 | if (wu_evt) { | 526 | if (wu_evt) { |
520 | /* Set Wake-On-Lan address mask */ | 527 | /* Set Wake-On-Lan address mask */ |
@@ -546,6 +553,7 @@ static void pch_gbe_mac_set_wol_event(struct pch_gbe_hw *hw, u32 wu_evt) | |||
546 | u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg, | 553 | u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg, |
547 | u16 data) | 554 | u16 data) |
548 | { | 555 | { |
556 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); | ||
549 | u32 data_out = 0; | 557 | u32 data_out = 0; |
550 | unsigned int i; | 558 | unsigned int i; |
551 | unsigned long flags; | 559 | unsigned long flags; |
@@ -558,7 +566,7 @@ u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg, | |||
558 | udelay(20); | 566 | udelay(20); |
559 | } | 567 | } |
560 | if (i == 0) { | 568 | if (i == 0) { |
561 | pr_err("pch-gbe.miim won't go Ready\n"); | 569 | netdev_err(adapter->netdev, "pch-gbe.miim won't go Ready\n"); |
562 | spin_unlock_irqrestore(&hw->miim_lock, flags); | 570 | spin_unlock_irqrestore(&hw->miim_lock, flags); |
563 | return 0; /* No way to indicate timeout error */ | 571 | return 0; /* No way to indicate timeout error */ |
564 | } | 572 | } |
@@ -573,9 +581,9 @@ u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg, | |||
573 | } | 581 | } |
574 | spin_unlock_irqrestore(&hw->miim_lock, flags); | 582 | spin_unlock_irqrestore(&hw->miim_lock, flags); |
575 | 583 | ||
576 | pr_debug("PHY %s: reg=%d, data=0x%04X\n", | 584 | netdev_dbg(adapter->netdev, "PHY %s: reg=%d, data=0x%04X\n", |
577 | dir == PCH_GBE_MIIM_OPER_READ ? "READ" : "WRITE", reg, | 585 | dir == PCH_GBE_MIIM_OPER_READ ? "READ" : "WRITE", reg, |
578 | dir == PCH_GBE_MIIM_OPER_READ ? data_out : data); | 586 | dir == PCH_GBE_MIIM_OPER_READ ? data_out : data); |
579 | return (u16) data_out; | 587 | return (u16) data_out; |
580 | } | 588 | } |
581 | 589 | ||
@@ -585,6 +593,7 @@ u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg, | |||
585 | */ | 593 | */ |
586 | static void pch_gbe_mac_set_pause_packet(struct pch_gbe_hw *hw) | 594 | static void pch_gbe_mac_set_pause_packet(struct pch_gbe_hw *hw) |
587 | { | 595 | { |
596 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); | ||
588 | unsigned long tmp2, tmp3; | 597 | unsigned long tmp2, tmp3; |
589 | 598 | ||
590 | /* Set Pause packet */ | 599 | /* Set Pause packet */ |
@@ -606,10 +615,13 @@ static void pch_gbe_mac_set_pause_packet(struct pch_gbe_hw *hw) | |||
606 | /* Transmit Pause Packet */ | 615 | /* Transmit Pause Packet */ |
607 | iowrite32(PCH_GBE_PS_PKT_RQ, &hw->reg->PAUSE_REQ); | 616 | iowrite32(PCH_GBE_PS_PKT_RQ, &hw->reg->PAUSE_REQ); |
608 | 617 | ||
609 | pr_debug("PAUSE_PKT1-5 reg : 0x%08x 0x%08x 0x%08x 0x%08x 0x%08x\n", | 618 | netdev_dbg(adapter->netdev, |
610 | ioread32(&hw->reg->PAUSE_PKT1), ioread32(&hw->reg->PAUSE_PKT2), | 619 | "PAUSE_PKT1-5 reg : 0x%08x 0x%08x 0x%08x 0x%08x 0x%08x\n", |
611 | ioread32(&hw->reg->PAUSE_PKT3), ioread32(&hw->reg->PAUSE_PKT4), | 620 | ioread32(&hw->reg->PAUSE_PKT1), |
612 | ioread32(&hw->reg->PAUSE_PKT5)); | 621 | ioread32(&hw->reg->PAUSE_PKT2), |
622 | ioread32(&hw->reg->PAUSE_PKT3), | ||
623 | ioread32(&hw->reg->PAUSE_PKT4), | ||
624 | ioread32(&hw->reg->PAUSE_PKT5)); | ||
613 | 625 | ||
614 | return; | 626 | return; |
615 | } | 627 | } |
@@ -669,7 +681,7 @@ static int pch_gbe_init_phy(struct pch_gbe_adapter *adapter) | |||
669 | break; | 681 | break; |
670 | } | 682 | } |
671 | adapter->hw.phy.addr = adapter->mii.phy_id; | 683 | adapter->hw.phy.addr = adapter->mii.phy_id; |
672 | pr_debug("phy_addr = %d\n", adapter->mii.phy_id); | 684 | netdev_dbg(netdev, "phy_addr = %d\n", adapter->mii.phy_id); |
673 | if (addr == 32) | 685 | if (addr == 32) |
674 | return -EAGAIN; | 686 | return -EAGAIN; |
675 | /* Selected the phy and isolate the rest */ | 687 | /* Selected the phy and isolate the rest */ |
@@ -758,13 +770,15 @@ void pch_gbe_reinit_locked(struct pch_gbe_adapter *adapter) | |||
758 | */ | 770 | */ |
759 | void pch_gbe_reset(struct pch_gbe_adapter *adapter) | 771 | void pch_gbe_reset(struct pch_gbe_adapter *adapter) |
760 | { | 772 | { |
773 | struct net_device *netdev = adapter->netdev; | ||
774 | |||
761 | pch_gbe_mac_reset_hw(&adapter->hw); | 775 | pch_gbe_mac_reset_hw(&adapter->hw); |
762 | /* reprogram multicast address register after reset */ | 776 | /* reprogram multicast address register after reset */ |
763 | pch_gbe_set_multi(adapter->netdev); | 777 | pch_gbe_set_multi(netdev); |
764 | /* Setup the receive address. */ | 778 | /* Setup the receive address. */ |
765 | pch_gbe_mac_init_rx_addrs(&adapter->hw, PCH_GBE_MAR_ENTRIES); | 779 | pch_gbe_mac_init_rx_addrs(&adapter->hw, PCH_GBE_MAR_ENTRIES); |
766 | if (pch_gbe_hal_init_hw(&adapter->hw)) | 780 | if (pch_gbe_hal_init_hw(&adapter->hw)) |
767 | pr_err("Hardware Error\n"); | 781 | netdev_err(netdev, "Hardware Error\n"); |
768 | } | 782 | } |
769 | 783 | ||
770 | /** | 784 | /** |
@@ -778,7 +792,7 @@ static void pch_gbe_free_irq(struct pch_gbe_adapter *adapter) | |||
778 | free_irq(adapter->pdev->irq, netdev); | 792 | free_irq(adapter->pdev->irq, netdev); |
779 | if (adapter->have_msi) { | 793 | if (adapter->have_msi) { |
780 | pci_disable_msi(adapter->pdev); | 794 | pci_disable_msi(adapter->pdev); |
781 | pr_debug("call pci_disable_msi\n"); | 795 | netdev_dbg(netdev, "call pci_disable_msi\n"); |
782 | } | 796 | } |
783 | } | 797 | } |
784 | 798 | ||
@@ -795,7 +809,8 @@ static void pch_gbe_irq_disable(struct pch_gbe_adapter *adapter) | |||
795 | ioread32(&hw->reg->INT_ST); | 809 | ioread32(&hw->reg->INT_ST); |
796 | synchronize_irq(adapter->pdev->irq); | 810 | synchronize_irq(adapter->pdev->irq); |
797 | 811 | ||
798 | pr_debug("INT_EN reg : 0x%08x\n", ioread32(&hw->reg->INT_EN)); | 812 | netdev_dbg(adapter->netdev, "INT_EN reg : 0x%08x\n", |
813 | ioread32(&hw->reg->INT_EN)); | ||
799 | } | 814 | } |
800 | 815 | ||
801 | /** | 816 | /** |
@@ -809,7 +824,8 @@ static void pch_gbe_irq_enable(struct pch_gbe_adapter *adapter) | |||
809 | if (likely(atomic_dec_and_test(&adapter->irq_sem))) | 824 | if (likely(atomic_dec_and_test(&adapter->irq_sem))) |
810 | iowrite32(PCH_GBE_INT_ENABLE_MASK, &hw->reg->INT_EN); | 825 | iowrite32(PCH_GBE_INT_ENABLE_MASK, &hw->reg->INT_EN); |
811 | ioread32(&hw->reg->INT_ST); | 826 | ioread32(&hw->reg->INT_ST); |
812 | pr_debug("INT_EN reg : 0x%08x\n", ioread32(&hw->reg->INT_EN)); | 827 | netdev_dbg(adapter->netdev, "INT_EN reg : 0x%08x\n", |
828 | ioread32(&hw->reg->INT_EN)); | ||
813 | } | 829 | } |
814 | 830 | ||
815 | 831 | ||
@@ -846,9 +862,9 @@ static void pch_gbe_configure_tx(struct pch_gbe_adapter *adapter) | |||
846 | struct pch_gbe_hw *hw = &adapter->hw; | 862 | struct pch_gbe_hw *hw = &adapter->hw; |
847 | u32 tdba, tdlen, dctrl; | 863 | u32 tdba, tdlen, dctrl; |
848 | 864 | ||
849 | pr_debug("dma addr = 0x%08llx size = 0x%08x\n", | 865 | netdev_dbg(adapter->netdev, "dma addr = 0x%08llx size = 0x%08x\n", |
850 | (unsigned long long)adapter->tx_ring->dma, | 866 | (unsigned long long)adapter->tx_ring->dma, |
851 | adapter->tx_ring->size); | 867 | adapter->tx_ring->size); |
852 | 868 | ||
853 | /* Setup the HW Tx Head and Tail descriptor pointers */ | 869 | /* Setup the HW Tx Head and Tail descriptor pointers */ |
854 | tdba = adapter->tx_ring->dma; | 870 | tdba = adapter->tx_ring->dma; |
@@ -894,9 +910,9 @@ static void pch_gbe_configure_rx(struct pch_gbe_adapter *adapter) | |||
894 | struct pch_gbe_hw *hw = &adapter->hw; | 910 | struct pch_gbe_hw *hw = &adapter->hw; |
895 | u32 rdba, rdlen, rxdma; | 911 | u32 rdba, rdlen, rxdma; |
896 | 912 | ||
897 | pr_debug("dma adr = 0x%08llx size = 0x%08x\n", | 913 | netdev_dbg(adapter->netdev, "dma adr = 0x%08llx size = 0x%08x\n", |
898 | (unsigned long long)adapter->rx_ring->dma, | 914 | (unsigned long long)adapter->rx_ring->dma, |
899 | adapter->rx_ring->size); | 915 | adapter->rx_ring->size); |
900 | 916 | ||
901 | pch_gbe_mac_force_mac_fc(hw); | 917 | pch_gbe_mac_force_mac_fc(hw); |
902 | 918 | ||
@@ -907,9 +923,10 @@ static void pch_gbe_configure_rx(struct pch_gbe_adapter *adapter) | |||
907 | rxdma &= ~PCH_GBE_RX_DMA_EN; | 923 | rxdma &= ~PCH_GBE_RX_DMA_EN; |
908 | iowrite32(rxdma, &hw->reg->DMA_CTRL); | 924 | iowrite32(rxdma, &hw->reg->DMA_CTRL); |
909 | 925 | ||
910 | pr_debug("MAC_RX_EN reg = 0x%08x DMA_CTRL reg = 0x%08x\n", | 926 | netdev_dbg(adapter->netdev, |
911 | ioread32(&hw->reg->MAC_RX_EN), | 927 | "MAC_RX_EN reg = 0x%08x DMA_CTRL reg = 0x%08x\n", |
912 | ioread32(&hw->reg->DMA_CTRL)); | 928 | ioread32(&hw->reg->MAC_RX_EN), |
929 | ioread32(&hw->reg->DMA_CTRL)); | ||
913 | 930 | ||
914 | /* Setup the HW Rx Head and Tail Descriptor Pointers and | 931 | /* Setup the HW Rx Head and Tail Descriptor Pointers and |
915 | * the Base and Length of the Rx Descriptor Ring */ | 932 | * the Base and Length of the Rx Descriptor Ring */ |
@@ -977,7 +994,8 @@ static void pch_gbe_clean_tx_ring(struct pch_gbe_adapter *adapter, | |||
977 | buffer_info = &tx_ring->buffer_info[i]; | 994 | buffer_info = &tx_ring->buffer_info[i]; |
978 | pch_gbe_unmap_and_free_tx_resource(adapter, buffer_info); | 995 | pch_gbe_unmap_and_free_tx_resource(adapter, buffer_info); |
979 | } | 996 | } |
980 | pr_debug("call pch_gbe_unmap_and_free_tx_resource() %d count\n", i); | 997 | netdev_dbg(adapter->netdev, |
998 | "call pch_gbe_unmap_and_free_tx_resource() %d count\n", i); | ||
981 | 999 | ||
982 | size = (unsigned long)sizeof(struct pch_gbe_buffer) * tx_ring->count; | 1000 | size = (unsigned long)sizeof(struct pch_gbe_buffer) * tx_ring->count; |
983 | memset(tx_ring->buffer_info, 0, size); | 1001 | memset(tx_ring->buffer_info, 0, size); |
@@ -1009,7 +1027,8 @@ pch_gbe_clean_rx_ring(struct pch_gbe_adapter *adapter, | |||
1009 | buffer_info = &rx_ring->buffer_info[i]; | 1027 | buffer_info = &rx_ring->buffer_info[i]; |
1010 | pch_gbe_unmap_and_free_rx_resource(adapter, buffer_info); | 1028 | pch_gbe_unmap_and_free_rx_resource(adapter, buffer_info); |
1011 | } | 1029 | } |
1012 | pr_debug("call pch_gbe_unmap_and_free_rx_resource() %d count\n", i); | 1030 | netdev_dbg(adapter->netdev, |
1031 | "call pch_gbe_unmap_and_free_rx_resource() %d count\n", i); | ||
1013 | size = (unsigned long)sizeof(struct pch_gbe_buffer) * rx_ring->count; | 1032 | size = (unsigned long)sizeof(struct pch_gbe_buffer) * rx_ring->count; |
1014 | memset(rx_ring->buffer_info, 0, size); | 1033 | memset(rx_ring->buffer_info, 0, size); |
1015 | 1034 | ||
@@ -1087,7 +1106,7 @@ static void pch_gbe_watchdog(unsigned long data) | |||
1087 | struct net_device *netdev = adapter->netdev; | 1106 | struct net_device *netdev = adapter->netdev; |
1088 | struct pch_gbe_hw *hw = &adapter->hw; | 1107 | struct pch_gbe_hw *hw = &adapter->hw; |
1089 | 1108 | ||
1090 | pr_debug("right now = %ld\n", jiffies); | 1109 | netdev_dbg(netdev, "right now = %ld\n", jiffies); |
1091 | 1110 | ||
1092 | pch_gbe_update_stats(adapter); | 1111 | pch_gbe_update_stats(adapter); |
1093 | if ((mii_link_ok(&adapter->mii)) && (!netif_carrier_ok(netdev))) { | 1112 | if ((mii_link_ok(&adapter->mii)) && (!netif_carrier_ok(netdev))) { |
@@ -1095,7 +1114,7 @@ static void pch_gbe_watchdog(unsigned long data) | |||
1095 | netdev->tx_queue_len = adapter->tx_queue_len; | 1114 | netdev->tx_queue_len = adapter->tx_queue_len; |
1096 | /* mii library handles link maintenance tasks */ | 1115 | /* mii library handles link maintenance tasks */ |
1097 | if (mii_ethtool_gset(&adapter->mii, &cmd)) { | 1116 | if (mii_ethtool_gset(&adapter->mii, &cmd)) { |
1098 | pr_err("ethtool get setting Error\n"); | 1117 | netdev_err(netdev, "ethtool get setting Error\n"); |
1099 | mod_timer(&adapter->watchdog_timer, | 1118 | mod_timer(&adapter->watchdog_timer, |
1100 | round_jiffies(jiffies + | 1119 | round_jiffies(jiffies + |
1101 | PCH_GBE_WATCHDOG_PERIOD)); | 1120 | PCH_GBE_WATCHDOG_PERIOD)); |
@@ -1213,7 +1232,7 @@ static void pch_gbe_tx_queue(struct pch_gbe_adapter *adapter, | |||
1213 | buffer_info->length, | 1232 | buffer_info->length, |
1214 | DMA_TO_DEVICE); | 1233 | DMA_TO_DEVICE); |
1215 | if (dma_mapping_error(&adapter->pdev->dev, buffer_info->dma)) { | 1234 | if (dma_mapping_error(&adapter->pdev->dev, buffer_info->dma)) { |
1216 | pr_err("TX DMA map failed\n"); | 1235 | netdev_err(adapter->netdev, "TX DMA map failed\n"); |
1217 | buffer_info->dma = 0; | 1236 | buffer_info->dma = 0; |
1218 | buffer_info->time_stamp = 0; | 1237 | buffer_info->time_stamp = 0; |
1219 | tx_ring->next_to_use = ring_num; | 1238 | tx_ring->next_to_use = ring_num; |
@@ -1333,13 +1352,13 @@ static irqreturn_t pch_gbe_intr(int irq, void *data) | |||
1333 | /* When request status is no interruption factor */ | 1352 | /* When request status is no interruption factor */ |
1334 | if (unlikely(!int_st)) | 1353 | if (unlikely(!int_st)) |
1335 | return IRQ_NONE; /* Not our interrupt. End processing. */ | 1354 | return IRQ_NONE; /* Not our interrupt. End processing. */ |
1336 | pr_debug("%s occur int_st = 0x%08x\n", __func__, int_st); | 1355 | netdev_dbg(netdev, "%s occur int_st = 0x%08x\n", __func__, int_st); |
1337 | if (int_st & PCH_GBE_INT_RX_FRAME_ERR) | 1356 | if (int_st & PCH_GBE_INT_RX_FRAME_ERR) |
1338 | adapter->stats.intr_rx_frame_err_count++; | 1357 | adapter->stats.intr_rx_frame_err_count++; |
1339 | if (int_st & PCH_GBE_INT_RX_FIFO_ERR) | 1358 | if (int_st & PCH_GBE_INT_RX_FIFO_ERR) |
1340 | if (!adapter->rx_stop_flag) { | 1359 | if (!adapter->rx_stop_flag) { |
1341 | adapter->stats.intr_rx_fifo_err_count++; | 1360 | adapter->stats.intr_rx_fifo_err_count++; |
1342 | pr_debug("Rx fifo over run\n"); | 1361 | netdev_dbg(netdev, "Rx fifo over run\n"); |
1343 | adapter->rx_stop_flag = true; | 1362 | adapter->rx_stop_flag = true; |
1344 | int_en = ioread32(&hw->reg->INT_EN); | 1363 | int_en = ioread32(&hw->reg->INT_EN); |
1345 | iowrite32((int_en & ~PCH_GBE_INT_RX_FIFO_ERR), | 1364 | iowrite32((int_en & ~PCH_GBE_INT_RX_FIFO_ERR), |
@@ -1359,7 +1378,7 @@ static irqreturn_t pch_gbe_intr(int irq, void *data) | |||
1359 | /* When Rx descriptor is empty */ | 1378 | /* When Rx descriptor is empty */ |
1360 | if ((int_st & PCH_GBE_INT_RX_DSC_EMP)) { | 1379 | if ((int_st & PCH_GBE_INT_RX_DSC_EMP)) { |
1361 | adapter->stats.intr_rx_dsc_empty_count++; | 1380 | adapter->stats.intr_rx_dsc_empty_count++; |
1362 | pr_debug("Rx descriptor is empty\n"); | 1381 | netdev_dbg(netdev, "Rx descriptor is empty\n"); |
1363 | int_en = ioread32(&hw->reg->INT_EN); | 1382 | int_en = ioread32(&hw->reg->INT_EN); |
1364 | iowrite32((int_en & ~PCH_GBE_INT_RX_DSC_EMP), &hw->reg->INT_EN); | 1383 | iowrite32((int_en & ~PCH_GBE_INT_RX_DSC_EMP), &hw->reg->INT_EN); |
1365 | if (hw->mac.tx_fc_enable) { | 1384 | if (hw->mac.tx_fc_enable) { |
@@ -1382,8 +1401,8 @@ static irqreturn_t pch_gbe_intr(int irq, void *data) | |||
1382 | __napi_schedule(&adapter->napi); | 1401 | __napi_schedule(&adapter->napi); |
1383 | } | 1402 | } |
1384 | } | 1403 | } |
1385 | pr_debug("return = 0x%08x INT_EN reg = 0x%08x\n", | 1404 | netdev_dbg(netdev, "return = 0x%08x INT_EN reg = 0x%08x\n", |
1386 | IRQ_HANDLED, ioread32(&hw->reg->INT_EN)); | 1405 | IRQ_HANDLED, ioread32(&hw->reg->INT_EN)); |
1387 | return IRQ_HANDLED; | 1406 | return IRQ_HANDLED; |
1388 | } | 1407 | } |
1389 | 1408 | ||
@@ -1437,9 +1456,10 @@ pch_gbe_alloc_rx_buffers(struct pch_gbe_adapter *adapter, | |||
1437 | rx_desc->buffer_addr = (buffer_info->dma); | 1456 | rx_desc->buffer_addr = (buffer_info->dma); |
1438 | rx_desc->gbec_status = DSC_INIT16; | 1457 | rx_desc->gbec_status = DSC_INIT16; |
1439 | 1458 | ||
1440 | pr_debug("i = %d buffer_info->dma = 0x08%llx buffer_info->length = 0x%x\n", | 1459 | netdev_dbg(netdev, |
1441 | i, (unsigned long long)buffer_info->dma, | 1460 | "i = %d buffer_info->dma = 0x08%llx buffer_info->length = 0x%x\n", |
1442 | buffer_info->length); | 1461 | i, (unsigned long long)buffer_info->dma, |
1462 | buffer_info->length); | ||
1443 | 1463 | ||
1444 | if (unlikely(++i == rx_ring->count)) | 1464 | if (unlikely(++i == rx_ring->count)) |
1445 | i = 0; | 1465 | i = 0; |
@@ -1531,12 +1551,13 @@ pch_gbe_clean_tx(struct pch_gbe_adapter *adapter, | |||
1531 | bool cleaned = false; | 1551 | bool cleaned = false; |
1532 | int unused, thresh; | 1552 | int unused, thresh; |
1533 | 1553 | ||
1534 | pr_debug("next_to_clean : %d\n", tx_ring->next_to_clean); | 1554 | netdev_dbg(adapter->netdev, "next_to_clean : %d\n", |
1555 | tx_ring->next_to_clean); | ||
1535 | 1556 | ||
1536 | i = tx_ring->next_to_clean; | 1557 | i = tx_ring->next_to_clean; |
1537 | tx_desc = PCH_GBE_TX_DESC(*tx_ring, i); | 1558 | tx_desc = PCH_GBE_TX_DESC(*tx_ring, i); |
1538 | pr_debug("gbec_status:0x%04x dma_status:0x%04x\n", | 1559 | netdev_dbg(adapter->netdev, "gbec_status:0x%04x dma_status:0x%04x\n", |
1539 | tx_desc->gbec_status, tx_desc->dma_status); | 1560 | tx_desc->gbec_status, tx_desc->dma_status); |
1540 | 1561 | ||
1541 | unused = PCH_GBE_DESC_UNUSED(tx_ring); | 1562 | unused = PCH_GBE_DESC_UNUSED(tx_ring); |
1542 | thresh = tx_ring->count - PCH_GBE_TX_WEIGHT; | 1563 | thresh = tx_ring->count - PCH_GBE_TX_WEIGHT; |
@@ -1544,8 +1565,10 @@ pch_gbe_clean_tx(struct pch_gbe_adapter *adapter, | |||
1544 | { /* current marked clean, tx queue filling up, do extra clean */ | 1565 | { /* current marked clean, tx queue filling up, do extra clean */ |
1545 | int j, k; | 1566 | int j, k; |
1546 | if (unused < 8) { /* tx queue nearly full */ | 1567 | if (unused < 8) { /* tx queue nearly full */ |
1547 | pr_debug("clean_tx: transmit queue warning (%x,%x) unused=%d\n", | 1568 | netdev_dbg(adapter->netdev, |
1548 | tx_ring->next_to_clean,tx_ring->next_to_use,unused); | 1569 | "clean_tx: transmit queue warning (%x,%x) unused=%d\n", |
1570 | tx_ring->next_to_clean, tx_ring->next_to_use, | ||
1571 | unused); | ||
1549 | } | 1572 | } |
1550 | 1573 | ||
1551 | /* current marked clean, scan for more that need cleaning. */ | 1574 | /* current marked clean, scan for more that need cleaning. */ |
@@ -1557,49 +1580,56 @@ pch_gbe_clean_tx(struct pch_gbe_adapter *adapter, | |||
1557 | if (++k >= tx_ring->count) k = 0; /*increment, wrap*/ | 1580 | if (++k >= tx_ring->count) k = 0; /*increment, wrap*/ |
1558 | } | 1581 | } |
1559 | if (j < PCH_GBE_TX_WEIGHT) { | 1582 | if (j < PCH_GBE_TX_WEIGHT) { |
1560 | pr_debug("clean_tx: unused=%d loops=%d found tx_desc[%x,%x:%x].gbec_status=%04x\n", | 1583 | netdev_dbg(adapter->netdev, |
1561 | unused,j, i,k, tx_ring->next_to_use, tx_desc->gbec_status); | 1584 | "clean_tx: unused=%d loops=%d found tx_desc[%x,%x:%x].gbec_status=%04x\n", |
1585 | unused, j, i, k, tx_ring->next_to_use, | ||
1586 | tx_desc->gbec_status); | ||
1562 | i = k; /*found one to clean, usu gbec_status==2000.*/ | 1587 | i = k; /*found one to clean, usu gbec_status==2000.*/ |
1563 | } | 1588 | } |
1564 | } | 1589 | } |
1565 | 1590 | ||
1566 | while ((tx_desc->gbec_status & DSC_INIT16) == 0x0000) { | 1591 | while ((tx_desc->gbec_status & DSC_INIT16) == 0x0000) { |
1567 | pr_debug("gbec_status:0x%04x\n", tx_desc->gbec_status); | 1592 | netdev_dbg(adapter->netdev, "gbec_status:0x%04x\n", |
1593 | tx_desc->gbec_status); | ||
1568 | buffer_info = &tx_ring->buffer_info[i]; | 1594 | buffer_info = &tx_ring->buffer_info[i]; |
1569 | skb = buffer_info->skb; | 1595 | skb = buffer_info->skb; |
1570 | cleaned = true; | 1596 | cleaned = true; |
1571 | 1597 | ||
1572 | if ((tx_desc->gbec_status & PCH_GBE_TXD_GMAC_STAT_ABT)) { | 1598 | if ((tx_desc->gbec_status & PCH_GBE_TXD_GMAC_STAT_ABT)) { |
1573 | adapter->stats.tx_aborted_errors++; | 1599 | adapter->stats.tx_aborted_errors++; |
1574 | pr_err("Transfer Abort Error\n"); | 1600 | netdev_err(adapter->netdev, "Transfer Abort Error\n"); |
1575 | } else if ((tx_desc->gbec_status & PCH_GBE_TXD_GMAC_STAT_CRSER) | 1601 | } else if ((tx_desc->gbec_status & PCH_GBE_TXD_GMAC_STAT_CRSER) |
1576 | ) { | 1602 | ) { |
1577 | adapter->stats.tx_carrier_errors++; | 1603 | adapter->stats.tx_carrier_errors++; |
1578 | pr_err("Transfer Carrier Sense Error\n"); | 1604 | netdev_err(adapter->netdev, |
1605 | "Transfer Carrier Sense Error\n"); | ||
1579 | } else if ((tx_desc->gbec_status & PCH_GBE_TXD_GMAC_STAT_EXCOL) | 1606 | } else if ((tx_desc->gbec_status & PCH_GBE_TXD_GMAC_STAT_EXCOL) |
1580 | ) { | 1607 | ) { |
1581 | adapter->stats.tx_aborted_errors++; | 1608 | adapter->stats.tx_aborted_errors++; |
1582 | pr_err("Transfer Collision Abort Error\n"); | 1609 | netdev_err(adapter->netdev, |
1610 | "Transfer Collision Abort Error\n"); | ||
1583 | } else if ((tx_desc->gbec_status & | 1611 | } else if ((tx_desc->gbec_status & |
1584 | (PCH_GBE_TXD_GMAC_STAT_SNGCOL | | 1612 | (PCH_GBE_TXD_GMAC_STAT_SNGCOL | |
1585 | PCH_GBE_TXD_GMAC_STAT_MLTCOL))) { | 1613 | PCH_GBE_TXD_GMAC_STAT_MLTCOL))) { |
1586 | adapter->stats.collisions++; | 1614 | adapter->stats.collisions++; |
1587 | adapter->stats.tx_packets++; | 1615 | adapter->stats.tx_packets++; |
1588 | adapter->stats.tx_bytes += skb->len; | 1616 | adapter->stats.tx_bytes += skb->len; |
1589 | pr_debug("Transfer Collision\n"); | 1617 | netdev_dbg(adapter->netdev, "Transfer Collision\n"); |
1590 | } else if ((tx_desc->gbec_status & PCH_GBE_TXD_GMAC_STAT_CMPLT) | 1618 | } else if ((tx_desc->gbec_status & PCH_GBE_TXD_GMAC_STAT_CMPLT) |
1591 | ) { | 1619 | ) { |
1592 | adapter->stats.tx_packets++; | 1620 | adapter->stats.tx_packets++; |
1593 | adapter->stats.tx_bytes += skb->len; | 1621 | adapter->stats.tx_bytes += skb->len; |
1594 | } | 1622 | } |
1595 | if (buffer_info->mapped) { | 1623 | if (buffer_info->mapped) { |
1596 | pr_debug("unmap buffer_info->dma : %d\n", i); | 1624 | netdev_dbg(adapter->netdev, |
1625 | "unmap buffer_info->dma : %d\n", i); | ||
1597 | dma_unmap_single(&adapter->pdev->dev, buffer_info->dma, | 1626 | dma_unmap_single(&adapter->pdev->dev, buffer_info->dma, |
1598 | buffer_info->length, DMA_TO_DEVICE); | 1627 | buffer_info->length, DMA_TO_DEVICE); |
1599 | buffer_info->mapped = false; | 1628 | buffer_info->mapped = false; |
1600 | } | 1629 | } |
1601 | if (buffer_info->skb) { | 1630 | if (buffer_info->skb) { |
1602 | pr_debug("trim buffer_info->skb : %d\n", i); | 1631 | netdev_dbg(adapter->netdev, |
1632 | "trim buffer_info->skb : %d\n", i); | ||
1603 | skb_trim(buffer_info->skb, 0); | 1633 | skb_trim(buffer_info->skb, 0); |
1604 | } | 1634 | } |
1605 | tx_desc->gbec_status = DSC_INIT16; | 1635 | tx_desc->gbec_status = DSC_INIT16; |
@@ -1613,8 +1643,9 @@ pch_gbe_clean_tx(struct pch_gbe_adapter *adapter, | |||
1613 | break; | 1643 | break; |
1614 | } | 1644 | } |
1615 | } | 1645 | } |
1616 | pr_debug("called pch_gbe_unmap_and_free_tx_resource() %d count\n", | 1646 | netdev_dbg(adapter->netdev, |
1617 | cleaned_count); | 1647 | "called pch_gbe_unmap_and_free_tx_resource() %d count\n", |
1648 | cleaned_count); | ||
1618 | if (cleaned_count > 0) { /*skip this if nothing cleaned*/ | 1649 | if (cleaned_count > 0) { /*skip this if nothing cleaned*/ |
1619 | /* Recover from running out of Tx resources in xmit_frame */ | 1650 | /* Recover from running out of Tx resources in xmit_frame */ |
1620 | spin_lock(&tx_ring->tx_lock); | 1651 | spin_lock(&tx_ring->tx_lock); |
@@ -1622,12 +1653,13 @@ pch_gbe_clean_tx(struct pch_gbe_adapter *adapter, | |||
1622 | { | 1653 | { |
1623 | netif_wake_queue(adapter->netdev); | 1654 | netif_wake_queue(adapter->netdev); |
1624 | adapter->stats.tx_restart_count++; | 1655 | adapter->stats.tx_restart_count++; |
1625 | pr_debug("Tx wake queue\n"); | 1656 | netdev_dbg(adapter->netdev, "Tx wake queue\n"); |
1626 | } | 1657 | } |
1627 | 1658 | ||
1628 | tx_ring->next_to_clean = i; | 1659 | tx_ring->next_to_clean = i; |
1629 | 1660 | ||
1630 | pr_debug("next_to_clean : %d\n", tx_ring->next_to_clean); | 1661 | netdev_dbg(adapter->netdev, "next_to_clean : %d\n", |
1662 | tx_ring->next_to_clean); | ||
1631 | spin_unlock(&tx_ring->tx_lock); | 1663 | spin_unlock(&tx_ring->tx_lock); |
1632 | } | 1664 | } |
1633 | return cleaned; | 1665 | return cleaned; |
@@ -1684,22 +1716,22 @@ pch_gbe_clean_rx(struct pch_gbe_adapter *adapter, | |||
1684 | buffer_info->length, DMA_FROM_DEVICE); | 1716 | buffer_info->length, DMA_FROM_DEVICE); |
1685 | buffer_info->mapped = false; | 1717 | buffer_info->mapped = false; |
1686 | 1718 | ||
1687 | pr_debug("RxDecNo = 0x%04x Status[DMA:0x%02x GBE:0x%04x " | 1719 | netdev_dbg(netdev, |
1688 | "TCP:0x%08x] BufInf = 0x%p\n", | 1720 | "RxDecNo = 0x%04x Status[DMA:0x%02x GBE:0x%04x TCP:0x%08x] BufInf = 0x%p\n", |
1689 | i, dma_status, gbec_status, tcp_ip_status, | 1721 | i, dma_status, gbec_status, tcp_ip_status, |
1690 | buffer_info); | 1722 | buffer_info); |
1691 | /* Error check */ | 1723 | /* Error check */ |
1692 | if (unlikely(gbec_status & PCH_GBE_RXD_GMAC_STAT_NOTOCTAL)) { | 1724 | if (unlikely(gbec_status & PCH_GBE_RXD_GMAC_STAT_NOTOCTAL)) { |
1693 | adapter->stats.rx_frame_errors++; | 1725 | adapter->stats.rx_frame_errors++; |
1694 | pr_err("Receive Not Octal Error\n"); | 1726 | netdev_err(netdev, "Receive Not Octal Error\n"); |
1695 | } else if (unlikely(gbec_status & | 1727 | } else if (unlikely(gbec_status & |
1696 | PCH_GBE_RXD_GMAC_STAT_NBLERR)) { | 1728 | PCH_GBE_RXD_GMAC_STAT_NBLERR)) { |
1697 | adapter->stats.rx_frame_errors++; | 1729 | adapter->stats.rx_frame_errors++; |
1698 | pr_err("Receive Nibble Error\n"); | 1730 | netdev_err(netdev, "Receive Nibble Error\n"); |
1699 | } else if (unlikely(gbec_status & | 1731 | } else if (unlikely(gbec_status & |
1700 | PCH_GBE_RXD_GMAC_STAT_CRCERR)) { | 1732 | PCH_GBE_RXD_GMAC_STAT_CRCERR)) { |
1701 | adapter->stats.rx_crc_errors++; | 1733 | adapter->stats.rx_crc_errors++; |
1702 | pr_err("Receive CRC Error\n"); | 1734 | netdev_err(netdev, "Receive CRC Error\n"); |
1703 | } else { | 1735 | } else { |
1704 | /* get receive length */ | 1736 | /* get receive length */ |
1705 | /* length convert[-3], length includes FCS length */ | 1737 | /* length convert[-3], length includes FCS length */ |
@@ -1730,8 +1762,9 @@ pch_gbe_clean_rx(struct pch_gbe_adapter *adapter, | |||
1730 | 1762 | ||
1731 | napi_gro_receive(&adapter->napi, skb); | 1763 | napi_gro_receive(&adapter->napi, skb); |
1732 | (*work_done)++; | 1764 | (*work_done)++; |
1733 | pr_debug("Receive skb->ip_summed: %d length: %d\n", | 1765 | netdev_dbg(netdev, |
1734 | skb->ip_summed, length); | 1766 | "Receive skb->ip_summed: %d length: %d\n", |
1767 | skb->ip_summed, length); | ||
1735 | } | 1768 | } |
1736 | /* return some buffers to hardware, one at a time is too slow */ | 1769 | /* return some buffers to hardware, one at a time is too slow */ |
1737 | if (unlikely(cleaned_count >= PCH_GBE_RX_BUFFER_WRITE)) { | 1770 | if (unlikely(cleaned_count >= PCH_GBE_RX_BUFFER_WRITE)) { |
@@ -1787,10 +1820,10 @@ int pch_gbe_setup_tx_resources(struct pch_gbe_adapter *adapter, | |||
1787 | tx_desc = PCH_GBE_TX_DESC(*tx_ring, desNo); | 1820 | tx_desc = PCH_GBE_TX_DESC(*tx_ring, desNo); |
1788 | tx_desc->gbec_status = DSC_INIT16; | 1821 | tx_desc->gbec_status = DSC_INIT16; |
1789 | } | 1822 | } |
1790 | pr_debug("tx_ring->desc = 0x%p tx_ring->dma = 0x%08llx\n" | 1823 | netdev_dbg(adapter->netdev, |
1791 | "next_to_clean = 0x%08x next_to_use = 0x%08x\n", | 1824 | "tx_ring->desc = 0x%p tx_ring->dma = 0x%08llx next_to_clean = 0x%08x next_to_use = 0x%08x\n", |
1792 | tx_ring->desc, (unsigned long long)tx_ring->dma, | 1825 | tx_ring->desc, (unsigned long long)tx_ring->dma, |
1793 | tx_ring->next_to_clean, tx_ring->next_to_use); | 1826 | tx_ring->next_to_clean, tx_ring->next_to_use); |
1794 | return 0; | 1827 | return 0; |
1795 | } | 1828 | } |
1796 | 1829 | ||
@@ -1829,10 +1862,10 @@ int pch_gbe_setup_rx_resources(struct pch_gbe_adapter *adapter, | |||
1829 | rx_desc = PCH_GBE_RX_DESC(*rx_ring, desNo); | 1862 | rx_desc = PCH_GBE_RX_DESC(*rx_ring, desNo); |
1830 | rx_desc->gbec_status = DSC_INIT16; | 1863 | rx_desc->gbec_status = DSC_INIT16; |
1831 | } | 1864 | } |
1832 | pr_debug("rx_ring->desc = 0x%p rx_ring->dma = 0x%08llx " | 1865 | netdev_dbg(adapter->netdev, |
1833 | "next_to_clean = 0x%08x next_to_use = 0x%08x\n", | 1866 | "rx_ring->desc = 0x%p rx_ring->dma = 0x%08llx next_to_clean = 0x%08x next_to_use = 0x%08x\n", |
1834 | rx_ring->desc, (unsigned long long)rx_ring->dma, | 1867 | rx_ring->desc, (unsigned long long)rx_ring->dma, |
1835 | rx_ring->next_to_clean, rx_ring->next_to_use); | 1868 | rx_ring->next_to_clean, rx_ring->next_to_use); |
1836 | return 0; | 1869 | return 0; |
1837 | } | 1870 | } |
1838 | 1871 | ||
@@ -1886,9 +1919,9 @@ static int pch_gbe_request_irq(struct pch_gbe_adapter *adapter) | |||
1886 | flags = IRQF_SHARED; | 1919 | flags = IRQF_SHARED; |
1887 | adapter->have_msi = false; | 1920 | adapter->have_msi = false; |
1888 | err = pci_enable_msi(adapter->pdev); | 1921 | err = pci_enable_msi(adapter->pdev); |
1889 | pr_debug("call pci_enable_msi\n"); | 1922 | netdev_dbg(netdev, "call pci_enable_msi\n"); |
1890 | if (err) { | 1923 | if (err) { |
1891 | pr_debug("call pci_enable_msi - Error: %d\n", err); | 1924 | netdev_dbg(netdev, "call pci_enable_msi - Error: %d\n", err); |
1892 | } else { | 1925 | } else { |
1893 | flags = 0; | 1926 | flags = 0; |
1894 | adapter->have_msi = true; | 1927 | adapter->have_msi = true; |
@@ -1896,9 +1929,11 @@ static int pch_gbe_request_irq(struct pch_gbe_adapter *adapter) | |||
1896 | err = request_irq(adapter->pdev->irq, &pch_gbe_intr, | 1929 | err = request_irq(adapter->pdev->irq, &pch_gbe_intr, |
1897 | flags, netdev->name, netdev); | 1930 | flags, netdev->name, netdev); |
1898 | if (err) | 1931 | if (err) |
1899 | pr_err("Unable to allocate interrupt Error: %d\n", err); | 1932 | netdev_err(netdev, "Unable to allocate interrupt Error: %d\n", |
1900 | pr_debug("adapter->have_msi : %d flags : 0x%04x return : 0x%04x\n", | 1933 | err); |
1901 | adapter->have_msi, flags, err); | 1934 | netdev_dbg(netdev, |
1935 | "adapter->have_msi : %d flags : 0x%04x return : 0x%04x\n", | ||
1936 | adapter->have_msi, flags, err); | ||
1902 | return err; | 1937 | return err; |
1903 | } | 1938 | } |
1904 | 1939 | ||
@@ -1919,7 +1954,7 @@ int pch_gbe_up(struct pch_gbe_adapter *adapter) | |||
1919 | 1954 | ||
1920 | /* Ensure we have a valid MAC */ | 1955 | /* Ensure we have a valid MAC */ |
1921 | if (!is_valid_ether_addr(adapter->hw.mac.addr)) { | 1956 | if (!is_valid_ether_addr(adapter->hw.mac.addr)) { |
1922 | pr_err("Error: Invalid MAC address\n"); | 1957 | netdev_err(netdev, "Error: Invalid MAC address\n"); |
1923 | goto out; | 1958 | goto out; |
1924 | } | 1959 | } |
1925 | 1960 | ||
@@ -1933,12 +1968,14 @@ int pch_gbe_up(struct pch_gbe_adapter *adapter) | |||
1933 | 1968 | ||
1934 | err = pch_gbe_request_irq(adapter); | 1969 | err = pch_gbe_request_irq(adapter); |
1935 | if (err) { | 1970 | if (err) { |
1936 | pr_err("Error: can't bring device up - irq request failed\n"); | 1971 | netdev_err(netdev, |
1972 | "Error: can't bring device up - irq request failed\n"); | ||
1937 | goto out; | 1973 | goto out; |
1938 | } | 1974 | } |
1939 | err = pch_gbe_alloc_rx_buffers_pool(adapter, rx_ring, rx_ring->count); | 1975 | err = pch_gbe_alloc_rx_buffers_pool(adapter, rx_ring, rx_ring->count); |
1940 | if (err) { | 1976 | if (err) { |
1941 | pr_err("Error: can't bring device up - alloc rx buffers pool failed\n"); | 1977 | netdev_err(netdev, |
1978 | "Error: can't bring device up - alloc rx buffers pool failed\n"); | ||
1942 | goto freeirq; | 1979 | goto freeirq; |
1943 | } | 1980 | } |
1944 | pch_gbe_alloc_tx_buffers(adapter, tx_ring); | 1981 | pch_gbe_alloc_tx_buffers(adapter, tx_ring); |
@@ -2015,11 +2052,11 @@ static int pch_gbe_sw_init(struct pch_gbe_adapter *adapter) | |||
2015 | 2052 | ||
2016 | /* Initialize the hardware-specific values */ | 2053 | /* Initialize the hardware-specific values */ |
2017 | if (pch_gbe_hal_setup_init_funcs(hw)) { | 2054 | if (pch_gbe_hal_setup_init_funcs(hw)) { |
2018 | pr_err("Hardware Initialization Failure\n"); | 2055 | netdev_err(netdev, "Hardware Initialization Failure\n"); |
2019 | return -EIO; | 2056 | return -EIO; |
2020 | } | 2057 | } |
2021 | if (pch_gbe_alloc_queues(adapter)) { | 2058 | if (pch_gbe_alloc_queues(adapter)) { |
2022 | pr_err("Unable to allocate memory for queues\n"); | 2059 | netdev_err(netdev, "Unable to allocate memory for queues\n"); |
2023 | return -ENOMEM; | 2060 | return -ENOMEM; |
2024 | } | 2061 | } |
2025 | spin_lock_init(&adapter->hw.miim_lock); | 2062 | spin_lock_init(&adapter->hw.miim_lock); |
@@ -2030,9 +2067,10 @@ static int pch_gbe_sw_init(struct pch_gbe_adapter *adapter) | |||
2030 | 2067 | ||
2031 | pch_gbe_init_stats(adapter); | 2068 | pch_gbe_init_stats(adapter); |
2032 | 2069 | ||
2033 | pr_debug("rx_buffer_len : %d mac.min_frame_size : %d mac.max_frame_size : %d\n", | 2070 | netdev_dbg(netdev, |
2034 | (u32) adapter->rx_buffer_len, | 2071 | "rx_buffer_len : %d mac.min_frame_size : %d mac.max_frame_size : %d\n", |
2035 | hw->mac.min_frame_size, hw->mac.max_frame_size); | 2072 | (u32) adapter->rx_buffer_len, |
2073 | hw->mac.min_frame_size, hw->mac.max_frame_size); | ||
2036 | return 0; | 2074 | return 0; |
2037 | } | 2075 | } |
2038 | 2076 | ||
@@ -2061,7 +2099,7 @@ static int pch_gbe_open(struct net_device *netdev) | |||
2061 | err = pch_gbe_up(adapter); | 2099 | err = pch_gbe_up(adapter); |
2062 | if (err) | 2100 | if (err) |
2063 | goto err_up; | 2101 | goto err_up; |
2064 | pr_debug("Success End\n"); | 2102 | netdev_dbg(netdev, "Success End\n"); |
2065 | return 0; | 2103 | return 0; |
2066 | 2104 | ||
2067 | err_up: | 2105 | err_up: |
@@ -2072,7 +2110,7 @@ err_setup_rx: | |||
2072 | pch_gbe_free_tx_resources(adapter, adapter->tx_ring); | 2110 | pch_gbe_free_tx_resources(adapter, adapter->tx_ring); |
2073 | err_setup_tx: | 2111 | err_setup_tx: |
2074 | pch_gbe_reset(adapter); | 2112 | pch_gbe_reset(adapter); |
2075 | pr_err("Error End\n"); | 2113 | netdev_err(netdev, "Error End\n"); |
2076 | return err; | 2114 | return err; |
2077 | } | 2115 | } |
2078 | 2116 | ||
@@ -2116,8 +2154,9 @@ static int pch_gbe_xmit_frame(struct sk_buff *skb, struct net_device *netdev) | |||
2116 | if (unlikely(!PCH_GBE_DESC_UNUSED(tx_ring))) { | 2154 | if (unlikely(!PCH_GBE_DESC_UNUSED(tx_ring))) { |
2117 | netif_stop_queue(netdev); | 2155 | netif_stop_queue(netdev); |
2118 | spin_unlock_irqrestore(&tx_ring->tx_lock, flags); | 2156 | spin_unlock_irqrestore(&tx_ring->tx_lock, flags); |
2119 | pr_debug("Return : BUSY next_to use : 0x%08x next_to clean : 0x%08x\n", | 2157 | netdev_dbg(netdev, |
2120 | tx_ring->next_to_use, tx_ring->next_to_clean); | 2158 | "Return : BUSY next_to use : 0x%08x next_to clean : 0x%08x\n", |
2159 | tx_ring->next_to_use, tx_ring->next_to_clean); | ||
2121 | return NETDEV_TX_BUSY; | 2160 | return NETDEV_TX_BUSY; |
2122 | } | 2161 | } |
2123 | 2162 | ||
@@ -2152,7 +2191,7 @@ static void pch_gbe_set_multi(struct net_device *netdev) | |||
2152 | int i; | 2191 | int i; |
2153 | int mc_count; | 2192 | int mc_count; |
2154 | 2193 | ||
2155 | pr_debug("netdev->flags : 0x%08x\n", netdev->flags); | 2194 | netdev_dbg(netdev, "netdev->flags : 0x%08x\n", netdev->flags); |
2156 | 2195 | ||
2157 | /* Check for Promiscuous and All Multicast modes */ | 2196 | /* Check for Promiscuous and All Multicast modes */ |
2158 | rctl = ioread32(&hw->reg->RX_MODE); | 2197 | rctl = ioread32(&hw->reg->RX_MODE); |
@@ -2192,7 +2231,8 @@ static void pch_gbe_set_multi(struct net_device *netdev) | |||
2192 | PCH_GBE_MAR_ENTRIES); | 2231 | PCH_GBE_MAR_ENTRIES); |
2193 | kfree(mta_list); | 2232 | kfree(mta_list); |
2194 | 2233 | ||
2195 | pr_debug("RX_MODE reg(check bit31,30 ADD,MLT) : 0x%08x netdev->mc_count : 0x%08x\n", | 2234 | netdev_dbg(netdev, |
2235 | "RX_MODE reg(check bit31,30 ADD,MLT) : 0x%08x netdev->mc_count : 0x%08x\n", | ||
2196 | ioread32(&hw->reg->RX_MODE), mc_count); | 2236 | ioread32(&hw->reg->RX_MODE), mc_count); |
2197 | } | 2237 | } |
2198 | 2238 | ||
@@ -2218,12 +2258,12 @@ static int pch_gbe_set_mac(struct net_device *netdev, void *addr) | |||
2218 | pch_gbe_mac_mar_set(&adapter->hw, adapter->hw.mac.addr, 0); | 2258 | pch_gbe_mac_mar_set(&adapter->hw, adapter->hw.mac.addr, 0); |
2219 | ret_val = 0; | 2259 | ret_val = 0; |
2220 | } | 2260 | } |
2221 | pr_debug("ret_val : 0x%08x\n", ret_val); | 2261 | netdev_dbg(netdev, "ret_val : 0x%08x\n", ret_val); |
2222 | pr_debug("dev_addr : %pM\n", netdev->dev_addr); | 2262 | netdev_dbg(netdev, "dev_addr : %pM\n", netdev->dev_addr); |
2223 | pr_debug("mac_addr : %pM\n", adapter->hw.mac.addr); | 2263 | netdev_dbg(netdev, "mac_addr : %pM\n", adapter->hw.mac.addr); |
2224 | pr_debug("MAC_ADR1AB reg : 0x%08x 0x%08x\n", | 2264 | netdev_dbg(netdev, "MAC_ADR1AB reg : 0x%08x 0x%08x\n", |
2225 | ioread32(&adapter->hw.reg->mac_adr[0].high), | 2265 | ioread32(&adapter->hw.reg->mac_adr[0].high), |
2226 | ioread32(&adapter->hw.reg->mac_adr[0].low)); | 2266 | ioread32(&adapter->hw.reg->mac_adr[0].low)); |
2227 | return ret_val; | 2267 | return ret_val; |
2228 | } | 2268 | } |
2229 | 2269 | ||
@@ -2245,7 +2285,7 @@ static int pch_gbe_change_mtu(struct net_device *netdev, int new_mtu) | |||
2245 | max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN; | 2285 | max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN; |
2246 | if ((max_frame < ETH_ZLEN + ETH_FCS_LEN) || | 2286 | if ((max_frame < ETH_ZLEN + ETH_FCS_LEN) || |
2247 | (max_frame > PCH_GBE_MAX_JUMBO_FRAME_SIZE)) { | 2287 | (max_frame > PCH_GBE_MAX_JUMBO_FRAME_SIZE)) { |
2248 | pr_err("Invalid MTU setting\n"); | 2288 | netdev_err(netdev, "Invalid MTU setting\n"); |
2249 | return -EINVAL; | 2289 | return -EINVAL; |
2250 | } | 2290 | } |
2251 | if (max_frame <= PCH_GBE_FRAME_SIZE_2048) | 2291 | if (max_frame <= PCH_GBE_FRAME_SIZE_2048) |
@@ -2274,9 +2314,10 @@ static int pch_gbe_change_mtu(struct net_device *netdev, int new_mtu) | |||
2274 | adapter->hw.mac.max_frame_size = max_frame; | 2314 | adapter->hw.mac.max_frame_size = max_frame; |
2275 | } | 2315 | } |
2276 | 2316 | ||
2277 | pr_debug("max_frame : %d rx_buffer_len : %d mtu : %d max_frame_size : %d\n", | 2317 | netdev_dbg(netdev, |
2278 | max_frame, (u32) adapter->rx_buffer_len, netdev->mtu, | 2318 | "max_frame : %d rx_buffer_len : %d mtu : %d max_frame_size : %d\n", |
2279 | adapter->hw.mac.max_frame_size); | 2319 | max_frame, (u32) adapter->rx_buffer_len, netdev->mtu, |
2320 | adapter->hw.mac.max_frame_size); | ||
2280 | return 0; | 2321 | return 0; |
2281 | } | 2322 | } |
2282 | 2323 | ||
@@ -2317,7 +2358,7 @@ static int pch_gbe_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) | |||
2317 | { | 2358 | { |
2318 | struct pch_gbe_adapter *adapter = netdev_priv(netdev); | 2359 | struct pch_gbe_adapter *adapter = netdev_priv(netdev); |
2319 | 2360 | ||
2320 | pr_debug("cmd : 0x%04x\n", cmd); | 2361 | netdev_dbg(netdev, "cmd : 0x%04x\n", cmd); |
2321 | 2362 | ||
2322 | if (cmd == SIOCSHWTSTAMP) | 2363 | if (cmd == SIOCSHWTSTAMP) |
2323 | return hwtstamp_ioctl(netdev, ifr, cmd); | 2364 | return hwtstamp_ioctl(netdev, ifr, cmd); |
@@ -2354,7 +2395,7 @@ static int pch_gbe_napi_poll(struct napi_struct *napi, int budget) | |||
2354 | bool poll_end_flag = false; | 2395 | bool poll_end_flag = false; |
2355 | bool cleaned = false; | 2396 | bool cleaned = false; |
2356 | 2397 | ||
2357 | pr_debug("budget : %d\n", budget); | 2398 | netdev_dbg(adapter->netdev, "budget : %d\n", budget); |
2358 | 2399 | ||
2359 | pch_gbe_clean_rx(adapter, adapter->rx_ring, &work_done, budget); | 2400 | pch_gbe_clean_rx(adapter, adapter->rx_ring, &work_done, budget); |
2360 | cleaned = pch_gbe_clean_tx(adapter, adapter->tx_ring); | 2401 | cleaned = pch_gbe_clean_tx(adapter, adapter->tx_ring); |
@@ -2377,8 +2418,9 @@ static int pch_gbe_napi_poll(struct napi_struct *napi, int budget) | |||
2377 | pch_gbe_enable_dma_rx(&adapter->hw); | 2418 | pch_gbe_enable_dma_rx(&adapter->hw); |
2378 | } | 2419 | } |
2379 | 2420 | ||
2380 | pr_debug("poll_end_flag : %d work_done : %d budget : %d\n", | 2421 | netdev_dbg(adapter->netdev, |
2381 | poll_end_flag, work_done, budget); | 2422 | "poll_end_flag : %d work_done : %d budget : %d\n", |
2423 | poll_end_flag, work_done, budget); | ||
2382 | 2424 | ||
2383 | return work_done; | 2425 | return work_done; |
2384 | } | 2426 | } |
@@ -2435,7 +2477,7 @@ static pci_ers_result_t pch_gbe_io_slot_reset(struct pci_dev *pdev) | |||
2435 | struct pch_gbe_hw *hw = &adapter->hw; | 2477 | struct pch_gbe_hw *hw = &adapter->hw; |
2436 | 2478 | ||
2437 | if (pci_enable_device(pdev)) { | 2479 | if (pci_enable_device(pdev)) { |
2438 | pr_err("Cannot re-enable PCI device after reset\n"); | 2480 | netdev_err(netdev, "Cannot re-enable PCI device after reset\n"); |
2439 | return PCI_ERS_RESULT_DISCONNECT; | 2481 | return PCI_ERS_RESULT_DISCONNECT; |
2440 | } | 2482 | } |
2441 | pci_set_master(pdev); | 2483 | pci_set_master(pdev); |
@@ -2455,7 +2497,8 @@ static void pch_gbe_io_resume(struct pci_dev *pdev) | |||
2455 | 2497 | ||
2456 | if (netif_running(netdev)) { | 2498 | if (netif_running(netdev)) { |
2457 | if (pch_gbe_up(adapter)) { | 2499 | if (pch_gbe_up(adapter)) { |
2458 | pr_debug("can't bring device back up after reset\n"); | 2500 | netdev_dbg(netdev, |
2501 | "can't bring device back up after reset\n"); | ||
2459 | return; | 2502 | return; |
2460 | } | 2503 | } |
2461 | } | 2504 | } |
@@ -2509,7 +2552,7 @@ static int pch_gbe_resume(struct device *device) | |||
2509 | 2552 | ||
2510 | err = pci_enable_device(pdev); | 2553 | err = pci_enable_device(pdev); |
2511 | if (err) { | 2554 | if (err) { |
2512 | pr_err("Cannot enable PCI device from suspend\n"); | 2555 | netdev_err(netdev, "Cannot enable PCI device from suspend\n"); |
2513 | return err; | 2556 | return err; |
2514 | } | 2557 | } |
2515 | pci_set_master(pdev); | 2558 | pci_set_master(pdev); |
@@ -2609,7 +2652,7 @@ static int pch_gbe_probe(struct pci_dev *pdev, | |||
2609 | adapter->ptp_pdev = pci_get_bus_and_slot(adapter->pdev->bus->number, | 2652 | adapter->ptp_pdev = pci_get_bus_and_slot(adapter->pdev->bus->number, |
2610 | PCI_DEVFN(12, 4)); | 2653 | PCI_DEVFN(12, 4)); |
2611 | if (ptp_filter_init(ptp_filter, ARRAY_SIZE(ptp_filter))) { | 2654 | if (ptp_filter_init(ptp_filter, ARRAY_SIZE(ptp_filter))) { |
2612 | pr_err("Bad ptp filter\n"); | 2655 | dev_err(&pdev->dev, "Bad ptp filter\n"); |
2613 | return -EINVAL; | 2656 | return -EINVAL; |
2614 | } | 2657 | } |
2615 | 2658 | ||
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c index 8653c3b81f84..cf7c9b3a255b 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c | |||
@@ -237,16 +237,17 @@ static int pch_gbe_validate_option(int *value, | |||
237 | case enable_option: | 237 | case enable_option: |
238 | switch (*value) { | 238 | switch (*value) { |
239 | case OPTION_ENABLED: | 239 | case OPTION_ENABLED: |
240 | pr_debug("%s Enabled\n", opt->name); | 240 | netdev_dbg(adapter->netdev, "%s Enabled\n", opt->name); |
241 | return 0; | 241 | return 0; |
242 | case OPTION_DISABLED: | 242 | case OPTION_DISABLED: |
243 | pr_debug("%s Disabled\n", opt->name); | 243 | netdev_dbg(adapter->netdev, "%s Disabled\n", opt->name); |
244 | return 0; | 244 | return 0; |
245 | } | 245 | } |
246 | break; | 246 | break; |
247 | case range_option: | 247 | case range_option: |
248 | if (*value >= opt->arg.r.min && *value <= opt->arg.r.max) { | 248 | if (*value >= opt->arg.r.min && *value <= opt->arg.r.max) { |
249 | pr_debug("%s set to %i\n", opt->name, *value); | 249 | netdev_dbg(adapter->netdev, "%s set to %i\n", |
250 | opt->name, *value); | ||
250 | return 0; | 251 | return 0; |
251 | } | 252 | } |
252 | break; | 253 | break; |
@@ -258,7 +259,8 @@ static int pch_gbe_validate_option(int *value, | |||
258 | ent = &opt->arg.l.p[i]; | 259 | ent = &opt->arg.l.p[i]; |
259 | if (*value == ent->i) { | 260 | if (*value == ent->i) { |
260 | if (ent->str[0] != '\0') | 261 | if (ent->str[0] != '\0') |
261 | pr_debug("%s\n", ent->str); | 262 | netdev_dbg(adapter->netdev, "%s\n", |
263 | ent->str); | ||
262 | return 0; | 264 | return 0; |
263 | } | 265 | } |
264 | } | 266 | } |
@@ -268,8 +270,8 @@ static int pch_gbe_validate_option(int *value, | |||
268 | BUG(); | 270 | BUG(); |
269 | } | 271 | } |
270 | 272 | ||
271 | pr_debug("Invalid %s value specified (%i) %s\n", | 273 | netdev_dbg(adapter->netdev, "Invalid %s value specified (%i) %s\n", |
272 | opt->name, *value, opt->err); | 274 | opt->name, *value, opt->err); |
273 | *value = opt->def; | 275 | *value = opt->def; |
274 | return -1; | 276 | return -1; |
275 | } | 277 | } |
@@ -318,7 +320,8 @@ static void pch_gbe_check_copper_options(struct pch_gbe_adapter *adapter) | |||
318 | .p = an_list} } | 320 | .p = an_list} } |
319 | }; | 321 | }; |
320 | if (speed || dplx) { | 322 | if (speed || dplx) { |
321 | pr_debug("AutoNeg specified along with Speed or Duplex, AutoNeg parameter ignored\n"); | 323 | netdev_dbg(adapter->netdev, |
324 | "AutoNeg specified along with Speed or Duplex, AutoNeg parameter ignored\n"); | ||
322 | hw->phy.autoneg_advertised = opt.def; | 325 | hw->phy.autoneg_advertised = opt.def; |
323 | } else { | 326 | } else { |
324 | int tmp = AutoNeg; | 327 | int tmp = AutoNeg; |
@@ -332,13 +335,16 @@ static void pch_gbe_check_copper_options(struct pch_gbe_adapter *adapter) | |||
332 | case 0: | 335 | case 0: |
333 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; | 336 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; |
334 | if ((speed || dplx)) | 337 | if ((speed || dplx)) |
335 | pr_debug("Speed and duplex autonegotiation enabled\n"); | 338 | netdev_dbg(adapter->netdev, |
339 | "Speed and duplex autonegotiation enabled\n"); | ||
336 | hw->mac.link_speed = SPEED_10; | 340 | hw->mac.link_speed = SPEED_10; |
337 | hw->mac.link_duplex = DUPLEX_HALF; | 341 | hw->mac.link_duplex = DUPLEX_HALF; |
338 | break; | 342 | break; |
339 | case HALF_DUPLEX: | 343 | case HALF_DUPLEX: |
340 | pr_debug("Half Duplex specified without Speed\n"); | 344 | netdev_dbg(adapter->netdev, |
341 | pr_debug("Using Autonegotiation at Half Duplex only\n"); | 345 | "Half Duplex specified without Speed\n"); |
346 | netdev_dbg(adapter->netdev, | ||
347 | "Using Autonegotiation at Half Duplex only\n"); | ||
342 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; | 348 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; |
343 | hw->phy.autoneg_advertised = PHY_ADVERTISE_10_HALF | | 349 | hw->phy.autoneg_advertised = PHY_ADVERTISE_10_HALF | |
344 | PHY_ADVERTISE_100_HALF; | 350 | PHY_ADVERTISE_100_HALF; |
@@ -346,8 +352,10 @@ static void pch_gbe_check_copper_options(struct pch_gbe_adapter *adapter) | |||
346 | hw->mac.link_duplex = DUPLEX_HALF; | 352 | hw->mac.link_duplex = DUPLEX_HALF; |
347 | break; | 353 | break; |
348 | case FULL_DUPLEX: | 354 | case FULL_DUPLEX: |
349 | pr_debug("Full Duplex specified without Speed\n"); | 355 | netdev_dbg(adapter->netdev, |
350 | pr_debug("Using Autonegotiation at Full Duplex only\n"); | 356 | "Full Duplex specified without Speed\n"); |
357 | netdev_dbg(adapter->netdev, | ||
358 | "Using Autonegotiation at Full Duplex only\n"); | ||
351 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; | 359 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; |
352 | hw->phy.autoneg_advertised = PHY_ADVERTISE_10_FULL | | 360 | hw->phy.autoneg_advertised = PHY_ADVERTISE_10_FULL | |
353 | PHY_ADVERTISE_100_FULL | | 361 | PHY_ADVERTISE_100_FULL | |
@@ -356,8 +364,10 @@ static void pch_gbe_check_copper_options(struct pch_gbe_adapter *adapter) | |||
356 | hw->mac.link_duplex = DUPLEX_FULL; | 364 | hw->mac.link_duplex = DUPLEX_FULL; |
357 | break; | 365 | break; |
358 | case SPEED_10: | 366 | case SPEED_10: |
359 | pr_debug("10 Mbps Speed specified without Duplex\n"); | 367 | netdev_dbg(adapter->netdev, |
360 | pr_debug("Using Autonegotiation at 10 Mbps only\n"); | 368 | "10 Mbps Speed specified without Duplex\n"); |
369 | netdev_dbg(adapter->netdev, | ||
370 | "Using Autonegotiation at 10 Mbps only\n"); | ||
361 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; | 371 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; |
362 | hw->phy.autoneg_advertised = PHY_ADVERTISE_10_HALF | | 372 | hw->phy.autoneg_advertised = PHY_ADVERTISE_10_HALF | |
363 | PHY_ADVERTISE_10_FULL; | 373 | PHY_ADVERTISE_10_FULL; |
@@ -365,22 +375,24 @@ static void pch_gbe_check_copper_options(struct pch_gbe_adapter *adapter) | |||
365 | hw->mac.link_duplex = DUPLEX_HALF; | 375 | hw->mac.link_duplex = DUPLEX_HALF; |
366 | break; | 376 | break; |
367 | case SPEED_10 + HALF_DUPLEX: | 377 | case SPEED_10 + HALF_DUPLEX: |
368 | pr_debug("Forcing to 10 Mbps Half Duplex\n"); | 378 | netdev_dbg(adapter->netdev, "Forcing to 10 Mbps Half Duplex\n"); |
369 | hw->mac.autoneg = hw->mac.fc_autoneg = 0; | 379 | hw->mac.autoneg = hw->mac.fc_autoneg = 0; |
370 | hw->phy.autoneg_advertised = 0; | 380 | hw->phy.autoneg_advertised = 0; |
371 | hw->mac.link_speed = SPEED_10; | 381 | hw->mac.link_speed = SPEED_10; |
372 | hw->mac.link_duplex = DUPLEX_HALF; | 382 | hw->mac.link_duplex = DUPLEX_HALF; |
373 | break; | 383 | break; |
374 | case SPEED_10 + FULL_DUPLEX: | 384 | case SPEED_10 + FULL_DUPLEX: |
375 | pr_debug("Forcing to 10 Mbps Full Duplex\n"); | 385 | netdev_dbg(adapter->netdev, "Forcing to 10 Mbps Full Duplex\n"); |
376 | hw->mac.autoneg = hw->mac.fc_autoneg = 0; | 386 | hw->mac.autoneg = hw->mac.fc_autoneg = 0; |
377 | hw->phy.autoneg_advertised = 0; | 387 | hw->phy.autoneg_advertised = 0; |
378 | hw->mac.link_speed = SPEED_10; | 388 | hw->mac.link_speed = SPEED_10; |
379 | hw->mac.link_duplex = DUPLEX_FULL; | 389 | hw->mac.link_duplex = DUPLEX_FULL; |
380 | break; | 390 | break; |
381 | case SPEED_100: | 391 | case SPEED_100: |
382 | pr_debug("100 Mbps Speed specified without Duplex\n"); | 392 | netdev_dbg(adapter->netdev, |
383 | pr_debug("Using Autonegotiation at 100 Mbps only\n"); | 393 | "100 Mbps Speed specified without Duplex\n"); |
394 | netdev_dbg(adapter->netdev, | ||
395 | "Using Autonegotiation at 100 Mbps only\n"); | ||
384 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; | 396 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; |
385 | hw->phy.autoneg_advertised = PHY_ADVERTISE_100_HALF | | 397 | hw->phy.autoneg_advertised = PHY_ADVERTISE_100_HALF | |
386 | PHY_ADVERTISE_100_FULL; | 398 | PHY_ADVERTISE_100_FULL; |
@@ -388,28 +400,33 @@ static void pch_gbe_check_copper_options(struct pch_gbe_adapter *adapter) | |||
388 | hw->mac.link_duplex = DUPLEX_HALF; | 400 | hw->mac.link_duplex = DUPLEX_HALF; |
389 | break; | 401 | break; |
390 | case SPEED_100 + HALF_DUPLEX: | 402 | case SPEED_100 + HALF_DUPLEX: |
391 | pr_debug("Forcing to 100 Mbps Half Duplex\n"); | 403 | netdev_dbg(adapter->netdev, |
404 | "Forcing to 100 Mbps Half Duplex\n"); | ||
392 | hw->mac.autoneg = hw->mac.fc_autoneg = 0; | 405 | hw->mac.autoneg = hw->mac.fc_autoneg = 0; |
393 | hw->phy.autoneg_advertised = 0; | 406 | hw->phy.autoneg_advertised = 0; |
394 | hw->mac.link_speed = SPEED_100; | 407 | hw->mac.link_speed = SPEED_100; |
395 | hw->mac.link_duplex = DUPLEX_HALF; | 408 | hw->mac.link_duplex = DUPLEX_HALF; |
396 | break; | 409 | break; |
397 | case SPEED_100 + FULL_DUPLEX: | 410 | case SPEED_100 + FULL_DUPLEX: |
398 | pr_debug("Forcing to 100 Mbps Full Duplex\n"); | 411 | netdev_dbg(adapter->netdev, |
412 | "Forcing to 100 Mbps Full Duplex\n"); | ||
399 | hw->mac.autoneg = hw->mac.fc_autoneg = 0; | 413 | hw->mac.autoneg = hw->mac.fc_autoneg = 0; |
400 | hw->phy.autoneg_advertised = 0; | 414 | hw->phy.autoneg_advertised = 0; |
401 | hw->mac.link_speed = SPEED_100; | 415 | hw->mac.link_speed = SPEED_100; |
402 | hw->mac.link_duplex = DUPLEX_FULL; | 416 | hw->mac.link_duplex = DUPLEX_FULL; |
403 | break; | 417 | break; |
404 | case SPEED_1000: | 418 | case SPEED_1000: |
405 | pr_debug("1000 Mbps Speed specified without Duplex\n"); | 419 | netdev_dbg(adapter->netdev, |
420 | "1000 Mbps Speed specified without Duplex\n"); | ||
406 | goto full_duplex_only; | 421 | goto full_duplex_only; |
407 | case SPEED_1000 + HALF_DUPLEX: | 422 | case SPEED_1000 + HALF_DUPLEX: |
408 | pr_debug("Half Duplex is not supported at 1000 Mbps\n"); | 423 | netdev_dbg(adapter->netdev, |
424 | "Half Duplex is not supported at 1000 Mbps\n"); | ||
409 | /* fall through */ | 425 | /* fall through */ |
410 | case SPEED_1000 + FULL_DUPLEX: | 426 | case SPEED_1000 + FULL_DUPLEX: |
411 | full_duplex_only: | 427 | full_duplex_only: |
412 | pr_debug("Using Autonegotiation at 1000 Mbps Full Duplex only\n"); | 428 | netdev_dbg(adapter->netdev, |
429 | "Using Autonegotiation at 1000 Mbps Full Duplex only\n"); | ||
413 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; | 430 | hw->mac.autoneg = hw->mac.fc_autoneg = 1; |
414 | hw->phy.autoneg_advertised = PHY_ADVERTISE_1000_FULL; | 431 | hw->phy.autoneg_advertised = PHY_ADVERTISE_1000_FULL; |
415 | hw->mac.link_speed = SPEED_1000; | 432 | hw->mac.link_speed = SPEED_1000; |
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c index b97c6575e018..da079073a6c6 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c | |||
@@ -97,6 +97,7 @@ | |||
97 | */ | 97 | */ |
98 | s32 pch_gbe_phy_get_id(struct pch_gbe_hw *hw) | 98 | s32 pch_gbe_phy_get_id(struct pch_gbe_hw *hw) |
99 | { | 99 | { |
100 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); | ||
100 | struct pch_gbe_phy_info *phy = &hw->phy; | 101 | struct pch_gbe_phy_info *phy = &hw->phy; |
101 | s32 ret; | 102 | s32 ret; |
102 | u16 phy_id1; | 103 | u16 phy_id1; |
@@ -115,8 +116,9 @@ s32 pch_gbe_phy_get_id(struct pch_gbe_hw *hw) | |||
115 | phy->id = (u32)phy_id1; | 116 | phy->id = (u32)phy_id1; |
116 | phy->id = ((phy->id << 6) | ((phy_id2 & 0xFC00) >> 10)); | 117 | phy->id = ((phy->id << 6) | ((phy_id2 & 0xFC00) >> 10)); |
117 | phy->revision = (u32) (phy_id2 & 0x000F); | 118 | phy->revision = (u32) (phy_id2 & 0x000F); |
118 | pr_debug("phy->id : 0x%08x phy->revision : 0x%08x\n", | 119 | netdev_dbg(adapter->netdev, |
119 | phy->id, phy->revision); | 120 | "phy->id : 0x%08x phy->revision : 0x%08x\n", |
121 | phy->id, phy->revision); | ||
120 | return 0; | 122 | return 0; |
121 | } | 123 | } |
122 | 124 | ||
@@ -134,7 +136,10 @@ s32 pch_gbe_phy_read_reg_miic(struct pch_gbe_hw *hw, u32 offset, u16 *data) | |||
134 | struct pch_gbe_phy_info *phy = &hw->phy; | 136 | struct pch_gbe_phy_info *phy = &hw->phy; |
135 | 137 | ||
136 | if (offset > PHY_MAX_REG_ADDRESS) { | 138 | if (offset > PHY_MAX_REG_ADDRESS) { |
137 | pr_err("PHY Address %d is out of range\n", offset); | 139 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
140 | |||
141 | netdev_err(adapter->netdev, "PHY Address %d is out of range\n", | ||
142 | offset); | ||
138 | return -EINVAL; | 143 | return -EINVAL; |
139 | } | 144 | } |
140 | *data = pch_gbe_mac_ctrl_miim(hw, phy->addr, PCH_GBE_HAL_MIIM_READ, | 145 | *data = pch_gbe_mac_ctrl_miim(hw, phy->addr, PCH_GBE_HAL_MIIM_READ, |
@@ -156,7 +161,10 @@ s32 pch_gbe_phy_write_reg_miic(struct pch_gbe_hw *hw, u32 offset, u16 data) | |||
156 | struct pch_gbe_phy_info *phy = &hw->phy; | 161 | struct pch_gbe_phy_info *phy = &hw->phy; |
157 | 162 | ||
158 | if (offset > PHY_MAX_REG_ADDRESS) { | 163 | if (offset > PHY_MAX_REG_ADDRESS) { |
159 | pr_err("PHY Address %d is out of range\n", offset); | 164 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
165 | |||
166 | netdev_err(adapter->netdev, "PHY Address %d is out of range\n", | ||
167 | offset); | ||
160 | return -EINVAL; | 168 | return -EINVAL; |
161 | } | 169 | } |
162 | pch_gbe_mac_ctrl_miim(hw, phy->addr, PCH_GBE_HAL_MIIM_WRITE, | 170 | pch_gbe_mac_ctrl_miim(hw, phy->addr, PCH_GBE_HAL_MIIM_WRITE, |
@@ -246,15 +254,14 @@ void pch_gbe_phy_set_rgmii(struct pch_gbe_hw *hw) | |||
246 | */ | 254 | */ |
247 | void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw) | 255 | void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw) |
248 | { | 256 | { |
249 | struct pch_gbe_adapter *adapter; | 257 | struct pch_gbe_adapter *adapter = pch_gbe_hw_to_adapter(hw); |
250 | struct ethtool_cmd cmd = { .cmd = ETHTOOL_GSET }; | 258 | struct ethtool_cmd cmd = { .cmd = ETHTOOL_GSET }; |
251 | int ret; | 259 | int ret; |
252 | u16 mii_reg; | 260 | u16 mii_reg; |
253 | 261 | ||
254 | adapter = container_of(hw, struct pch_gbe_adapter, hw); | ||
255 | ret = mii_ethtool_gset(&adapter->mii, &cmd); | 262 | ret = mii_ethtool_gset(&adapter->mii, &cmd); |
256 | if (ret) | 263 | if (ret) |
257 | pr_err("Error: mii_ethtool_gset\n"); | 264 | netdev_err(adapter->netdev, "Error: mii_ethtool_gset\n"); |
258 | 265 | ||
259 | ethtool_cmd_speed_set(&cmd, hw->mac.link_speed); | 266 | ethtool_cmd_speed_set(&cmd, hw->mac.link_speed); |
260 | cmd.duplex = hw->mac.link_duplex; | 267 | cmd.duplex = hw->mac.link_duplex; |
@@ -263,7 +270,7 @@ void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw) | |||
263 | pch_gbe_phy_write_reg_miic(hw, MII_BMCR, BMCR_RESET); | 270 | pch_gbe_phy_write_reg_miic(hw, MII_BMCR, BMCR_RESET); |
264 | ret = mii_ethtool_sset(&adapter->mii, &cmd); | 271 | ret = mii_ethtool_sset(&adapter->mii, &cmd); |
265 | if (ret) | 272 | if (ret) |
266 | pr_err("Error: mii_ethtool_sset\n"); | 273 | netdev_err(adapter->netdev, "Error: mii_ethtool_sset\n"); |
267 | 274 | ||
268 | pch_gbe_phy_sw_reset(hw); | 275 | pch_gbe_phy_sw_reset(hw); |
269 | 276 | ||