diff options
author | Mark Yao <mark.yao@rock-chips.com> | 2015-01-21 22:15:02 -0500 |
---|---|---|
committer | Mark Yao <mark.yao@rock-chips.com> | 2015-03-16 01:48:15 -0400 |
commit | 44ddb7ef38ae720849cf81e71c370e55071b05a7 (patch) | |
tree | b7b9d675a44eacfe8487deec7ead06e6e856f958 | |
parent | f76c83b580043d55b2899719da61fe000839812d (diff) |
drm/rockchip: vop: fix vop vsync/hsync polarity
Vop set wrong vsync/hsync polarity, it may cause some
display problem. known problem is that caused HDMI hdcp
authenticate failed, caused pixel offset with hdmi display.
the polarity description at RK3288 TRM doc:
dsp_vsync_pol
VSYNC polarity
1'b0 : negative
1'b1 : positive
dsp_hsync_pol
HSYNC polarity
1'b0 : negative
1'b1 : positive
Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Caesar Wang <wxt@rock-chips.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
-rw-r--r-- | drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 9a5c571b95fc..2b145ba5dc17 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c | |||
@@ -874,8 +874,8 @@ static int vop_crtc_mode_set(struct drm_crtc *crtc, | |||
874 | VOP_CTRL_SET(vop, out_mode, vop->connector_out_mode); | 874 | VOP_CTRL_SET(vop, out_mode, vop->connector_out_mode); |
875 | 875 | ||
876 | val = 0x8; | 876 | val = 0x8; |
877 | val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 1 : 0; | 877 | val |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1; |
878 | val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? (1 << 1) : 0; | 878 | val |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1); |
879 | VOP_CTRL_SET(vop, pin_pol, val); | 879 | VOP_CTRL_SET(vop, pin_pol, val); |
880 | 880 | ||
881 | VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len); | 881 | VOP_CTRL_SET(vop, htotal_pw, (htotal << 16) | hsync_len); |