diff options
author | David Rientjes <rientjes@google.com> | 2014-10-09 18:27:25 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-10-09 22:25:55 -0400 |
commit | 43e7a34d265e884b7cf34f9b05e6f2e0c05bf120 (patch) | |
tree | d6391807a6c0d444527158f69bc9b6c54b0aa4dc | |
parent | 99c0fd5e51c447917264154cb01a967804ace745 (diff) |
mm: rename allocflags_to_migratetype for clarity
The page allocator has gfp flags (like __GFP_WAIT) and alloc flags (like
ALLOC_CPUSET) that have separate semantics.
The function allocflags_to_migratetype() actually takes gfp flags, not
alloc flags, and returns a migratetype. Rename it to
gfpflags_to_migratetype().
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Acked-by: Mel Gorman <mgorman@suse.de>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Michal Nazarewicz <mina86@mina86.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Rik van Riel <riel@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | include/linux/gfp.h | 2 | ||||
-rw-r--r-- | mm/compaction.c | 4 | ||||
-rw-r--r-- | mm/page_alloc.c | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/include/linux/gfp.h b/include/linux/gfp.h index 5e7219dc0fae..41b30fd4d041 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h | |||
@@ -156,7 +156,7 @@ struct vm_area_struct; | |||
156 | #define GFP_DMA32 __GFP_DMA32 | 156 | #define GFP_DMA32 __GFP_DMA32 |
157 | 157 | ||
158 | /* Convert GFP flags to their corresponding migrate type */ | 158 | /* Convert GFP flags to their corresponding migrate type */ |
159 | static inline int allocflags_to_migratetype(gfp_t gfp_flags) | 159 | static inline int gfpflags_to_migratetype(const gfp_t gfp_flags) |
160 | { | 160 | { |
161 | WARN_ON((gfp_flags & GFP_MOVABLE_MASK) == GFP_MOVABLE_MASK); | 161 | WARN_ON((gfp_flags & GFP_MOVABLE_MASK) == GFP_MOVABLE_MASK); |
162 | 162 | ||
diff --git a/mm/compaction.c b/mm/compaction.c index b9cf751cc00e..7c687c0eef6e 100644 --- a/mm/compaction.c +++ b/mm/compaction.c | |||
@@ -1242,7 +1242,7 @@ static unsigned long compact_zone_order(struct zone *zone, int order, | |||
1242 | .nr_freepages = 0, | 1242 | .nr_freepages = 0, |
1243 | .nr_migratepages = 0, | 1243 | .nr_migratepages = 0, |
1244 | .order = order, | 1244 | .order = order, |
1245 | .migratetype = allocflags_to_migratetype(gfp_mask), | 1245 | .migratetype = gfpflags_to_migratetype(gfp_mask), |
1246 | .zone = zone, | 1246 | .zone = zone, |
1247 | .mode = mode, | 1247 | .mode = mode, |
1248 | }; | 1248 | }; |
@@ -1294,7 +1294,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist, | |||
1294 | return COMPACT_SKIPPED; | 1294 | return COMPACT_SKIPPED; |
1295 | 1295 | ||
1296 | #ifdef CONFIG_CMA | 1296 | #ifdef CONFIG_CMA |
1297 | if (allocflags_to_migratetype(gfp_mask) == MIGRATE_MOVABLE) | 1297 | if (gfpflags_to_migratetype(gfp_mask) == MIGRATE_MOVABLE) |
1298 | alloc_flags |= ALLOC_CMA; | 1298 | alloc_flags |= ALLOC_CMA; |
1299 | #endif | 1299 | #endif |
1300 | /* Compact each zone in the list */ | 1300 | /* Compact each zone in the list */ |
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 313338d74095..f07588b11d59 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c | |||
@@ -2523,7 +2523,7 @@ gfp_to_alloc_flags(gfp_t gfp_mask) | |||
2523 | alloc_flags |= ALLOC_NO_WATERMARKS; | 2523 | alloc_flags |= ALLOC_NO_WATERMARKS; |
2524 | } | 2524 | } |
2525 | #ifdef CONFIG_CMA | 2525 | #ifdef CONFIG_CMA |
2526 | if (allocflags_to_migratetype(gfp_mask) == MIGRATE_MOVABLE) | 2526 | if (gfpflags_to_migratetype(gfp_mask) == MIGRATE_MOVABLE) |
2527 | alloc_flags |= ALLOC_CMA; | 2527 | alloc_flags |= ALLOC_CMA; |
2528 | #endif | 2528 | #endif |
2529 | return alloc_flags; | 2529 | return alloc_flags; |
@@ -2786,7 +2786,7 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, | |||
2786 | struct zone *preferred_zone; | 2786 | struct zone *preferred_zone; |
2787 | struct zoneref *preferred_zoneref; | 2787 | struct zoneref *preferred_zoneref; |
2788 | struct page *page = NULL; | 2788 | struct page *page = NULL; |
2789 | int migratetype = allocflags_to_migratetype(gfp_mask); | 2789 | int migratetype = gfpflags_to_migratetype(gfp_mask); |
2790 | unsigned int cpuset_mems_cookie; | 2790 | unsigned int cpuset_mems_cookie; |
2791 | int alloc_flags = ALLOC_WMARK_LOW|ALLOC_CPUSET|ALLOC_FAIR; | 2791 | int alloc_flags = ALLOC_WMARK_LOW|ALLOC_CPUSET|ALLOC_FAIR; |
2792 | int classzone_idx; | 2792 | int classzone_idx; |