aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Huewe <PeterHuewe@gmx.de>2013-01-25 17:23:30 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2013-02-06 06:05:07 -0500
commit42f9de6eab3892d7da544be1cc882530eab5b203 (patch)
treeca85fc060e4fae1e1d76657389aeafbf844c5ee0
parent0a147c3bf75d429fc7922abb582c7c686b028bc4 (diff)
[media] staging/media/go7007: Use kmemdup rather than duplicating its implementation
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/staging/media/go7007/go7007-driver.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/media/go7007/go7007-driver.c b/drivers/staging/media/go7007/go7007-driver.c
index 0aaeb0aeb99e..66950916df23 100644
--- a/drivers/staging/media/go7007/go7007-driver.c
+++ b/drivers/staging/media/go7007/go7007-driver.c
@@ -108,14 +108,13 @@ static int go7007_load_encoder(struct go7007 *go)
108 return -1; 108 return -1;
109 } 109 }
110 fw_len = fw_entry->size - 16; 110 fw_len = fw_entry->size - 16;
111 bounce = kmalloc(fw_len, GFP_KERNEL); 111 bounce = kmemdup(fw_entry->data + 16, fw_len, GFP_KERNEL);
112 if (bounce == NULL) { 112 if (bounce == NULL) {
113 v4l2_err(go, "unable to allocate %d bytes for " 113 v4l2_err(go, "unable to allocate %d bytes for "
114 "firmware transfer\n", fw_len); 114 "firmware transfer\n", fw_len);
115 release_firmware(fw_entry); 115 release_firmware(fw_entry);
116 return -1; 116 return -1;
117 } 117 }
118 memcpy(bounce, fw_entry->data + 16, fw_len);
119 release_firmware(fw_entry); 118 release_firmware(fw_entry);
120 if (go7007_interface_reset(go) < 0 || 119 if (go7007_interface_reset(go) < 0 ||
121 go7007_send_firmware(go, bounce, fw_len) < 0 || 120 go7007_send_firmware(go, bounce, fw_len) < 0 ||